fixup! Fix: Many false positives for waf_blocked alarm in idle deployments (#7642)

Author: dsotirho-ucsc

deployments/prod/environment.py

@@ -1927,5 +1927,7 @@ def env() -> Mapping[str, str | None]:
 
         'AZUL_MIRROR_BUCKET': 'humancellatlas',
 
-        'AZUL_MIRRORING_CONCURRENCY': '128'
+        'AZUL_MIRRORING_CONCURRENCY': '128',
+
+        'azul_blocked_alarm_threshold': '25'
     }

environment.py

@@ -925,7 +925,5 @@ def env() -> Mapping[str, str | None]:
         # requests, divided by the number of all requests, times 100) for a
         # configured period before a metric alarm is tripped.
         #
-        # If None, a default value set in azul.Config will be used.
-        #
-        'azul_blocked_alarm_threshold': None
+        'azul_blocked_alarm_threshold': '50'
     }

src/azul/__init__.py

@@ -1857,11 +1857,7 @@ def waf_bot_control(self) -> bool:
 
     @property
     def blocked_alarm_threshold(self) -> int:
-        value = self.environ.get('azul_blocked_alarm_threshold')
-        if value is None:
-            return 25 if self.deployment_stage == 'prod' else 50
-        else:
-            return int(value)
+        return int(self.environ['azul_blocked_alarm_threshold'])
 
     @property
     def vpc_cidr(self) -> str: