Skip to content

Commit 5b2b966

Browse files
committed
PR feedback
1 parent 3e394f6 commit 5b2b966

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed
Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
package org.broadinstitute.consent.http.models;
22

33
import java.sql.Timestamp;
4-
import java.time.LocalDateTime;
5-
import java.time.ZoneId;
6-
import java.time.ZonedDateTime;
74

85
public record DarMetricsSummary(
96
Timestamp updateDate,
@@ -20,17 +17,6 @@ public DarMetricsSummary(DataAccessRequest dar) {
2017
dar != null ? dar.getDarCode() : null,
2118
dar != null && dar.getData() != null ? dar.getData().getNonTechRus() : null,
2219
dar != null ? dar.getReferenceId() : null,
23-
computeExpired(dar));
24-
}
25-
26-
private static Boolean computeExpired(DataAccessRequest dar) {
27-
// If the DAR or its submission date is null, we consider it expired for metrics purposes
28-
if (dar == null || dar.getSubmissionDate() == null) {
29-
return true;
30-
}
31-
LocalDateTime oneYearAgo = LocalDateTime.now().minusYears(1);
32-
ZonedDateTime zonedDateTime = oneYearAgo.atZone(ZoneId.systemDefault());
33-
Timestamp lastYear = Timestamp.from(zonedDateTime.toInstant());
34-
return dar.getSubmissionDate().before(lastYear);
20+
dar == null || dar.getSubmissionDate() == null || dar.getExpired());
3521
}
3622
}

0 commit comments

Comments
 (0)