fix: address sonarqube issues

Author: fboulnois

src/components/data_library/LibraryDataGrid.tsx

@@ -6,9 +6,8 @@ import {
 } from '@mui/x-data-grid'
 import { Box, Typography, CircularProgress } from '@mui/material'
 import { isEmpty } from 'lodash'
-import { LibraryDataGridProps, AssetType } from 'src/types/library'
+import { LibraryDataGridProps, AssetType, StudyAggregation } from 'src/types/library'
 import { DatasetTerm } from 'src/types/model'
-import { StudyAggregation } from 'src/types/library'
 import { makeDatasetColumns } from './columns/datasetColumns'
 import { makeStudyColumns } from './columns/studyColumns'
 

src/components/data_library/LibraryFilters.tsx

@@ -35,7 +35,7 @@ export const LibraryFilters: React.FC<LibraryFiltersProps> = ({
   }
 
   const handleParticipantChange = (type: 'min' | 'max', value: string) => {
-    const numValue = value === '' ? undefined : parseInt(value)
+    const numValue = value === '' ? undefined : Number.parseInt(value)
     onChange({
       ...filters,
       participantCount: {

src/hooks/useLibraryData.ts

@@ -331,13 +331,13 @@ export const useLibraryData = (
         aggregations: {},
       }
     },
-    staleTime: 5 * 60 * 1000, // 5 minutes
-    retry: 1, // Only retry once on failure
+    staleTime: 5 * 60 * 1000,
+    retry: 1,
     // Provide default data structure on error to prevent crashes
     placeholderData: {
       items: [],
       total: 0,
       aggregations: {},
     },
   })
-}
+}

src/hooks/useLibraryUrlState.ts

@@ -12,10 +12,10 @@ const parseFiltersFromUrl = (searchParams: URLSearchParams): FilterState => {
     dac: searchParams.get('dac')?.split(',').filter(Boolean) || [],
     participantCount: {
       min: searchParams.get('minParticipants')
-        ? parseInt(searchParams.get('minParticipants')!)
+        ? Number.parseInt(searchParams.get('minParticipants')!)
         : undefined,
       max: searchParams.get('maxParticipants')
-        ? parseInt(searchParams.get('maxParticipants')!)
+        ? Number.parseInt(searchParams.get('maxParticipants')!)
         : undefined,
     },
   }
@@ -57,18 +57,18 @@ const serializeFiltersToUrl = (
     searchParams.delete('dac')
   }
 
-  if (filters.participantCount.min !== undefined) {
-    searchParams.set('minParticipants', filters.participantCount.min.toString())
+  if (filters.participantCount.min === undefined) {
+    searchParams.delete('minParticipants')
   }
   else {
-    searchParams.delete('minParticipants')
+    searchParams.set('minParticipants', filters.participantCount.min.toString())
   }
 
-  if (filters.participantCount.max !== undefined) {
-    searchParams.set('maxParticipants', filters.participantCount.max.toString())
+  if (filters.participantCount.max === undefined) {
+    searchParams.delete('maxParticipants')
   }
   else {
-    searchParams.delete('maxParticipants')
+    searchParams.set('maxParticipants', filters.participantCount.max.toString())
   }
 }
 
@@ -84,8 +84,8 @@ export const useLibraryUrlState = () => {
     tab: (searchParams.get('tab') as AssetType) || AssetType.STUDIES,
     search: searchParams.get('search') || '',
     filters: parseFiltersFromUrl(searchParams),
-    page: parseInt(searchParams.get('page') || '0'),
-    pageSize: parseInt(searchParams.get('pageSize') || '25'),
+    page: Number.parseInt(searchParams.get('page') || '0'),
+    pageSize: Number.parseInt(searchParams.get('pageSize') || '25'),
     sortField: searchParams.get('sort') || undefined,
     sortOrder: (searchParams.get('order') as 'asc' | 'desc') || undefined,
   }
@@ -131,11 +131,11 @@ export const useLibraryUrlState = () => {
     }
 
     if (updates.pageSize !== undefined) {
-      if (updates.pageSize !== 25) {
-        newParams.set('pageSize', updates.pageSize.toString())
+      if (updates.pageSize === 25) {
+        newParams.delete('pageSize')
       }
       else {
-        newParams.delete('pageSize')
+        newParams.set('pageSize', updates.pageSize.toString())
       }
     }
 

src/pages/DataLibrary.tsx

@@ -35,7 +35,6 @@ export const DataLibrary: React.FC = () => {
   // Local selection state (dataset IDs)
   const [selectedDatasetIds, setSelectedDatasetIds] = useState<number[]>([])
 
-  // Library configuration (could be made dynamic based on urlState.library)
   const libraryConfig: LibraryVersion = {
     key: 'duos',
     query: null,
@@ -46,13 +45,11 @@ export const DataLibrary: React.FC = () => {
     order: 0,
   }
 
-  // Tab configuration
   const tabs: TabConfig[] = [
     { key: AssetType.STUDIES, label: 'Studies' },
     { key: AssetType.DATASETS, label: 'Datasets' },
   ]
 
-  // Available filters (in a real app, these might come from an API)
   const availableFilters: AvailableFilters = {
     accessManagement: [
       { value: 'controlled', label: 'Controlled' },
@@ -70,7 +67,7 @@ export const DataLibrary: React.FC = () => {
       { value: 'Genomic', label: 'Genomic' },
       { value: 'Transcriptomic', label: 'Transcriptomic' },
     ],
-    dac: [], // Would be populated from API
+    dac: [],
     participantCountRange: {
       min: 0,
       max: 100000,
@@ -89,34 +86,29 @@ export const DataLibrary: React.FC = () => {
       : undefined,
   )
 
-  // Handle tab change
   const handleTabChange = (newAssetType: AssetType) => {
     updateUrlState({ tab: newAssetType })
-    setSelectedDatasetIds([]) // Clear selection when switching tabs
+    setSelectedDatasetIds([])
   }
 
-  // Handle search change
   const handleSearchChange = (searchTerm: string) => {
     updateUrlState({
       search: searchTerm,
-      page: 0, // Reset to first page
+      page: 0,
     })
   }
 
-  // Handle clear search
   const handleClearSearch = () => {
     updateUrlState({ search: '' })
   }
 
-  // Handle filter changes
   const handleFiltersChange = (newFilters: typeof urlState.filters) => {
     updateUrlState({
       filters: newFilters,
-      page: 0, // Reset to first page
+      page: 0,
     })
   }
 
-  // Handle clear filters
   const handleClearFilters = () => {
     updateUrlState({
       filters: {
@@ -130,15 +122,13 @@ export const DataLibrary: React.FC = () => {
     })
   }
 
-  // Convert sort model for DataGrid
   const sortModel = useMemo(() => {
     if (urlState.sortField && urlState.sortOrder) {
       return [{ field: urlState.sortField, sort: urlState.sortOrder }]
     }
     return []
   }, [urlState.sortField, urlState.sortOrder])
 
-  // Handle sort changes
   const handleSortChange = (model: Array<{ field: string, sort: 'asc' | 'desc' | null }>) => {
     if (model.length > 0 && model[0].sort) {
       updateUrlState({
@@ -154,19 +144,16 @@ export const DataLibrary: React.FC = () => {
     }
   }
 
-  // Handle selection changes
   const handleSelectionChange = (datasetIds: number[]) => {
     setSelectedDatasetIds(datasetIds)
   }
 
-  // Handle Apply for Access
   const handleApplyForAccess = () => {
     // Navigate to DAR Application with selected dataset IDs
     const datasetIdsParam = selectedDatasetIds.join(',')
     navigate(`/dar_application?datasetIds=${datasetIdsParam}`)
   }
 
-  // Show error state
   if (error) {
     return (
       <Box sx={{ px: 3, py: 4 }}>
@@ -183,7 +170,7 @@ export const DataLibrary: React.FC = () => {
       {/* Header */}
       <Box sx={{ px: 3, pt: 3 }}>
         <LibraryHeader
-          icon={null} // Using MUI icon instead
+          icon={null}
           title="Data Library"
           description="Search and browse available datasets and studies"
           searchTerm={urlState.search}

src/types/library.ts

@@ -8,7 +8,7 @@ import { DatasetTerm } from './model'
 export enum AssetType {
   STUDIES = 'studies',
   DATASETS = 'datasets',
-  AI_MODELS = 'ai-models', // Future
+  MODELS = 'models',
 }
 
 // Library configuration
@@ -335,7 +335,7 @@ export interface LibraryFiltersProps {
 
 export interface LibraryDataGridProps {
   assetType: AssetType
-  data: any[]
+  data: unknown[]
   loading: boolean
   total: number
   paginationModel: {