chore: update the package-lock (#720) (#721)

* chore: update the package-lock (#720)

* chore: upgrade @typescript-eslint/eslint-plugin to be within typescript range (#720)

* docs: update readme (#720)

---------

Co-authored-by: Fran McDade <18710366+frano-m@users.noreply.github.com>

Author: frano-m

.eslintrc.json

@@ -71,7 +71,8 @@
     {
       "files": "**/*.test.ts",
       "rules": {
-        "@typescript-eslint/no-explicit-any": "off"
+        "@typescript-eslint/no-explicit-any": "off",
+        "sonarjs/no-duplicate-string": "off"
       }
     }
   ]

README.md

@@ -14,22 +14,18 @@
    the [Data Biosphere Data Browser](https://github.com/DataBiosphere/data-browser).
 2. Set `node` version to `22.12.0` (this is also the version used by the Data Browser).
 3. In the `findable-ui` repository directory:
-    - Run `npm ci`.
-    - [Bump the version number](https://docs.npmjs.com/cli/v6/commands/npm-version) in `package.json`
-      e.g. `npm version <update_type>`.
+    - Run `npm update`.
     - Run `npx tsc` (this should be run when this repository is first downloaded and when any changes are made to the
       source files; one way this can be done more efficiently is
       by [setting the default build task](https://code.visualstudio.com/docs/typescript/typescript-compiling#_step-3-make-the-typescript-build-the-default)
       in VS Code so that it can be done with a keyboard shortcut).
 4. In the Data Browser `explorer` directory (e.g. `data-browser/explorer`):
-    - Run `npm ci`.
-    - Update the `@databiosphere/findable-ui` dependency in the `package.json` file to use the new version
-      of Findable UI.
-    - Run `npm link ../../findable-ui`, which will create a symlink in node_modules pointing
+    - Run `npm update`.
+    - Run `npm link ../findable-ui`, which will create a symlink in node_modules pointing
       to findable-ui.
     - If any packages are later installed or uninstalled, the symlink will need to be created again, which can be done
       with the same command or by running `npm link @databiosphere/findable-ui`. 
     - To successfully link to findable-ui, you may need to comment out the following packages from the `next.config.mjs` webpack configuration:
       - `@tanstack/react-table`
-      - `axios`
+
 

package-lock.json

@@ -25,7 +25,6 @@
     "@commitlint/cli": "^17.4.2",
     "@commitlint/config-conventional": "^17.4.2",
     "@emotion/jest": "^11.13.0",
-    "@mui/types": "^7.4.0",
     "@next/eslint-plugin-next": "^14.2.33",
     "@storybook/addon-actions": "^8.6.4",
     "@storybook/addon-essentials": "^8.6.4",
@@ -43,8 +42,8 @@
     "@types/react-dom": "^18.3.0",
     "@types/react-gtm-module": "^2.0.1",
     "@types/react-window": "^1.8.5",
-    "@types/uuid": "8.3.4",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
+    "@types/uuid": "^8.3.4",
+    "@typescript-eslint/eslint-plugin": "^8.49.0",
     "eslint": "^8.33.0",
     "eslint-config-next": "^14.2.33",
     "eslint-config-prettier": "^8.6.0",
@@ -75,7 +74,7 @@
     "@tanstack/match-sorter-utils": "^8.19.4",
     "@tanstack/react-table": "^8.19.2",
     "@tanstack/react-virtual": "^3.13.12",
-    "copy-to-clipboard": "3.3.1",
+    "copy-to-clipboard": "^3.3.1",
     "gray-matter": "^4.0.3",
     "isomorphic-dompurify": "^2.22.0",
     "ky": "^1.7.2",
@@ -85,9 +84,9 @@
     "react": "^18.3.1",
     "react-dom": "^18.3.1",
     "react-dropzone": "^14.2.3",
-    "react-gtm-module": "2.0.11",
+    "react-gtm-module": "^2.0.11",
     "react-idle-timer": "^5.7.2",
-    "react-window": "1.8.9",
+    "react-window": "^1.8.9",
     "rehype-raw": "^7.0.0",
     "rehype-react": "^7.2.0",
     "rehype-sanitize": "^5.0.1",
@@ -96,7 +95,7 @@
     "remark-rehype": "^10.1.0",
     "slugify": "^1.6.6",
     "unified": "^10.1.2",
-    "uuid": "8.3.2",
+    "uuid": "^8.3.2",
     "yup": "^1.6.1"
   },
   "overrides": {

package.json

@@ -6,7 +6,7 @@
 export function isValidUrl(testUrl: string): boolean {
   try {
     return Boolean(new URL(testUrl));
-  } catch (e) {
+  } catch {
     return false;
   }
 }

src/common/utils.ts

@@ -132,7 +132,7 @@ function isValidJsonString(query: string): boolean {
   try {
     JSON.parse(query);
     return true;
-  } catch (e) {
+  } catch {
     return false;
   }
 }

src/components/Links/components/Link/components/ExploreViewLink/exploreViewLink.tsx

@@ -13,7 +13,11 @@ export const Redirect = ({
   const router = useRouter();
 
   useEffect(() => {
-    replace ? router.replace(destination) : router.push(destination);
+    if (replace) {
+      router.replace(destination);
+    } else {
+      router.push(destination);
+    }
   }, [destination, replace, router]);
 
   return <></>;

src/components/Redirect/redirect.tsx

@@ -60,7 +60,7 @@ export const ToggleButtonGroup = ({
   ): void => {
     if (newToggleValue) {
       setToggleValue(newToggleValue);
-      onToggleFn && onToggleFn();
+      if (onToggleFn) onToggleFn();
     }
   };
 

src/components/common/ToggleButtonGroup/toggleButtonGroup.tsx

@@ -31,7 +31,7 @@ export function buildFetchFileUrl(url?: string): string | undefined {
       "/fetch/"
     );
     return urlObj.href;
-  } catch (e) {
+  } catch {
     throw new Error(`Invalid file URL: ${url}`);
   }
 }

src/hooks/useFileLocation.ts

@@ -245,7 +245,7 @@ declare module "@emotion/react" {
 }
 
 declare module "@tanstack/react-table" {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars -- TData and TValue are unused variables.
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type, @typescript-eslint/no-unused-vars -- TData and TValue are unused generic parameters for interface extension.
   interface Column<TData extends RowData, TValue> extends CustomFeatureColumn {}
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars -- TData and TValue are unused variables.
@@ -263,13 +263,13 @@ declare module "@tanstack/react-table" {
     width?: GridTrackSize;
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-empty-interface -- empty interface is needed for extending.
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type -- empty interface is needed for extending.
   interface InitialTableState extends CustomFeatureInitialTableState {}
 
-  // eslint-disable-next-line @typescript-eslint/no-empty-interface, @typescript-eslint/no-unused-vars -- empty interface is needed for extending, TData is an unused variable.
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type, @typescript-eslint/no-unused-vars -- empty interface is needed for extending, TData is an unused variable.
   interface Row<TData extends RowData> extends CustomFeatureRow {}
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars -- TData is an unused variables.
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars -- TData is an unused variable.
   interface SortingOptions<TData extends RowData> {
     /**
      * When false, sorting can still be applied programmatically (e.g., `getSortedRowModel`),
@@ -278,13 +278,14 @@ declare module "@tanstack/react-table" {
     enableSortingInteraction?: boolean;
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-empty-interface -- empty interface is needed for extending.
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type -- empty interface is needed for extending.
   interface Table<TData extends RowData> extends CustomFeatureInstance<TData> {}
 
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type -- empty interface is needed for extending.
   interface TableOptionsResolved<TData extends RowData>
     extends CustomFeatureOptions<TData> {}
 
-  // eslint-disable-next-line @typescript-eslint/no-empty-interface -- empty interface is needed for extending.
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type -- empty interface is needed for extending.
   interface TableState extends CustomFeatureTableState {}
 }