Skip to content

Commit c50fb88

Browse files
committed
Remove SSR assumptions from test suite and update comments
1 parent 6c9a344 commit c50fb88

File tree

2 files changed

+3
-39
lines changed

2 files changed

+3
-39
lines changed

src/hooks/useWindowResize.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export const useWindowResize = (timeout = 200): WindowSize => {
1515
const [windowSize, setWindowSize] = useState<WindowSize>(getWindowSize());
1616

1717
useEffect(() => {
18-
// Skip event listener setup on server.
18+
// Skip event listener setup during static build when window is not available.
1919
if (typeof window === "undefined") return;
2020
/**
2121
* Resize event fired; window size recalculated.

tests/useWindowResize.test.ts

Lines changed: 2 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -13,44 +13,8 @@ describe("useWindowResize", () => {
1313
jest.useRealTimers();
1414
});
1515

16-
test("handles SSR environment safely", () => {
17-
// Save original window properties
18-
const originalInnerWidth = window.innerWidth;
19-
const originalInnerHeight = window.innerHeight;
20-
21-
// Simulate SSR by making window properties undefined
22-
Object.defineProperty(window, "innerWidth", {
23-
configurable: true,
24-
get: () => undefined,
25-
});
26-
Object.defineProperty(window, "innerHeight", {
27-
configurable: true,
28-
get: () => undefined,
29-
});
30-
31-
// This should not throw an error
32-
expect(() => {
33-
const { result } = renderHook(() => useWindowResize());
34-
// In SSR-like scenario with undefined window properties, should get defaults
35-
expect(result.current.width).toBeDefined();
36-
expect(result.current.height).toBeDefined();
37-
}).not.toThrow();
38-
39-
// Restore original values
40-
Object.defineProperty(window, "innerWidth", {
41-
configurable: true,
42-
value: originalInnerWidth,
43-
writable: true,
44-
});
45-
Object.defineProperty(window, "innerHeight", {
46-
configurable: true,
47-
value: originalInnerHeight,
48-
writable: true,
49-
});
50-
});
51-
52-
test("returns current window dimensions on client", () => {
53-
// Restore window and set dimensions
16+
test("returns current window dimensions", () => {
17+
// Set window dimensions
5418
Object.defineProperty(window, "innerWidth", {
5519
configurable: true,
5620
value: 1024,

0 commit comments

Comments
 (0)