Skip to content

Commit 9aa343a

Browse files
committed
tweaks
1 parent 41cb151 commit 9aa343a

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

terra-base/Dockerfile

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,6 @@ FROM --platform=linux/amd64 nvidia/cuda:13.0.1-base-ubuntu22.04
33

44
LABEL maintainer="DSP Analysis Team <dsp-analysis@broadinstitute.org>"
55

6-
# TODO:
7-
# ! try moving conda setup before UV setup
8-
# ! specify that UV uses the conda python
9-
# add more comments/clearer naming around the python versions being used
10-
# double check that the correct CUDA/GPU drivers are available, otherwise copy from old base image via a multi-stage build
11-
# look into copying over apt-get packages from the old terra base image in next level of images
12-
# have examples of custom images extending this base image for different use cases (e.g. R, GATK, etc)
13-
146
# want the command to fail due to an error at any stage in the pipe: https://github.com/hadolint/hadolint/wiki/DL4006
157
SHELL ["/usr/bin/bash", "-o", "pipefail", "-c"]
168

terra-base/README.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# terra-jupyter-base image
22

3-
This repo contains the terra-jupyter-base image that is compatible with notebook service in [Terra]("https://app.terra.bio/") called Leonardo. For example, use `us.gcr.io/broad-dsp-gcr-public/terra-jupyter-base:{version}` in terra.
3+
This repo contains the terra-jupyter-base image that is compatible with notebook service in [Terra]("https://app.terra.bio/") called Leonardo. For example, use `us.gcr.io/broad-dsp-gcr-public/terra-base:{version}` in terra.
4+
5+
## Context
6+
This image is different from the legacy base image that is currently use to build the docker images cached in Terra (terra-jupyter-base).
7+
The current purpose of this new base image is to to unblock users from creating custom images in Terra.
48

59
## Image contents
610

@@ -50,9 +54,9 @@ If you change the following paths:
5054

5155
You may need to update the following files appropriately here and in Leonardo:
5256
- terra-docker
53-
- `conda_init.txt`
5457
- `run_jupyter.sh`
5558
- the notebook extension scripts
5659
- leonardo
5760
- `gce-init.sh`
61+
- `init-action.sh`
5862
- the `jupyterUserhome` in RuntimeTemplateValues

0 commit comments

Comments
 (0)