Merge pull request swiftlang#71817 from xedin/rdar-122598934

[ConstraintSystem] Account for situations when witness for associated…

Author: xedin

lib/Sema/ConstraintSystem.cpp

@@ -4219,7 +4219,7 @@ struct TypeSimplifier {
 
         auto result = conformance.getAssociatedType(
             lookupBaseType, assocType->getDeclaredInterfaceType());
-        if (!result->hasError())
+        if (result && !result->hasError())
           return result;
       }
 

validation-test/Sema/type_checker_crashers_fixed/rdar122598934.swift

@@ -0,0 +1,31 @@
+// RUN: not %target-swift-frontend %s -typecheck
+
+public protocol P1 {
+  associatedtype A
+
+  init(a: A)
+}
+
+public protocol P2: P1 {
+  associatedtype B
+
+  init()
+}
+
+extension P2 where A == B {
+  public init() { fatalError() }
+  public init(a: B) { fatalError() }
+}
+
+public protocol P3: P2 {
+  associatedtype B = Self
+
+  static var y: B { get }
+}
+
+public struct S: P3 {
+  public static let x = S(c: 1)
+  public static let y = S(c: 2)
+
+  public init(c: Int) {}
+}