Sema: Don't include @_exported on suggested imports.

tshortli · tshortli · commit 7d95914f25ac · 2024-08-05T11:28:26.000-07:00
The `@_exported` attribute does not need to be used consistently on imports in
different source files. Additionally, since the declarations from exported
imports are implicitly visible in every source file, diagnostics will never
need to suggest imports of these modules anyways.
diff --git a/lib/Sema/TypeCheckNameLookup.cpp b/lib/Sema/TypeCheckNameLookup.cpp
@@ -783,9 +783,6 @@ bool swift::diagnoseMissingImportForMember(const ValueDecl *decl,
       flags |= sf->getImportFlags(definingModule);
   }
 
-  if (flags.contains(ImportFlags::Exported) ||
-      parentModule->isClangOverlayOf(definingModule))
-    importText += "@_exported ";
   if (flags.contains(ImportFlags::ImplementationOnly))
     importText += "@_implementationOnly ";
   if (flags.contains(ImportFlags::WeakLinked))

Original file line number	Diff line number	Diff line change
`@@ -783,9 +783,6 @@ bool swift::diagnoseMissingImportForMember(const ValueDecl *decl,`
`783`	`783`	`flags \|= sf->getImportFlags(definingModule);`
`784`	`784`	`}`
`785`	`785`
`786`		`- if (flags.contains(ImportFlags::Exported) \|\|`
`787`		`- parentModule->isClangOverlayOf(definingModule))`
`788`		`- importText += "@_exported ";`
`789`	`786`	`if (flags.contains(ImportFlags::ImplementationOnly))`
`790`	`787`	`importText += "@_implementationOnly ";`
`791`	`788`	`if (flags.contains(ImportFlags::WeakLinked))`