Skip to content

Commit 0714581

Browse files
committed
[PANA-6072] fix unit test + typecheck
1 parent db0bcf7 commit 0714581

File tree

5 files changed

+11
-12
lines changed

5 files changed

+11
-12
lines changed

packages/core/src/domain/configuration/configuration.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -138,15 +138,6 @@ export interface InitConfiguration {
138138
*/
139139
allowedTrackingOrigins?: MatchOption[] | undefined
140140

141-
/**
142-
* A list of HTML attributes allowed to be used in the action selector collection.
143-
* Matches attributes against the event target and its ancestors.
144-
* If not provided, the SDK will use a default list of HTML attributes.
145-
*
146-
* @category Data Collection
147-
*/
148-
allowedHtmlAttributes?: MatchOption[] | undefined
149-
150141
// transport options
151142
/**
152143
* Optional proxy URL, for example: https://www.proxy.com/path.

packages/core/test/coreConfiguration.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ export const EXHAUSTIVE_INIT_CONFIGURATION: Required<InitConfiguration> = {
4242
source: 'browser',
4343
sdkVersion: '1.0.0',
4444
variant: 'variant',
45-
allowedHtmlAttributes: [],
4645
}
4746

4847
export const SERIALIZED_EXHAUSTIVE_INIT_CONFIGURATION = {
@@ -67,7 +66,6 @@ export const SERIALIZED_EXHAUSTIVE_INIT_CONFIGURATION = {
6766
source: 'browser',
6867
sdk_version: '1.0.0',
6968
variant: 'variant',
70-
allowed_html_attributes: [],
7169
}
7270

7371
/**

packages/rum-core/src/domain/action/trackClickActions.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ describe('trackClickActions', () => {
133133
selector: '#button',
134134
width: 100,
135135
height: 100,
136-
composed_path_selector: '#button',
136+
composed_path_selector: 'BUTTON#button[type="button"]:nth-child(1);',
137137
},
138138
position: { x: 50, y: 50 },
139139
events: [domEvent],

packages/rum-core/src/domain/configuration/configuration.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,15 @@ export interface RumInitConfiguration extends InitConfiguration {
281281
* @category Data Collection
282282
*/
283283
allowedGraphQlUrls?: Array<MatchOption | GraphQlUrlOption> | undefined
284+
285+
/**
286+
* A list of HTML attributes allowed to be used in the action selector collection.
287+
* Matches attributes against the event target and its ancestors.
288+
* If not provided, the SDK will use a default list of HTML attributes.
289+
*
290+
* @category Data Collection
291+
*/
292+
allowedHtmlAttributes?: MatchOption[] | undefined
284293
}
285294

286295
export type HybridInitConfiguration = Omit<RumInitConfiguration, 'applicationId' | 'clientToken'>

packages/rum-core/src/domain/getComposedPathSelector.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ function computePositionData(element: Element): { nthChild?: number; nthOfType?:
150150
let nthChild: number | undefined
151151
let nthOfType: number | undefined
152152
const sameTypeSiblings = siblings.filter((sibling) => sibling.tagName === element.tagName)
153+
153154
for (let i = 0, j = 0; i < siblings.length; i++) {
154155
const currentSibling = siblings[i]
155156
if (currentSibling.tagName === element.tagName) {

0 commit comments

Comments
 (0)