Skip to content

Commit 11d919e

Browse files
committed
🐛 pr-feedback: extract strategy condition
1 parent dff1756 commit 11d919e

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

packages/core/src/domain/configuration/configuration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ export function validateAndBuildConfiguration(initConfiguration: InitConfigurati
354354
return {
355355
beforeSend:
356356
initConfiguration.beforeSend && catchUserErrors(initConfiguration.beforeSend, 'beforeSend threw an error:'),
357-
sessionStoreStrategyType: selectSessionStoreStrategyType(initConfiguration),
357+
sessionStoreStrategyType: isWorkerEnvironment ? undefined : selectSessionStoreStrategyType(initConfiguration),
358358
sessionSampleRate: initConfiguration.sessionSampleRate ?? 100,
359359
telemetrySampleRate: initConfiguration.telemetrySampleRate ?? 20,
360360
telemetryConfigurationSampleRate: initConfiguration.telemetryConfigurationSampleRate ?? 5,

packages/core/src/domain/session/sessionStore.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { throttle } from '../../tools/utils/functionUtils'
55
import { generateUUID } from '../../tools/utils/stringUtils'
66
import type { InitConfiguration, Configuration } from '../configuration'
77
import { display } from '../../tools/display'
8-
import { isWorkerEnvironment } from '../../tools/globalObject'
98
import { selectCookieStrategy, initCookieStrategy } from './storeStrategies/sessionInCookie'
109
import type { SessionStoreStrategy, SessionStoreStrategyType } from './storeStrategies/sessionStoreStrategy'
1110
import type { SessionState } from './sessionState'
@@ -54,9 +53,7 @@ export function selectSessionStoreStrategyType(
5453
return selectLocalStorageStrategy()
5554

5655
case undefined: {
57-
let sessionStoreStrategyType = isWorkerEnvironment
58-
? selectLocalStorageStrategy()
59-
: selectCookieStrategy(initConfiguration)
56+
let sessionStoreStrategyType = selectCookieStrategy(initConfiguration)
6057
if (!sessionStoreStrategyType && initConfiguration.allowFallbackToLocalStorage) {
6158
sessionStoreStrategyType = selectLocalStorageStrategy()
6259
}

0 commit comments

Comments
 (0)