👷 handle undefined api key for source-maps upload to new DC

Author: thomas-lebeau

scripts/deploy/upload-source-maps.ts

@@ -88,10 +88,13 @@ function uploadToDatadog(
   sites: string[]
 ): void {
   for (const site of sites) {
-    if (!site) {
-      printLog(`No source maps upload configured for ${site}, skipping...`)
+    const apiKey = getTelemetryOrgApiKey(site)
+
+    if (!apiKey) {
+      printLog(`No API key configured for ${site}, skipping...`)
       continue
     }
+
     printLog(`Uploading ${packageName} source maps with prefix ${prefix} for ${site}...`)
 
     command`
@@ -103,7 +106,7 @@ function uploadToDatadog(
         --repository-url https://www.github.com/datadog/browser-sdk
     `
       .withEnvironment({
-        DATADOG_API_KEY: getTelemetryOrgApiKey(site),
+        DATADOG_API_KEY: apiKey,
         DATADOG_SITE: site,
       })
       .run()

scripts/lib/secrets.ts

@@ -42,14 +42,22 @@ export function getOrg2AppKey(): string {
   return getSecretKey('ci.browser-sdk.datadog_ci_application_key')
 }
 
-export function getTelemetryOrgApiKey(site: string): string {
+export function getTelemetryOrgApiKey(site: string): string | undefined {
   const normalizedSite = site.replaceAll('.', '-')
-  return getSecretKey(`ci.browser-sdk.source-maps.${normalizedSite}.ci_api_key`)
+  try {
+    return getSecretKey(`ci.browser-sdk.source-maps.${normalizedSite}.ci_api_key`)
+  } catch {
+    return
+  }
 }
 
-export function getTelemetryOrgApplicationKey(site: string): string {
+export function getTelemetryOrgApplicationKey(site: string): string | undefined {
   const normalizedSite = site.replaceAll('.', '-')
-  return getSecretKey(`ci.browser-sdk.telemetry.${normalizedSite}.ci_app_key`)
+  try {
+    return getSecretKey(`ci.browser-sdk.telemetry.${normalizedSite}.ci_app_key`)
+  } catch {
+    return
+  }
 }
 
 export function getNpmToken(): string {