Skip to content

Commit 551a36a

Browse files
committed
wip
1 parent c688d48 commit 551a36a

File tree

4 files changed

+18
-4
lines changed

4 files changed

+18
-4
lines changed

packages/rum-core/src/domain/assembly.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,14 @@ export function startRumAssembly(
135135
if (rawRumEvent.type === 'stream') {
136136
const streamEvent = {
137137
...(serverRumEvent as RumViewEvent),
138+
_dd: {
139+
...serverRumEvent._dd,
140+
document_version: serverRumEvent.stream?.document_version,
141+
},
142+
stream: {
143+
...serverRumEvent.stream,
144+
time_spent: undefined,
145+
},
138146
view: {
139147
...serverRumEvent.view,
140148
id: serverRumEvent.stream?.id,
@@ -147,6 +155,7 @@ export function startRumAssembly(
147155
resource: {
148156
count: 0,
149157
},
158+
time_spent: serverRumEvent.stream?.time_spent,
150159
},
151160
type: 'view',
152161
}

packages/rum-core/src/domain/stream/metric.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ export function createWeightAverageMetric() {
55

66
return {
77
get value() {
8-
console.log('>>>', value)
98
return value
109
},
1110
update(newLastUpdate: number, newValue: number) {

packages/rum-core/src/domain/stream/stream.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { clocksNow, generateUUID } from '@datadog/browser-core'
1+
import { clocksNow, generateUUID, ONE_SECOND } from '@datadog/browser-core'
22
import type { StartRumResult } from '../..'
33
import { createLastMetric, createWeightAverageMetric } from './metric'
44
import { createTimer } from './timer'
@@ -26,8 +26,8 @@ export function createStream(api: API) {
2626
bitrate: createWeightAverageMetric(),
2727
fps: createWeightAverageMetric(),
2828
timestamp: createLastMetric(),
29-
watchTime: createLastMetric(),
3029
}
30+
let documentVersion = 0
3131

3232
function sendStreamEvent() {
3333
const now = clocksNow()
@@ -41,15 +41,19 @@ export function createStream(api: API) {
4141
id,
4242
bitrate: metrics.bitrate.value,
4343
duration: meta.duration,
44+
document_version: documentVersion,
4445
format: meta.format,
4546
fps: metrics.fps.value,
4647
resolution: meta.resolution,
4748
timestamp: metrics.timestamp.value,
48-
watch_time: metrics.watchTime.value,
49+
time_spent: (now.relative - origin.relative) * ONE_SECOND,
50+
watch_time: timer.value * ONE_SECOND,
4951
},
5052
},
5153
{}
5254
)
55+
56+
documentVersion += 1
5357
}
5458

5559
return {

packages/rum-core/src/rawRumEvent.types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -363,10 +363,12 @@ export interface RawRumStreamEvent {
363363
stream: {
364364
id: string
365365
bitrate?: number
366+
document_version: number
366367
duration?: number
367368
format?: string
368369
fps?: number
369370
resolution?: string
371+
time_spent: number
370372
timestamp?: number
371373
watch_time?: number
372374
}

0 commit comments

Comments
 (0)