Skip to content

Commit 709530d

Browse files
committed
✅ fix tests in domain/view
1 parent 4b42124 commit 709530d

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

packages/rum-core/src/domain/view/trackViews.spec.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,17 @@ describe('view metrics', () => {
588588
jasmine.objectContaining({
589589
firstContentfulPaint: 123 as Duration,
590590
navigationTimings: jasmine.any(Object),
591-
largestContentfulPaint: { value: 789 as Duration, targetSelector: undefined, resourceUrl: undefined },
591+
largestContentfulPaint: {
592+
value: 789 as Duration,
593+
targetSelector: undefined,
594+
resourceUrl: undefined,
595+
subParts: {
596+
firstByte: 123,
597+
loadDelay: 0,
598+
loadTime: 0,
599+
renderDelay: 666
600+
}
601+
},
592602
})
593603
)
594604
})

packages/rum-core/src/domain/view/viewCollection.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ describe('viewCollection', () => {
185185
timestamp: (10 * 1e6) as ServerDuration,
186186
target_selector: undefined,
187187
resource_url: undefined,
188+
sub_parts: undefined,
188189
},
189190
},
190191
resource: {

packages/rum-core/src/domain/view/viewMetrics/trackLargestContentfulPaint.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export function trackLargestContentfulPaint(
8585
callback({
8686
value: lcpEntry.startTime,
8787
targetSelector: lcpTargetSelector,
88-
resourceUrl: resourceUrl,
88+
resourceUrl,
8989
subParts: {
9090
firstByte,
9191
loadDelay: (lcpRequestStart - firstByte) as RelativeTime,

0 commit comments

Comments
 (0)