Skip to content

Commit 9327732

Browse files
committed
fix: parse span and trace IDs as integers in ipcRenderer
1 parent bdec71a commit 9327732

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

packages/electron/src/domain/renderer/ipcRenderer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ function withDatadogCarrier<T extends (...args: any[]) => R, R>(
3838

3939
const notifySpan = () => {
4040
observable.notify({
41-
spanId: carrier['x-datadog-parent-id'],
42-
traceId: carrier['x-datadog-trace-id'],
4341
startClocks: startClock,
42+
spanId: parseInt(carrier['x-datadog-parent-id'], 10).toString(),
43+
traceId: parseInt(carrier['x-datadog-trace-id'], 10).toString(),
4444
duration: toServerDuration(elapsed(startClock.timeStamp, clocksNow().timeStamp)),
4545
name: `${SPAN_NAME_PREFIX}.${method}.${channel}`,
4646
})

packages/electron/src/domain/rum/mainProcessTracking.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ export function startMainProcessTracking(
3535
'\x1b[34m%s\x1b[0m',
3636
`https://app.datadoghq.com/rum/sessions?query=%40type%3Asession%20%40session.id%3A${mainProcessContext.sessionId}`
3737
)
38+
console.log(
39+
'\x1b[34m%s\x1b[0m',
40+
`https://app.datadoghq.com/apm/traces?query=%40_dd.session.id%3A${mainProcessContext.sessionId}`
41+
)
3842
const applicationStart = timeStampNow()
3943
let applicationLaunch = {
4044
type: RumEventType.VIEW,

0 commit comments

Comments
 (0)