Skip to content

Commit 94082e2

Browse files
committed
wip
1 parent 777e0b3 commit 94082e2

File tree

4 files changed

+18
-4
lines changed

4 files changed

+18
-4
lines changed

packages/rum-core/src/domain/assembly.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,14 @@ export function startRumAssembly(
136136
if (rawRumEvent.type === 'stream') {
137137
const streamEvent = {
138138
...(serverRumEvent as RumViewEvent),
139+
_dd: {
140+
...serverRumEvent._dd,
141+
document_version: serverRumEvent.stream?.document_version,
142+
},
143+
stream: {
144+
...serverRumEvent.stream,
145+
time_spent: undefined,
146+
},
139147
view: {
140148
...serverRumEvent.view,
141149
id: serverRumEvent.stream?.id,
@@ -148,6 +156,7 @@ export function startRumAssembly(
148156
resource: {
149157
count: 0,
150158
},
159+
time_spent: serverRumEvent.stream?.time_spent,
151160
},
152161
type: 'view',
153162
}

packages/rum-core/src/domain/stream/metric.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ export function createWeightAverageMetric() {
55

66
return {
77
get value() {
8-
console.log('>>>', value)
98
return value
109
},
1110
update(newLastUpdate: number, newValue: number) {

packages/rum-core/src/domain/stream/stream.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { clocksNow, generateUUID } from '@datadog/browser-core'
1+
import { clocksNow, generateUUID, ONE_SECOND } from '@datadog/browser-core'
22
import type { StartRumResult } from '../..'
33
import { createLastMetric, createWeightAverageMetric } from './metric'
44
import { createTimer } from './timer'
@@ -26,8 +26,8 @@ export function createStream(api: API) {
2626
bitrate: createWeightAverageMetric(),
2727
fps: createWeightAverageMetric(),
2828
timestamp: createLastMetric(),
29-
watchTime: createLastMetric(),
3029
}
30+
let documentVersion = 0
3131

3232
function sendStreamEvent() {
3333
const now = clocksNow()
@@ -41,15 +41,19 @@ export function createStream(api: API) {
4141
id,
4242
bitrate: metrics.bitrate.value,
4343
duration: meta.duration,
44+
document_version: documentVersion,
4445
format: meta.format,
4546
fps: metrics.fps.value,
4647
resolution: meta.resolution,
4748
timestamp: metrics.timestamp.value,
48-
watch_time: metrics.watchTime.value,
49+
time_spent: (now.relative - origin.relative) * ONE_SECOND,
50+
watch_time: timer.value * ONE_SECOND,
4951
},
5052
},
5153
{}
5254
)
55+
56+
documentVersion += 1
5357
}
5458

5559
return {

packages/rum-core/src/rawRumEvent.types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -387,10 +387,12 @@ export interface RawRumStreamEvent {
387387
stream: {
388388
id: string
389389
bitrate?: number
390+
document_version: number
390391
duration?: number
391392
format?: string
392393
fps?: number
393394
resolution?: string
395+
time_spent: number
394396
timestamp?: number
395397
watch_time?: number
396398
}

0 commit comments

Comments
 (0)