Added 'import/enforce-node-protocol-usage' (#3943)

thomas-lebeau · web-flow · commit 9948662eddd1 · 2025-11-05T10:10:30.000+01:00
diff --git a/eslint-local-rules/disallowGenericUtils.js b/eslint-local-rules/disallowGenericUtils.js
@@ -1,4 +1,4 @@
-import path from 'path'
+import path from 'node:path'
 
 export default {
   meta: {
diff --git a/eslint-local-rules/disallowSideEffects.js b/eslint-local-rules/disallowSideEffects.js
@@ -1,4 +1,4 @@
-import path from 'path'
+import path from 'node:path'
 
 export default {
   meta: {
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -428,6 +428,7 @@ export default tseslint.config(
     },
     rules: {
       '@typescript-eslint/no-require-imports': 'off',
+      'import/enforce-node-protocol-usage': ['error', 'always'],
     },
   },
 
diff --git a/scripts/check-licenses.ts b/scripts/check-licenses.ts
@@ -1,6 +1,6 @@
-import * as fs from 'fs'
-import * as path from 'path'
-import * as readline from 'readline'
+import * as fs from 'node:fs'
+import * as path from 'node:path'
+import * as readline from 'node:readline'
 import { printLog, printError, runMain } from './lib/executionUtils.ts'
 import { findBrowserSdkPackageJsonFiles } from './lib/filesUtils.ts'
 
diff --git a/scripts/check-node-version.ts b/scripts/check-node-version.ts
@@ -1,6 +1,6 @@
-import * as fs from 'fs'
-import * as readline from 'readline'
-import * as path from 'path'
+import * as fs from 'node:fs'
+import * as readline from 'node:readline'
+import * as path from 'node:path'
 import packageJson from '../package.json' with { type: 'json' }
 import { printLog, printError, runMain } from './lib/executionUtils.ts'
 
diff --git a/scripts/check-packages.ts b/scripts/check-packages.ts
@@ -1,5 +1,5 @@
-import * as fs from 'fs'
-import * as path from 'path'
+import * as fs from 'node:fs'
+import * as path from 'node:path'
 import { globSync } from 'node:fs'
 import { minimatch } from 'minimatch'
 import { printLog, printError, runMain, printWarning } from './lib/executionUtils.ts'
diff --git a/scripts/check-typescript-compatibility.ts b/scripts/check-typescript-compatibility.ts
@@ -1,5 +1,5 @@
-import * as fs from 'fs'
-import * as path from 'path'
+import * as fs from 'node:fs'
+import * as path from 'node:path'
 import { printLog, runMain } from './lib/executionUtils.ts'
 import { command } from './lib/command.ts'
 
diff --git a/scripts/deploy/publish-npm.ts b/scripts/deploy/publish-npm.ts
@@ -1,4 +1,4 @@
-import fs from 'fs'
+import fs from 'node:fs'
 import { printLog, runMain } from '../lib/executionUtils.ts'
 import { command } from '../lib/command.ts'
 import { getNpmToken } from '../lib/secrets.ts'
diff --git a/scripts/deploy/upload-source-maps.ts b/scripts/deploy/upload-source-maps.ts
@@ -1,4 +1,4 @@
-import path from 'path'
+import path from 'node:path'
 import { printLog, runMain } from '../lib/executionUtils.ts'
 import { command } from '../lib/command.ts'
 import { getBuildEnvValue } from '../lib/buildEnv.ts'
diff --git a/scripts/generate-schema-types.ts b/scripts/generate-schema-types.ts
@@ -1,5 +1,5 @@
-import * as fs from 'fs'
-import * as path from 'path'
+import * as fs from 'node:fs'
+import * as path from 'node:path'
 
 import { compileFromFile } from 'json-schema-to-typescript'
 import { resolveConfig } from 'prettier'
diff --git a/scripts/lib/buildEnv.ts b/scripts/lib/buildEnv.ts
@@ -1,6 +1,6 @@
-import { readFileSync } from 'fs'
-import path from 'path'
-import { execSync } from 'child_process'
+import { readFileSync } from 'node:fs'
+import path from 'node:path'
+import { execSync } from 'node:child_process'
 import { browserSdkVersion } from './browserSdkVersion.ts'
 import { command } from './command.ts'
 
diff --git a/scripts/lib/command.ts b/scripts/lib/command.ts
@@ -1,4 +1,4 @@
-import childProcess from 'child_process'
+import childProcess from 'node:child_process'
 import { printError } from './executionUtils.ts'
 
 interface CommandOptions {
diff --git a/scripts/lib/computeBundleSize.ts b/scripts/lib/computeBundleSize.ts
@@ -1,6 +1,6 @@
-import path from 'path'
-import fs from 'fs'
-import zlib from 'zlib'
+import path from 'node:path'
+import fs from 'node:fs'
+import zlib from 'node:zlib'
 import { glob } from 'glob'
 
 const packages = ['rum', 'logs', 'flagging', 'rum-slim', 'worker'] as const
diff --git a/scripts/lib/executionUtils.ts b/scripts/lib/executionUtils.ts
@@ -1,4 +1,4 @@
-import { spawn } from 'child_process'
+import { spawn } from 'node:child_process'
 
 /**
  * Helper to run executables asynchronously, in a shell. This function does not prevent Shell
diff --git a/scripts/lib/filesUtils.ts b/scripts/lib/filesUtils.ts
@@ -1,6 +1,6 @@
-import fs from 'fs'
-import path from 'path'
-import fsPromises from 'fs/promises'
+import fs from 'node:fs'
+import path from 'node:path'
+import fsPromises from 'node:fs/promises'
 import { command } from './command.ts'
 
 export const CI_FILE = '.gitlab-ci.yml'
diff --git a/scripts/lib/gitUtils.ts b/scripts/lib/gitUtils.ts
@@ -1,5 +1,5 @@
-import os from 'os'
-import fs from 'fs'
+import os from 'node:os'
+import fs from 'node:fs'
 import { command } from './command.ts'
 import {
   getGithubDeployKey,
diff --git a/scripts/lib/packagesDirectoryNames.ts b/scripts/lib/packagesDirectoryNames.ts
@@ -1,3 +1,3 @@
-import { readdirSync } from 'fs'
+import { readdirSync } from 'node:fs'
 
 export const packagesDirectoryNames: string[] = readdirSync('packages')
diff --git a/scripts/release/generate-changelog/lib/addNewChangesToChangelog.ts b/scripts/release/generate-changelog/lib/addNewChangesToChangelog.ts
@@ -1,5 +1,5 @@
-import { readFile } from 'fs/promises'
-import * as fs from 'fs'
+import { readFile } from 'node:fs/promises'
+import * as fs from 'node:fs'
 import * as emojiNameMap from 'emoji-name-map'
 
 import { browserSdkVersion } from '../../../lib/browserSdkVersion.ts'
diff --git a/scripts/release/generate-changelog/lib/getAffectedPackages.ts b/scripts/release/generate-changelog/lib/getAffectedPackages.ts
@@ -1,4 +1,4 @@
-import * as fs from 'fs'
+import * as fs from 'node:fs'
 import { packagesDirectoryNames } from '../../../lib/packagesDirectoryNames.ts'
 import { command } from '../../../lib/command.ts'
 
diff --git a/scripts/test/bs-wrapper.ts b/scripts/test/bs-wrapper.ts
@@ -13,7 +13,7 @@
 // after killing it. There might be a better way of prematurely aborting the test command if we need
 // to in the future.
 
-import { spawn, type ChildProcess } from 'child_process'
+import { spawn, type ChildProcess } from 'node:child_process'
 import browserStack from 'browserstack-local'
 import { printLog, runMain, timeout, printError } from '../lib/executionUtils.ts'
 import { command } from '../lib/command.ts'
diff --git a/test/apps/base-extension/webpack.config.js b/test/apps/base-extension/webpack.config.js
@@ -1,4 +1,4 @@
-const path = require('path')
+const path = require('node:path')
 
 module.exports = {
   mode: 'production',
diff --git a/test/apps/react-router-v6-app/webpack.config.js b/test/apps/react-router-v6-app/webpack.config.js
@@ -1,4 +1,4 @@
-const path = require('path')
+const path = require('node:path')
 
 module.exports = {
   mode: 'production',
diff --git a/test/apps/vanilla/webpack.base.js b/test/apps/vanilla/webpack.base.js
@@ -1,4 +1,4 @@
-const path = require('path')
+const path = require('node:path')
 
 const filename = 'app.js'
 module.exports = ({ target, optimization, mode }) => ({

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import path from 'path'`
	`1`	`+import path from 'node:path'`
`2`	`2`
`3`	`3`	`export default {`
`4`	`4`	`meta: {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import fs from 'fs'`
	`1`	`+import fs from 'node:fs'`
`2`	`2`	`import { printLog, runMain } from '../lib/executionUtils.ts'`
`3`	`3`	`import { command } from '../lib/command.ts'`
`4`	`4`	`import { getNpmToken } from '../lib/secrets.ts'`