👷 improve node detection

Author: mormubis

packages/core/src/tools/globalObject.ts

@@ -49,6 +49,6 @@ export function getGlobalObject<T = typeof globalThis>(): T {
 export const globalObject = getGlobalObject<GlobalObject>()
 
 export const isWorkerEnvironment = 'WorkerGlobalScope' in globalObject
-// @see https://stackoverflow.com/questions/4224606/how-to-check-whether-a-script-is-running-under-node-js
-// @ts-expect-error module is undefined outside of Node.
-export const isNodeEnvironment = typeof module !== 'undefined' && module.exports
+export const isNodeEnvironment =
+  // @ts-expect-error for Node.js-specific globals that are not present in browser environments
+  typeof process !== 'undefined' && process.versions !== null && process.versions.node !== null

test/apps/vanilla/app.ts

@@ -17,8 +17,23 @@ if (typeof window !== 'undefined') {
     window.RUM_INIT()
   }
 } else {
+  // Document is always generated by the SSR environment
+  // @ts-ignore If document is mocked, the SDK executes further enough to throw an error
+  globalThis.document = {}
+
+  // Check if the SDK sent any events
+  ;(globalThis as any).__ddBrowserSdkExtensionCallback = () => {
+    throw new Error('the SDK should not send events')
+  }
+
   // compat test
-  datadogLogs.init({ clientToken: 'xxx', beforeSend: undefined })
-  datadogRum.init({ clientToken: 'xxx', applicationId: 'xxx', beforeSend: undefined })
+
+  datadogLogs.init({ clientToken: 'xxx', beforeSend: undefined, telemetrySampleRate: 100 })
+  datadogRum.init({ clientToken: 'xxx', applicationId: 'xxx', beforeSend: undefined, telemetrySampleRate: 100 })
   datadogRum.setUser({ id: undefined })
+
+  // Check the SDK is not started
+  if (datadogLogs.getInternalContext() || datadogRum.getInternalContext()) {
+    throw new Error('SDK should not start on SSR environments')
+  }
 }