Merge branch 'main' into aymeric/fix-long-task-action-link

Author: amortemousque

.github/CODEOWNERS

@@ -1,11 +1,13 @@
 # Order is important, the last matching pattern takes the most precedence.
 
+# Default
+*    @Datadog/rum-browser
+
 # Global
-packages/flagging                          @Datadog/feature-flagging-experimentation
-packages/rum/src/domain/record             @Datadog/rum-browser @Datadog/session-replay-sdk
-packages/rum/src/domain/segmentCollection  @Datadog/rum-browser @Datadog/session-replay-sdk
-packages/rum/src/domain/*.ts               @Datadog/rum-browser @Datadog/session-replay-sdk
-*                                          @Datadog/rum-browser
+packages/flagging                               @Datadog/feature-flagging-experimentation
+packages/rum/src/domain/record/**               @Datadog/rum-browser @Datadog/session-replay-sdk
+packages/rum/src/domain/segmentCollection/**    @Datadog/rum-browser @Datadog/session-replay-sdk
+packages/rum/src/domain/*.ts                    @Datadog/rum-browser @Datadog/session-replay-sdk
 
 # Docs
 *README.md    @Datadog/rum-browser @DataDog/documentation

.gitlab-ci.yml

@@ -1,5 +1,5 @@
 variables:
-  CURRENT_STAGING: staging-50
+  CURRENT_STAGING: staging-51
   APP: 'browser-sdk'
   CURRENT_CI_IMAGE: 94
   BUILD_STABLE_REGISTRY: 'registry.ddbuild.io'

packages/rum-core/src/boot/rumPublicApi.spec.ts

@@ -23,6 +23,7 @@ const noopStartRum = (): ReturnType<StartRum> => ({
   getInternalContext: () => undefined,
   lifeCycle: {} as any,
   viewHistory: {} as any,
+  longTaskContexts: {} as any,
   session: {} as any,
   stopSession: () => undefined,
   startDurationVital: () => ({}) as DurationVitalReference,

packages/rum-core/src/boot/rumPublicApi.ts

@@ -52,6 +52,7 @@ import { createCustomVitalsState } from '../domain/vital/vitalCollection'
 import { callPluginsMethod } from '../domain/plugins'
 import type { Hooks } from '../domain/hooks'
 import type { SdkName } from '../domain/contexts/defaultContext'
+import type { LongTaskContexts } from '../domain/longTask/longTaskCollection'
 import { createPreStartStrategy } from './preStartRum'
 import type { StartRum, StartRumResult } from './startRum'
 
@@ -484,6 +485,7 @@ export interface ProfilerApi {
     configuration: RumConfiguration,
     sessionManager: RumSessionManager,
     viewHistory: ViewHistory,
+    longTaskContexts: LongTaskContexts,
     createEncoder: (streamId: DeflateEncoderStreamId) => Encoder
   ) => void
 }
@@ -576,6 +578,7 @@ export function makeRumPublicApi(
         configuration,
         startRumResult.session,
         startRumResult.viewHistory,
+        startRumResult.longTaskContexts,
         createEncoder
       )
 

packages/rum-core/src/boot/startRum.ts

@@ -43,8 +43,6 @@ import { startDisplayContext } from '../domain/contexts/displayContext'
 import type { CustomVitalsState } from '../domain/vital/vitalCollection'
 import { startVitalCollection } from '../domain/vital/vitalCollection'
 import { startCiVisibilityContext } from '../domain/contexts/ciVisibilityContext'
-import { startLongAnimationFrameCollection } from '../domain/longAnimationFrame/longAnimationFrameCollection'
-import { RumPerformanceEntryType, supportPerformanceTimingEvent } from '../browser/performanceObservable'
 import { startLongTaskCollection } from '../domain/longTask/longTaskCollection'
 import { startSyntheticsContext } from '../domain/contexts/syntheticsContext'
 import { startRumAssembly } from '../domain/assembly'
@@ -237,14 +235,8 @@ export function startRumEventCollection(
   const { stop: stopResourceCollection } = startResourceCollection(lifeCycle, configuration, pageStateHistory)
   cleanupTasks.push(stopResourceCollection)
 
-  if (configuration.trackLongTasks) {
-    if (supportPerformanceTimingEvent(RumPerformanceEntryType.LONG_ANIMATION_FRAME)) {
-      const { stop: stopLongAnimationFrameCollection } = startLongAnimationFrameCollection(lifeCycle, configuration)
-      cleanupTasks.push(stopLongAnimationFrameCollection)
-    } else {
-      startLongTaskCollection(lifeCycle, configuration)
-    }
-  }
+  const { stop: stopLongTaskCollection, longTaskContexts } = startLongTaskCollection(lifeCycle, configuration)
+  cleanupTasks.push(stopLongTaskCollection)
 
   const { addError } = startErrorCollection(lifeCycle, configuration, bufferedDataObservable)
 
@@ -280,6 +272,7 @@ export function startRumEventCollection(
     globalContext,
     userContext,
     accountContext,
+    longTaskContexts,
     stop: () => cleanupTasks.forEach((task) => task()),
   }
 }

packages/rum-core/src/domain/action/trackClickActions.ts

@@ -125,6 +125,10 @@ export function trackClickActions(
       const rageClick = click.clone()
       currentClickChain = createClickChain(click, (clicks) => {
         finalizeClicks(clicks, rageClick)
+        // Clear the reference to allow garbage collection. Without this, the finalize callback
+        // retains a closure reference to the old click chain, preventing it from being cleaned up
+        // and causing a memory leak as click chains accumulate over time.
+        currentClickChain = undefined
       })
     }
   }