Remove ff for graphql tracking (#3886)

Author: rgaignault

packages/core/src/tools/experimentalFeatures.ts

@@ -17,7 +17,6 @@ export enum ExperimentalFeature {
   TRACK_INTAKE_REQUESTS = 'track_intake_requests',
   WRITABLE_RESOURCE_GRAPHQL = 'writable_resource_graphql',
   USE_TREE_WALKER_FOR_ACTION_NAME = 'use_tree_walker_for_action_name',
-  GRAPHQL_TRACKING = 'graphql_tracking',
   FEATURE_OPERATION_VITAL = 'feature_operation_vital',
   SHORT_SESSION_INVESTIGATION = 'short_session_investigation',
 }

packages/rum-core/src/domain/resource/resourceCollection.spec.ts

@@ -1,6 +1,6 @@
 import type { Duration, RelativeTime, ServerDuration, TaskQueue, TimeStamp } from '@datadog/browser-core'
-import { createTaskQueue, ExperimentalFeature, noop, RequestType, ResourceType } from '@datadog/browser-core'
-import { mockExperimentalFeatures, registerCleanupTask } from '@datadog/browser-core/test'
+import { createTaskQueue, noop, RequestType, ResourceType } from '@datadog/browser-core'
+import { registerCleanupTask } from '@datadog/browser-core/test'
 import type { RumFetchResourceEventDomainContext, RumXhrResourceEventDomainContext } from '../../domainContext.types'
 import {
   collectAndValidateRawRumEvents,
@@ -152,9 +152,6 @@ describe('resourceCollection', () => {
   })
 
   describe('GraphQL metadata enrichment', () => {
-    beforeEach(() => {
-      mockExperimentalFeatures([ExperimentalFeature.GRAPHQL_TRACKING])
-    })
     interface TestCase {
       requestType: RequestType
       name: string
@@ -279,34 +276,6 @@ describe('resourceCollection', () => {
     })
   })
 
-  it('should not track GraphQL when feature flag is disabled', () => {
-    mockExperimentalFeatures([])
-    setupResourceCollection({
-      trackResources: true,
-      allowedGraphQlUrls: [{ match: 'https://api.example.com/graphql', trackPayload: true }],
-    })
-
-    const requestBody = JSON.stringify({
-      query: 'query GetUser { user { name } }',
-    })
-
-    notifyRequest({
-      request: {
-        type: RequestType.FETCH,
-        url: 'https://api.example.com/graphql',
-        method: 'POST' as const,
-        init: {
-          method: 'POST' as const,
-          body: requestBody,
-        },
-        input: 'https://api.example.com/graphql',
-      },
-    })
-
-    const resourceEvent = rawRumEvents[0].rawRumEvent as any
-    expect(resourceEvent.resource.graphql).toBeUndefined()
-  })
-
   describe('with trackEarlyRequests enabled', () => {
     it('creates a resource from a performance entry without a matching request', () => {
       setupResourceCollection({ trackResources: true, trackEarlyRequests: true })

packages/rum-core/src/domain/resource/resourceCollection.ts

@@ -7,8 +7,6 @@ import {
   toServerDuration,
   relativeToClocks,
   createTaskQueue,
-  isExperimentalFeatureEnabled,
-  ExperimentalFeature,
 } from '@datadog/browser-core'
 import type { RumConfiguration } from '../configuration'
 import type { RumPerformanceResourceTiming } from '../../browser/performanceObservable'
@@ -178,10 +176,6 @@ function computeGraphQlMetaData(
   request: RequestCompleteEvent,
   configuration: RumConfiguration
 ): GraphQlMetadata | undefined {
-  if (!isExperimentalFeatureEnabled(ExperimentalFeature.GRAPHQL_TRACKING)) {
-    return
-  }
-
   const graphQlConfig = findGraphQlConfiguration(request.url, configuration)
   if (!graphQlConfig) {
     return

test/e2e/scenario/rum/graphql.scenario.ts

@@ -4,7 +4,6 @@ import { createTest } from '../../lib/framework'
 function buildGraphQlConfig({ trackPayload = false }: { trackPayload?: boolean } = {}) {
   return {
     allowedGraphQlUrls: [{ match: (url: string) => url.includes('graphql'), trackPayload }],
-    enableExperimentalFeatures: ['graphql_tracking'],
   }
 }