🐛 add transition

Author: mormubis

packages/rum-core/src/domain/assembly.ts

@@ -12,7 +12,7 @@ import {
 } from '@datadog/browser-core'
 import type { RumEventDomainContext } from '../domainContext.types'
 import { RumEventType } from '../rawRumEvent.types'
-import type { RumEvent, RumTransitionEvent, RumViewEvent } from '../rumEvent.types'
+import type { RumEvent, RumViewEvent } from '../rumEvent.types'
 import type { LifeCycle } from './lifeCycle'
 import { LifeCycleEventType } from './lifeCycle'
 import type { RumConfiguration } from './configuration'
@@ -91,6 +91,11 @@ export function startRumAssembly(
       ...VIEW_MODIFIABLE_FIELD_PATHS,
       ...ROOT_MODIFIABLE_FIELD_PATHS,
     },
+    [RumEventType.TRANSITION]: {
+      ...USER_CUSTOMIZABLE_FIELD_PATHS,
+      ...VIEW_MODIFIABLE_FIELD_PATHS,
+      ...ROOT_MODIFIABLE_FIELD_PATHS,
+    },
   }
   const eventRateLimiters = {
     [RumEventType.ERROR]: createEventRateLimiter(
@@ -125,7 +130,7 @@ export function startRumAssembly(
 
       const serverRumEvent = combine(defaultRumEventAttributes, rawRumEvent, {
         ddtags: buildTags(configuration).join(','),
-      }) as Exclude<RumEvent, RumTransitionEvent> & Context
+      }) as RumEvent & Context
 
       if (shouldSend(serverRumEvent, configuration.beforeSend, domainContext, eventRateLimiters)) {
         if (isEmptyObject(serverRumEvent.context!)) {
@@ -170,7 +175,7 @@ export function startRumAssembly(
 }
 
 function shouldSend(
-  event: Exclude<RumEvent, RumTransitionEvent> & Context,
+  event: RumEvent & Context,
   beforeSend: RumConfiguration['beforeSend'],
   domainContext: RumEventDomainContext,
   eventRateLimiters: { [key in RumEventType]?: EventRateLimiter }

packages/rum-core/src/domain/event/eventCollection.ts

@@ -20,6 +20,8 @@ const allowedEventTypes = [
   RumEventType.LONG_TASK,
   RumEventType.RESOURCE,
   RumEventType.STREAM,
+  RumEventType.STREAM,
+  RumEventType.TRANSITION,
   RumEventType.VITAL,
 ] as const
 

packages/rum-core/src/rawRumEvent.types.ts

@@ -20,6 +20,7 @@ export const RumEventType = {
   RESOURCE: 'resource',
   VITAL: 'vital',
   STREAM: 'stream',
+  TRANSITION: 'transition',
 } as const
 
 export type RumEventType = (typeof RumEventType)[keyof typeof RumEventType]
@@ -378,6 +379,23 @@ export interface RawRumStreamEvent {
   }
 }
 
+export interface RawRumTransitionEvent {
+  date: TimeStamp
+  type: typeof RumEventType.TRANSITION
+  stream: {
+    id: string
+  }
+  transition: {
+    type: string
+    id?: string
+    timestamp?: number
+    buffer_starvation_duration?: number
+    media_start_delay?: number
+    error_code?: number
+    duration?: number
+  }
+}
+
 export type RawRumEvent =
   | RawRumErrorEvent
   | RawRumResourceEvent
@@ -387,3 +405,4 @@ export type RawRumEvent =
   | RawRumActionEvent
   | RawRumVitalEvent
   | RawRumStreamEvent
+  | RawRumTransitionEvent

packages/rum-core/test/fixtures.ts

@@ -143,6 +143,21 @@ export function createRawRumEvent(type: RumEventType, overrides?: Context): RawR
         },
         overrides
       )
+    case RumEventType.TRANSITION:
+      return combine(
+        {
+          type,
+          date: 0 as TimeStamp,
+          stream: {
+            id: generateUUID(),
+          },
+          transition: {
+            id: generateUUID(),
+            type: 'MEDIA_PLAYER_PLAY',
+          }
+        },
+        overrides
+      )
   }
 }