Skip to content

Commit e9beb7e

Browse files
Consisntency accross tests
1 parent 7ac026f commit e9beb7e

File tree

1 file changed

+14
-18
lines changed

1 file changed

+14
-18
lines changed

packages/core/src/domain/allowedTrackingOrigins.spec.ts

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
WARN_DOES_NOT_HAVE_ALLOWED_TRACKING_ORIGIN,
55
ERROR_NOT_ALLOWED_TRACKING_ORIGIN,
66
} from './allowedTrackingOrigins'
7-
import { STACK_WITH_INIT_IN_EXTENSION } from './extension/extensionUtils'
7+
import { STACK_WITH_INIT_IN_EXTENSION, STACK_WITH_INIT_IN_PAGE } from './extension/extensionUtils'
88

99
const DEFAULT_CONFIG = {
1010
applicationId: 'xxx',
@@ -22,11 +22,7 @@ describe('checkForAllowedTrackingOrigins', () => {
2222
})
2323

2424
it('should not warn if not in extension environment', () => {
25-
const result = isAllowedTrackingOrigins(
26-
DEFAULT_CONFIG,
27-
'Error: at https://example.com/script.js:1:1',
28-
'https://app.example.com'
29-
)
25+
const result = isAllowedTrackingOrigins(DEFAULT_CONFIG, STACK_WITH_INIT_IN_PAGE, 'https://app.example.com')
3026
expect(displayWarnSpy).not.toHaveBeenCalled()
3127
expect(displayErrorSpy).not.toHaveBeenCalled()
3228
expect(result).toBe(true)
@@ -39,7 +35,7 @@ describe('checkForAllowedTrackingOrigins', () => {
3935
...DEFAULT_CONFIG,
4036
allowedTrackingOrigins: ['https://app.example.com'],
4137
},
42-
'Error: at https://example.com/script.js:1:1',
38+
STACK_WITH_INIT_IN_PAGE,
4339
'https://app.example.com'
4440
)
4541
expect(displayWarnSpy).not.toHaveBeenCalled()
@@ -53,7 +49,7 @@ describe('checkForAllowedTrackingOrigins', () => {
5349
...DEFAULT_CONFIG,
5450
allowedTrackingOrigins: [/^https:\/\/.*\.example\.com$/],
5551
},
56-
'Error: at https://example.com/script.js:1:1',
52+
STACK_WITH_INIT_IN_PAGE,
5753
'https://app.example.com'
5854
)
5955
expect(displayWarnSpy).not.toHaveBeenCalled()
@@ -67,7 +63,7 @@ describe('checkForAllowedTrackingOrigins', () => {
6763
...DEFAULT_CONFIG,
6864
allowedTrackingOrigins: [(origin: string) => origin.includes('example.com')],
6965
},
70-
'Error: at https://example.com/script.js:1:1',
66+
STACK_WITH_INIT_IN_PAGE,
7167
'https://app.example.com'
7268
)
7369
expect(displayWarnSpy).not.toHaveBeenCalled()
@@ -85,7 +81,7 @@ describe('checkForAllowedTrackingOrigins', () => {
8581
(origin: string) => origin.startsWith('https://app.'),
8682
],
8783
},
88-
'Error: at https://example.com/script.js:1:1',
84+
STACK_WITH_INIT_IN_PAGE,
8985
'https://app.example.com'
9086
)
9187
expect(displayWarnSpy).not.toHaveBeenCalled()
@@ -101,7 +97,7 @@ describe('checkForAllowedTrackingOrigins', () => {
10197
...DEFAULT_CONFIG,
10298
allowedTrackingOrigins: ['https://different.com'],
10399
},
104-
'Error: at chrome-extension://abcdefghijklmno/content.js:10:15',
100+
STACK_WITH_INIT_IN_EXTENSION,
105101
'https://example.com'
106102
)
107103
expect(displayErrorSpy).toHaveBeenCalledWith(ERROR_NOT_ALLOWED_TRACKING_ORIGIN)
@@ -114,7 +110,7 @@ describe('checkForAllowedTrackingOrigins', () => {
114110
...DEFAULT_CONFIG,
115111
allowedTrackingOrigins: [/^https:\/\/specific-[a-z]+\.com$/],
116112
},
117-
'Error: at chrome-extension://abcdefghijklmno/content.js:10:15',
113+
STACK_WITH_INIT_IN_EXTENSION,
118114
'https://example.com'
119115
)
120116
expect(displayErrorSpy).toHaveBeenCalledWith(ERROR_NOT_ALLOWED_TRACKING_ORIGIN)
@@ -127,7 +123,7 @@ describe('checkForAllowedTrackingOrigins', () => {
127123
...DEFAULT_CONFIG,
128124
allowedTrackingOrigins: [(origin: string) => origin.includes('specific-id')],
129125
},
130-
'Error: at chrome-extension://abcdefghijklmno/content.js:10:15',
126+
STACK_WITH_INIT_IN_EXTENSION,
131127
'https://example.com'
132128
)
133129
expect(displayErrorSpy).toHaveBeenCalledWith(ERROR_NOT_ALLOWED_TRACKING_ORIGIN)
@@ -144,7 +140,7 @@ describe('checkForAllowedTrackingOrigins', () => {
144140
(origin: string) => origin.includes('specific-id'),
145141
],
146142
},
147-
'Error: at chrome-extension://abcdefghijklmno/content.js:10:15',
143+
STACK_WITH_INIT_IN_EXTENSION,
148144
'https://example.com'
149145
)
150146
expect(displayErrorSpy).toHaveBeenCalledWith(ERROR_NOT_ALLOWED_TRACKING_ORIGIN)
@@ -157,7 +153,7 @@ describe('checkForAllowedTrackingOrigins', () => {
157153
...DEFAULT_CONFIG,
158154
allowedTrackingOrigins: ['https://example.com'],
159155
},
160-
'Error: at chrome-extension://abcdefghijklmno/content.js:10:15',
156+
STACK_WITH_INIT_IN_EXTENSION,
161157
'https://example.com.extra.com'
162158
)
163159
expect(displayErrorSpy).toHaveBeenCalledWith(ERROR_NOT_ALLOWED_TRACKING_ORIGIN)
@@ -170,7 +166,7 @@ describe('checkForAllowedTrackingOrigins', () => {
170166
...DEFAULT_CONFIG,
171167
allowedTrackingOrigins: [/^chrome-extension:\/\//],
172168
},
173-
'Error: at chrome-extension://abcdefghijklmno/content.js:10:15',
169+
STACK_WITH_INIT_IN_EXTENSION,
174170
'chrome-extension://abcdefghijklmno'
175171
)
176172
expect(displayErrorSpy).not.toHaveBeenCalled()
@@ -198,7 +194,7 @@ describe('checkForAllowedTrackingOrigins', () => {
198194
...DEFAULT_CONFIG,
199195
allowedTrackingOrigins: [],
200196
},
201-
'Error: at chrome-extension://abcdefghijklmno/content.js:10:15',
197+
STACK_WITH_INIT_IN_EXTENSION,
202198
'https://example.com'
203199
)
204200
expect(displayErrorSpy).toHaveBeenCalledWith(ERROR_NOT_ALLOWED_TRACKING_ORIGIN)
@@ -211,7 +207,7 @@ describe('checkForAllowedTrackingOrigins', () => {
211207
...DEFAULT_CONFIG,
212208
allowedTrackingOrigins: undefined,
213209
},
214-
'Error: at https://example.com/script.js:10:15',
210+
STACK_WITH_INIT_IN_PAGE,
215211
'https://example.com'
216212
)
217213
expect(displayWarnSpy).not.toHaveBeenCalled()

0 commit comments

Comments
 (0)