👷 add consistent-type-specifier-style: 'prefer-top-level' eslint rule (#3780)

* add `disallow-inline-type-import` rule

* update existing occurrences

* 👌replace local rule by the one from eslint-plugin-import

Author: bcaudan

eslint.config.mjs

@@ -386,6 +386,14 @@ export default tseslint.config(
     },
   },
 
+  {
+    files: ['packages/*/src/**/*.ts'],
+    ignores: [SPEC_FILES],
+    rules: {
+      'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],
+    },
+  },
+
   {
     files: ['packages/{rum,logs,flagging,rum-slim}/src/entries/*.ts'],
     rules: {

packages/logs/src/boot/preStartLogs.ts

@@ -15,12 +15,8 @@ import {
   buildGlobalContextManager,
   buildUserContextManager,
 } from '@datadog/browser-core'
-import {
-  serializeLogsConfiguration,
-  validateAndBuildLogsConfiguration,
-  type LogsConfiguration,
-  type LogsInitConfiguration,
-} from '../domain/configuration'
+import type { LogsConfiguration, LogsInitConfiguration } from '../domain/configuration'
+import { serializeLogsConfiguration, validateAndBuildLogsConfiguration } from '../domain/configuration'
 import type { CommonContext } from '../rawLogsEvent.types'
 import type { Strategy } from './logsPublicApi'
 import type { StartLogsResult } from './startLogs'

packages/rum-core/src/boot/preStartRum.ts

@@ -18,10 +18,9 @@ import {
   buildUserContextManager,
   monitorError,
 } from '@datadog/browser-core'
+import type { RumConfiguration, RumInitConfiguration } from '../domain/configuration'
 import {
   validateAndBuildRumConfiguration,
-  type RumConfiguration,
-  type RumInitConfiguration,
   fetchAndApplyRemoteConfiguration,
   serializeRumConfiguration,
 } from '../domain/configuration'

packages/rum-core/src/browser/performanceUtils.ts

@@ -1,10 +1,7 @@
 import type { RelativeTime, TimeStamp } from '@datadog/browser-core'
 import { getRelativeTime, isNumber } from '@datadog/browser-core'
-import {
-  RumPerformanceEntryType,
-  supportPerformanceTimingEvent,
-  type RumPerformanceNavigationTiming,
-} from './performanceObservable'
+import type { RumPerformanceNavigationTiming } from './performanceObservable'
+import { RumPerformanceEntryType, supportPerformanceTimingEvent } from './performanceObservable'
 
 export function getNavigationEntry(): RumPerformanceNavigationTiming {
   if (supportPerformanceTimingEvent(RumPerformanceEntryType.NAVIGATION)) {

packages/rum-core/src/domain/contexts/pageStateHistory.ts

@@ -12,7 +12,8 @@ import {
 } from '@datadog/browser-core'
 import type { RumConfiguration } from '../configuration'
 import { supportPerformanceTimingEvent, RumPerformanceEntryType } from '../../browser/performanceObservable'
-import { RumEventType, type PageStateServerEntry } from '../../rawRumEvent.types'
+import type { PageStateServerEntry } from '../../rawRumEvent.types'
+import { RumEventType } from '../../rawRumEvent.types'
 import type { DefaultRumEventAttributes, Hooks } from '../hooks'
 
 // Arbitrary value to cap number of element for memory consumption in the browser

packages/rum-core/src/domain/resource/resourceCollection.ts

@@ -9,16 +9,13 @@ import {
   createTaskQueue,
 } from '@datadog/browser-core'
 import type { RumConfiguration } from '../configuration'
-import {
-  RumPerformanceEntryType,
-  createPerformanceObservable,
-  type RumPerformanceResourceTiming,
-} from '../../browser/performanceObservable'
+import type { RumPerformanceResourceTiming } from '../../browser/performanceObservable'
+import { RumPerformanceEntryType, createPerformanceObservable } from '../../browser/performanceObservable'
 import type { RumXhrResourceEventDomainContext, RumFetchResourceEventDomainContext } from '../../domainContext.types'
 import type { RawRumResourceEvent } from '../../rawRumEvent.types'
 import { RumEventType } from '../../rawRumEvent.types'
-import { LifeCycleEventType } from '../lifeCycle'
 import type { RawRumEventCollectedData, LifeCycle } from '../lifeCycle'
+import { LifeCycleEventType } from '../lifeCycle'
 import type { RequestCompleteEvent } from '../requestCollection'
 import type { PageStateHistory } from '../contexts/pageStateHistory'
 import { PageState } from '../contexts/pageStateHistory'

packages/rum/src/domain/profiling/transport/transport.ts

@@ -1,4 +1,5 @@
-import { addTelemetryDebug, buildTags, currentDrift, type Payload } from '@datadog/browser-core'
+import type { Payload } from '@datadog/browser-core'
+import { addTelemetryDebug, buildTags, currentDrift } from '@datadog/browser-core'
 import type { RumConfiguration } from '@datadog/browser-rum-core'
 import type { RumProfilerTrace } from '../types'
 

packages/rum/src/domain/record/trackers/trackFocus.ts

@@ -1,6 +1,7 @@
 import { DOM_EVENT, addEventListeners, timeStampNow } from '@datadog/browser-core'
 import type { RumConfiguration } from '@datadog/browser-rum-core'
-import { RecordType, type FocusRecord } from '../../../types'
+import type { FocusRecord } from '../../../types'
+import { RecordType } from '../../../types'
 import type { Tracker } from './tracker.types'
 
 export type FocusCallback = (data: FocusRecord) => void

packages/rum/src/domain/segmentCollection/segment.ts

@@ -2,7 +2,8 @@ import type { Encoder, EncoderResult, Uint8ArrayBuffer } from '@datadog/browser-
 import type { BrowserRecord, BrowserSegmentMetadata, CreationReason, SegmentContext } from '../../types'
 import { RecordType } from '../../types'
 import * as replayStats from '../replayStats'
-import { aggregateSerializationStats, createSerializationStats, type SerializationStats } from '../record'
+import type { SerializationStats } from '../record'
+import { aggregateSerializationStats, createSerializationStats } from '../record'
 
 export type FlushReason = Exclude<CreationReason, 'init'> | 'stop'
 export type FlushCallback = (