Skip to content

Commit fdd98c7

Browse files
committed
πŸ› fixes due to new event type
1 parent e4c3277 commit fdd98c7

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

β€Ždeveloper-extension/src/panel/components/tabs/eventsTab/eventRow.tsxβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ const RUM_EVENT_TYPE_COLOR = {
3434
view: 'blue',
3535
resource: 'cyan',
3636
telemetry: 'teal',
37+
transition: 'black',
3738
vital: 'orange',
3839
transition: 'green',
3940
}

β€Žpackages/rum-core/src/domain/assembly.tsβ€Ž

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,6 @@ export function startRumAssembly(
9292
...VIEW_MODIFIABLE_FIELD_PATHS,
9393
...ROOT_MODIFIABLE_FIELD_PATHS,
9494
},
95-
[RumEventType.TRANSITION]: {
96-
...USER_CUSTOMIZABLE_FIELD_PATHS,
97-
...VIEW_MODIFIABLE_FIELD_PATHS,
98-
...ROOT_MODIFIABLE_FIELD_PATHS,
99-
},
10095
}
10196
const eventRateLimiters = {
10297
[RumEventType.ERROR]: createEventRateLimiter(

β€Žpackages/rum-core/src/domain/trackEventCounts.tsβ€Ž

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,13 @@ export function trackEventCounts({
3030
}
3131

3232
const subscription = lifeCycle.subscribe(LifeCycleEventType.RUM_EVENT_COLLECTED, (event): void => {
33-
if (event.type === 'view' || event.type === 'vital' || !isChildEvent(event) || ['stream'].includes(event.type)) {
33+
if (
34+
event.type === 'view' ||
35+
event.type === 'vital' ||
36+
event.type === 'transition' ||
37+
!isChildEvent(event) ||
38+
['stream'].includes(event.type)
39+
) {
3440
return
3541
}
3642
switch (event.type) {

β€Žpackages/rum-core/src/rawRumEvent.types.tsβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ export const RumEventType = {
2929
RESOURCE: 'resource',
3030
VITAL: 'vital',
3131
STREAM: 'stream',
32-
TRANSITION: 'transition',
3332
} as const
3433

3534
export type RumEventType = (typeof RumEventType)[keyof typeof RumEventType]

0 commit comments

Comments
Β (0)