[RUMF-848] Expose internal types and constants to be used in Datadog app#727
Merged
BenoitZugmeyer merged 12 commits intomasterfrom Feb 11, 2021
Merged
[RUMF-848] Expose internal types and constants to be used in Datadog app#727BenoitZugmeyer merged 12 commits intomasterfrom
BenoitZugmeyer merged 12 commits intomasterfrom
Conversation
BenoitZugmeyer
changed the title
BenoitZugmeyer
changed the title
BenoitZugmeyer
force-pushed
the
benoit/rum-recorder-internal
branch
from
1cecbc3 to
d6b10f9
Compare
BenoitZugmeyer
force-pushed
the
benoit/rum-recorder-internal
branch
from
d6b10f9 to
a162dd3
Compare
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
=======================================
Coverage 80.77% 80.77%
=======================================
Files 72 72
Lines 3745 3745
Branches 877 877
=======================================
Hits 3025 3025
Misses 720 720
Continue to review full report at Codecov.
|
BenoitZugmeyer
force-pushed
the
benoit/rum-recorder-internal
branch
from
f55db89 to
051b5e9
Compare
BenoitZugmeyer
force-pushed
the
benoit/rum-recorder-internal
branch
from
051b5e9 to
86a13a1
Compare
BenoitZugmeyer
force-pushed
the
benoit/rum-recorder-internal
branch
from
f45be84 to
62dd2d1
Compare
BenoitZugmeyer
force-pushed
the
benoit/rum-recorder-internal
branch
from
62dd2d1 to
a9ac8f1
Compare
* Add some documentation * Enforce it on all code that should be added to the packages * Reword a few functions * Make sure only files with side effects can import files with side effects * Allow `new WeakMap()` and `Object.keys()` calls
* Replace unnecessary RegExp constructor with a regexp value * Disable the rule on 'mutationBuffer', as I want to remove this in the future. * Remove unused `freezePage` function
BenoitZugmeyer
force-pushed
the
benoit/rum-recorder-internal
branch
from
8c252f6 to
01f2da1
Compare
BenoitZugmeyer
commented
Feb 11, 2021
Comment on lines
+42
to
44
| // TODO: remove this global MutationBuffer instance | ||
| // eslint-disable-next-line local-rules/enforce-declarative-modules | ||
| export const mutationBuffer = new MutationBuffer() |
Member
Author
There was a problem hiding this comment.
I want to remove this in a separate PR, because it involves a bit of rearchitecturing of RRWeb codebase
bcaudan
reviewed
Feb 11, 2021
* rename the rule to `disallow-side-effects` * adjust doc comments * remove unneeded eslint-disable comment * improve rule description and report message
BenoitZugmeyer
force-pushed
the
benoit/rum-recorder-internal
branch
from
0660bdc to
44d2b84
Compare
webNeat
pushed a commit
that referenced
this pull request
Feb 15, 2021
…app (#727) * [RUMF-848] expose internal types and constants to be used in Datadog app * [RUMF-848] add a ESLint rule to enforce declarative modules * [RUMF-848] allow using 'import type' from any file in restricted files * 🚚 [RUMF-848] move types and constants to respect the new ESLint rule * [RUMF-848] adjust ESLint rule * Add some documentation * Enforce it on all code that should be added to the packages * Reword a few functions * Make sure only files with side effects can import files with side effects * Allow `new WeakMap()` and `Object.keys()` calls * 🚚 [RUMF-848] remove tracekit IIFE by spliting it into different modules * [RUMF-848] replace tracekit report.* with proper functions * [RUMF-848] replace tracekit computeStackTrace.* with proper functions * [RUMF-848] move LogsUserConfiguration in logs.ts * [RUMF-848] fix last RRWeb issues * Replace unnecessary RegExp constructor with a regexp value * Disable the rule on 'mutationBuffer', as I want to remove this in the future. * Remove unused `freezePage` function * 👌 [RUMF-848] review adjustments * rename the rule to `disallow-side-effects` * adjust doc comments * remove unneeded eslint-disable comment * improve rule description and report message
BenoitZugmeyer
added a commit
that referenced
this pull request
Apr 22, 2021
This logic was introduced to allow RRWeb users to "pause" the recording by using the public method `freezePage`. This method has been removed in PR #727, and it appears that the `freeze` logic is now unneeded: since the "fullsnapshot" logic is synchronous, no DOM mutation can happen or be processed while the document snapshot is taken.
BenoitZugmeyer
added a commit
that referenced
this pull request
Apr 23, 2021
This logic was introduced to allow RRWeb users to "pause" the recording by using the public method `freezePage`. This method has been removed in PR #727, and it appears that the `freeze` logic is now unneeded: since the "fullsnapshot" logic is synchronous, no DOM mutation can happen or be processed while the document snapshot is taken.
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 44d2b84 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 82.64% 80.77% -1.87%
==========================================
Files 72 72
Lines 3745 3745
Branches 877 877
==========================================
- Hits 3095 3025 -70
- Misses 650 720 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Expose internal types to be used in Datadog app
Changes
Testing
I have gone over the contributing documentation.