Merged
Conversation
This logic was introduced to allow RRWeb users to "pause" the recording by using the public method `freezePage`. This method has been removed in PR #727, and it appears that the `freeze` logic is now unneeded: since the "fullsnapshot" logic is synchronous, no DOM mutation can happen or be processed while the document snapshot is taken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This logic was introduced to allow RRWeb users to "pause" the recording
by using the public method
freezePage. This method has been removed inPR #727, and it appears that the
freezelogic is now unneeded: sincethe "fullsnapshot" logic is synchronous, no DOM mutation can happen or
be processed while the document snapshot is taken.
Changes
Remove mutation 'freeze' logic. Because mutations still need to be flushed before a "fullsnapshot" is taken, the
MutationControllerhave been kept, andflush/onFlushmethods have been introduced.Testing
CI, manual
I have gone over the contributing documentation.