Commit 68a1c74
Fix git worktree detection for
Previously, `dda env dev start` failed when run from git worktrees with
arbitrary directory names because it assumed repository directories were
named exactly as the repository (e.g., "datadog-agent").
This commit adds git-aware repository resolution that:
- Detects git repositories using remote URL, working for both regular
repos and worktrees regardless of directory name
- Maintains full backward compatibility with non-git directory lookup
- Handles edge cases: missing git, no remote, nested structures
Implementation:
- Added `_resolve_repository_path()` with multi-strategy resolution
- Added `_is_matching_repository()` using git remote URL detection
- Updated repository mounting to use new git-aware resolver
- Added comprehensive tests for worktree scenarios
Fixes issue where worktrees like `.worktrees/my_feature` would fail
with "Local repository not found: datadog-agent"
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>dda env dev start
1 parent 911d691 commit 68a1c74
File tree
2 files changed
+109
-7
lines changed- src/dda/env/dev/types
- tests/env/dev/types
2 files changed
+109
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | 190 | | |
194 | 191 | | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
| 192 | + | |
199 | 193 | | |
200 | 194 | | |
201 | 195 | | |
| |||
450 | 444 | | |
451 | 445 | | |
452 | 446 | | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
453 | 522 | | |
454 | 523 | | |
455 | 524 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1415 | 1415 | | |
1416 | 1416 | | |
1417 | 1417 | | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
| 1428 | + | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
| 1434 | + | |
| 1435 | + | |
| 1436 | + | |
| 1437 | + | |
| 1438 | + | |
| 1439 | + | |
| 1440 | + | |
| 1441 | + | |
| 1442 | + | |
| 1443 | + | |
| 1444 | + | |
| 1445 | + | |
| 1446 | + | |
| 1447 | + | |
| 1448 | + | |
| 1449 | + | |
| 1450 | + | |
1418 | 1451 | | |
1419 | 1452 | | |
1420 | 1453 | | |
| |||
0 commit comments