Skip to content

Commit cd829e5

Browse files
committed
Fix developer environment
1 parent e2d6269 commit cd829e5

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
88

99
## Unreleased
1010

11+
***Fixed:***
12+
13+
- Fix the `env dev start` command when using the `linux-container` developer environment type
14+
- Fix the `check` parameter of the `app.subprocess.capture` method
15+
1116
## 0.12.0 - 2025-05-01
1217

1318
***Changed:***

src/dda/env/dev/types/linux_container.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,10 @@ def construct_command(self, command: list[str], *, cwd: str | None = None) -> li
248248
ssh_command.append(self.shell.format_command(command, cwd=cwd))
249249
return ssh_command
250250

251-
def check_readiness(self) -> bool:
251+
def check_readiness(self) -> None:
252252
output = self.docker.capture(["logs", self.container_name])
253-
return "Server listening on :: port 22" in output
253+
if "Server listening on :: port 22" not in output:
254+
raise RuntimeError
254255

255256
def ssh_base_command(self) -> list[str]:
256257
from dda.utils.ssh import ssh_base_command

src/dda/utils/process.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ def capture(
181181

182182
kwargs["stdout"] = subprocess.PIPE
183183
kwargs["stderr"] = subprocess.STDOUT if cross_streams else subprocess.PIPE
184+
kwargs["check"] = check
184185
kwargs["encoding"] = encoding
185186
if cwd is not None:
186187
kwargs["cwd"] = str(cwd)

0 commit comments

Comments
 (0)