Fix the env dev shell command

Author: ofek

CHANGELOG.md

@@ -8,6 +8,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## Unreleased
 
+***Fixed:***
+
+- Fix the `env dev shell` command when using the `linux-container` developer environment type
+
 ## 0.12.1 - 2025-05-02
 
 ***Fixed:***

src/dda/env/dev/types/linux_container.py

@@ -204,7 +204,8 @@ def launch_shell(self, *, repo: str | None = None) -> NoReturn:
         self.ensure_ssh_config()
         ssh_command = self.ssh_base_command()
         ssh_command.append(self.shell.get_login_command(cwd=self.repo_path(repo)))
-        self.app.subprocess.exit_with(ssh_command)
+        process = self.app.subprocess.attach(ssh_command, check=False)
+        self.app.abort(code=process.returncode)
 
     def code(self, *, repo: str | None = None) -> None:
         self.ensure_ssh_config()

tests/env/dev/types/test_linux_container.py

@@ -609,15 +609,18 @@ def test_default(self, dda, helpers, mocker):
 
 
 class TestShell:
-    def test_default(self, dda, mocker):
-        mocker.patch(
+    def test_default(self, dda, helpers, mocker):
+        with helpers.hybrid_patch(
             "subprocess.run",
-            return_value=CompletedProcess([], returncode=0, stdout=json.dumps([{"State": {"Status": "running"}}])),
-        )
-        write_server_config = mocker.patch("dda.utils.ssh.write_server_config")
-        exit_with = mocker.patch("dda.utils.process.SubprocessRunner.exit_with")
+            return_values={
+                # Stop command checks the status
+                1: CompletedProcess([], returncode=0, stdout=json.dumps([{"State": {"Status": "running"}}])),
+                # Capture ssh command
+            },
+        ) as calls:
+            write_server_config = mocker.patch("dda.utils.ssh.write_server_config")
 
-        result = dda("env", "dev", "shell")
+            result = dda("env", "dev", "shell")
 
         assert result.exit_code == 0, result.output
         assert not result.output
@@ -630,17 +633,24 @@ def test_default(self, dda, mocker):
                 "UserKnownHostsFile": "/dev/null",
             },
         )
-        exit_with.assert_called_once_with([
-            "ssh",
-            "-A",
-            "-q",
-            "-t",
-            "-p",
-            "59730",
-            "root@localhost",
-            "--",
-            "cd /root/repos/datadog-agent && zsh -l -i",
-        ])
+        assert calls == [
+            (
+                (
+                    [
+                        helpers.locate("ssh"),
+                        "-A",
+                        "-q",
+                        "-t",
+                        "-p",
+                        "59730",
+                        "root@localhost",
+                        "--",
+                        "cd /root/repos/datadog-agent && zsh -l -i",
+                    ],
+                ),
+                {},
+            ),
+        ]
 
 
 class TestRun: