Commit 00dd24f
authored
Bump
### What does this PR do?
This upgrade includes a Windows compatibility fix for batch file line endings (bazel-contrib/bazel-lib#1222), which resolves a cmd parsing bug where GOTO/CALL to labels fails when batch files use non CRLF-only line endings and a label crosses a 512-byte boundary:
```diff
> bazel test //deps/openssl3:module_consistency_test
[...]
==================== Test output for //deps/openssl3:module_consistency_test:
-The system cannot find the batch label specified - compare_files
+compare_files
+FAIL: files "C:\[...]\bazel-out\[...]\deps\openssl3\openssl3.MODULE.bazel.new" and "C:\[workspace]\deps\openssl3\openssl3.MODULE.bazel" differ.
+
+
+@@//deps/openssl3:openssl3.MODULE.bazel is out of date. To update this file, run:
+
+ bazel run //deps/openssl3:module_consistency
+To see differences run:
+
+ diff "C:\[...]\bazel-out\[...]\deps\openssl3\openssl3.MODULE.bazel.new" "C:\[workspace]\deps\openssl3\openssl3.MODULE.bazel"
+
================================================================================
```
Because this now surfaces we'd been generating `*.MODULE.bazel` with OS-specific newlines, the present change fixes it by always issuing UNIX-style newlines:
```
> bazel test //deps/openssl3:module_consistency_test
[...]
//deps/openssl3:module_consistency_test PASSED in 0.4s
```
### Motivation
Keep up to date and better support colleagues working on Windows.
### Describe how you validated your changes
Locally for the time being because we still have very limited test coverage due to #44455 being disputed.
### Additional Notes
`bazel_lib` 3.1.0/3.1.1 comes with further improvements, like:
- bazel-contrib/bazel-lib#1217
- bazel-contrib/bazel-lib#1220
- bazel-contrib/bazel-lib#1232
Co-authored-by: regis.desgroppes <[email protected]>bazel_lib from 3.0.1 to 3.1.1 (#45220)1 parent 8b86f35 commit 00dd24f
File tree
3 files changed
+4
-4
lines changed- bazel/tools
3 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
0 commit comments