Skip to content

Commit 10b9350

Browse files
test: ad kube endpointslices provider tests
1 parent 70e7b13 commit 10b9350

File tree

2 files changed

+771
-7
lines changed

2 files changed

+771
-7
lines changed

comp/core/autodiscovery/providers/kube_endpointslices.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,11 @@ func (k *kubeEndpointSlicesConfigProvider) IsUpToDate(context.Context) (bool, er
150150
return k.upToDate, nil
151151
}
152152

153+
// GetConfigErrors returns a map of configuration errors for each Kubernetes service
154+
func (k *kubeEndpointSlicesConfigProvider) GetConfigErrors() map[string]types.ErrorMsgSet {
155+
return k.configErrors
156+
}
157+
153158
func (k *kubeEndpointSlicesConfigProvider) invalidateOnServiceAdd(obj interface{}) {
154159
svc, ok := obj.(*v1.Service)
155160
if !ok {
@@ -192,7 +197,6 @@ func (k *kubeEndpointSlicesConfigProvider) invalidateOnServiceUpdate(old, obj in
192197
svc, ok := obj.(*v1.Service)
193198
if !ok {
194199
log.Errorf("Expected a *v1.Service type, got: %T", obj)
195-
k.setUpToDate(false)
196200
return
197201
}
198202
oldSvc, ok := old.(*v1.Service)
@@ -305,7 +309,6 @@ func (k *kubeEndpointSlicesConfigProvider) parseServiceAnnotationsForEndpointSli
305309

306310
ignoreAdForHybridScenariosTags := ignoreADTagsFromAnnotations(svc.GetAnnotations(), kubeEndpointSliceAnnotationPrefix)
307311
for i := range endptConf {
308-
// TODO: Kept same source for now, but we should consider using a different source.
309312
endptConf[i].Source = "kube_endpoints:" + apiserver.EntityForEndpoints(svc.Namespace, svc.Name, "")
310313
if pkgconfigsetup.Datadog().GetBool("cluster_checks.support_hybrid_ignore_ad_tags") {
311314
endptConf[i].IgnoreAutodiscoveryTags = endptConf[i].IgnoreAutodiscoveryTags || ignoreAdForHybridScenariosTags
@@ -394,8 +397,3 @@ func (k *kubeEndpointSlicesConfigProvider) cleanErrorsOfDeletedServices(setCurre
394397
}
395398
}
396399
}
397-
398-
// GetConfigErrors returns a map of configuration errors for each Kubernetes service
399-
func (k *kubeEndpointSlicesConfigProvider) GetConfigErrors() map[string]types.ErrorMsgSet {
400-
return k.configErrors
401-
}

0 commit comments

Comments
 (0)