Skip to content

Commit 687d020

Browse files
chouetzofek
andauthored
fix(sqg): Revert threshold update to fully manual (#46102)
### What does this PR do? Put back the `manual_gate_threshold_update` as fully manual ### Motivation The `on_dev_branches_with_artifact_change` has no `when` clause. On #45947 I wanted to align the rules for both jobs and missed there was no such clause. As a consequence the manual_trigger is no more manual but automatic and triggers creation of useless PR. Setting back the rule as a strict exclusion will solve the issue: - the `on_dev_branches` has `when: never` clauses for all its rules - the default is thus the final `when: manual` ### Describe how you validated your changes ### Additional Notes Co-authored-by: ofek.lev <ofek.lev@datadoghq.com>
1 parent 86efb13 commit 687d020

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

.gitlab-ci.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,14 @@ workflow:
510510
<<: *artifacts_build_impacting_paths
511511
compare_to: $COMPARE_TO_BRANCH
512512

513+
.on_dev_branches_with_artifact_changes_manual:
514+
- !reference [.on_dev_branches]
515+
- changes:
516+
<<: *artifacts_build_impacting_paths
517+
compare_to: $COMPARE_TO_BRANCH
518+
when: manual
519+
allow_failure: true
520+
513521
.on_main_or_release_branch_or_deploy_always:
514522
- <<: *if_deploy
515523
when: always

.gitlab/test/functional_test/static_quality_gate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ manual_gate_threshold_update:
7676
rules:
7777
- !reference [.except_coverage_pipeline] # Coverage pipeline creates a special artifact that will not pass the quality gate
7878
- !reference [.on_main_manual]
79-
- !reference [.on_dev_branches_with_artifact_changes]
79+
- !reference [.on_dev_branches_with_artifact_changes_manual]
8080
- when: manual
8181
allow_failure: true
8282
image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$CI_IMAGE_DOCKER_X64_SUFFIX:$CI_IMAGE_DOCKER_X64

0 commit comments

Comments
 (0)