Skip to content

Commit 6ddd77a

Browse files
committed
Use DTF 5.0.2
1 parent 7799a2f commit 6ddd77a

File tree

7 files changed

+6
-10
lines changed

7 files changed

+6
-10
lines changed

tools/windows/DatadogAgentInstaller/AgentCustomActions/AgentCustomActions.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,7 @@
6262
</PropertyGroup>
6363
<ItemGroup>
6464
<!-- WiX 5 migration: Replaced assembly reference with NuGet package -->
65-
<!-- Note: Using 4.0.5 because WixSharp's MakeSfxCA expects DTF assembly version 4.0.0.0 -->
66-
<PackageReference Include="WixToolset.Dtf.WindowsInstaller" Version="4.0.5" />
65+
<PackageReference Include="WixToolset.Dtf.WindowsInstaller" Version="5.0.2" />
6766
</ItemGroup>
6867
<ItemGroup>
6968
<Reference Include="System" />

tools/windows/DatadogAgentInstaller/CustomActions.Tests/CustomActions.Tests.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@
5656
</PropertyGroup>
5757
<ItemGroup>
5858
<!-- WiX 5 migration: Replaced assembly reference with NuGet package -->
59-
<!-- Note: Using 4.0.5 because WixSharp's MakeSfxCA expects DTF assembly version 4.0.0.0 -->
60-
<PackageReference Include="WixToolset.Dtf.WindowsInstaller" Version="4.0.5" />
59+
<PackageReference Include="WixToolset.Dtf.WindowsInstaller" Version="5.0.2" />
6160
</ItemGroup>
6261
<ItemGroup>
6362
<Reference Include="System" />

tools/windows/DatadogAgentInstaller/CustomActions/CustomActions.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@
125125
</ItemGroup>
126126
<ItemGroup>
127127
<!-- WiX 5 migration: Replaced assembly reference with NuGet package -->
128-
<!-- Note: Using 4.0.5 because WixSharp's MakeSfxCA expects DTF assembly version 4.0.0.0 -->
129-
<PackageReference Include="WixToolset.Dtf.WindowsInstaller" Version="4.0.5" />
128+
<PackageReference Include="WixToolset.Dtf.WindowsInstaller" Version="5.0.2" />
130129
</ItemGroup>
131130
<ItemGroup>
132131
<Reference Include="System" />

tools/windows/DatadogAgentInstaller/InstallerCustomActions/InstallerCustomActions.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,7 @@
6262
</PropertyGroup>
6363
<ItemGroup>
6464
<!-- WiX 5 migration: Replaced assembly reference with NuGet package -->
65-
<!-- Note: Using 4.0.5 because WixSharp's MakeSfxCA expects DTF assembly version 4.0.0.0 -->
66-
<PackageReference Include="WixToolset.Dtf.WindowsInstaller" Version="4.0.5" />
65+
<PackageReference Include="WixToolset.Dtf.WindowsInstaller" Version="5.0.2" />
6766
</ItemGroup>
6867
<ItemGroup>
6968
<Reference Include="System" />

tools/windows/DatadogAgentInstaller/WixSetup/Datadog Agent/AgentInstaller.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ public Project Configure()
216216
// Always generate a new GUID otherwise WixSharp will generate one based on
217217
// the version
218218
project.ProductId = Guid.NewGuid();
219+
project.AlwaysScheduleInitRuntime = false;
219220
project
220221
.SetCustomActions(_agentCustomActions)
221222
.SetProjectInfo(

tools/windows/DatadogAgentInstaller/WixSetup/Datadog Installer/DatadogInstaller.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ public Project Configure()
9090
// Always generate a new GUID otherwise WixSharp will generate one based on
9191
// the version
9292
project.ProductId = Guid.NewGuid();
93+
project.AlwaysScheduleInitRuntime = false;
9394
project
9495
.SetCustomActions(_installerCustomActions)
9596
.SetProjectInfo(

tools/windows/DatadogAgentInstaller/WixSetup/MutuallyExclusiveProduct.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ public void Process(ProcessingContext context)
5151
var upgradeElement = new XElement("Upgrade");
5252
upgradeElement.SetAttributeValue("Id", UpgradeCode);
5353

54-
// Note: UpgradeVersion does NOT have an Id attribute in WiX 5
55-
// Detect all versions of the conflicting product.
5654
// Omitting Maximum means "no upper bound" - detects all versions >= Minimum.
5755
var upgradeVersionElement = new XElement("UpgradeVersion",
5856
new XAttribute("Minimum", "0.0.0"),

0 commit comments

Comments
 (0)