Commit 709289a
authored
Inline
### What does this PR do?
Remove the dedicated `binary_build` stage jobs (`build_dd-procmgrd-{x64,arm64}`) that built the `dd-procmgrd` Rust binary, archived it as a GitLab artifact, and passed it to the packaging stage via `--dd-procmgrd-bin=...` (`DD_PROCMGRD_BIN=...` from omnibus perspective).
Instead, the build is triggered directly from within the omnibus software definition via `bazel run //pkg/procmgr/rust:install` when `--with-dd-procmgrd` is passed (`WITH_DD_PROCMGRD=true` from omnibus perspective).
### Motivation
Bazel in CI operates with two caching layers: a minimal GitLab cache for bootstrapping pre-fetched external repositories (read-only in PR branches, read/write on `main`), and an always-on remote cache, so any target built with identical inputs is fetched rather than rebuilt.
An orthogonal GitLab artifact carrying the same binary is therefore redundant: it imposes a fixed pack/upload/download/unpack overhead on every run, including those that would otherwise be remote cache hits, and introduces an inter-stage dependency that serializes the pipeline.
Running the build at the point of consumption lets Bazel's DAG do the right thing: unchanged sources yield a near-instant cache hit; if sources differ, the cost is paid once and cached for all subsequent runs.
### Describe how you validated your changes
CI.
Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>dd-procmgrd Bazel build into omnibus packaging (#46834)1 parent b49aab4 commit 709289a
File tree
6 files changed
+15
-49
lines changed- .github
- .gitlab
- build
- binary_build
- package_build
- omnibus/config/software
- tasks
6 files changed
+15
-49
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
132 | 131 | | |
133 | 132 | | |
134 | 133 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | 40 | | |
42 | 41 | | |
43 | 42 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
| 19 | + | |
25 | 20 | | |
26 | 21 | | |
27 | 22 | | |
28 | 23 | | |
29 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
30 | 27 | | |
31 | 28 | | |
32 | 29 | | |
| |||
45 | 42 | | |
46 | 43 | | |
47 | 44 | | |
48 | | - | |
| 45 | + | |
49 | 46 | | |
50 | 47 | | |
51 | 48 | | |
| |||
56 | 53 | | |
57 | 54 | | |
58 | 55 | | |
59 | | - | |
| 56 | + | |
60 | 57 | | |
61 | 58 | | |
62 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
222 | | - | |
223 | | - | |
| 222 | + | |
| 223 | + | |
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
145 | | - | |
| 144 | + | |
| 145 | + | |
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
| |||
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
211 | | - | |
| 211 | + | |
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
245 | | - | |
| 245 | + | |
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
| |||
387 | 387 | | |
388 | 388 | | |
389 | 389 | | |
390 | | - | |
| 390 | + | |
391 | 391 | | |
392 | 392 | | |
393 | 393 | | |
| |||
400 | 400 | | |
401 | 401 | | |
402 | 402 | | |
403 | | - | |
| 403 | + | |
404 | 404 | | |
405 | 405 | | |
406 | 406 | | |
| |||
0 commit comments