editing error handling

Author: mrafi97

comp/metadata/hosthardware/impl/hosthardware.go

@@ -111,19 +111,22 @@ func NewHardwareHostProvider(deps Requires) Provides {
 	}
 }
 
-func (hh *hostHardware) fillData() {
+func (hh *hostHardware) fillData() error {
 	hardwareInfo, err := hardware.Collect()
 	if err != nil {
 		hh.log.Errorf("Failed to collect hardware information: %v", err)
 		hh.data = &hostHardwareMetadata{}
-		return
+		return err
 	}
+
 	hh.data.Manufacturer = hardwareInfo.Manufacturer
 	hh.data.ModelNumber = hardwareInfo.ModelNumber
 	hh.data.SerialNumber = hardwareInfo.SerialNumber
 	hh.data.Name = hardwareInfo.Name
 	hh.data.ChassisType = hardwareInfo.ChassisType
 	hh.data.Identifier = hardwareInfo.Identifier
+
+	return nil
 }
 
 func (hh *hostHardware) writePayloadAsJSON(w http.ResponseWriter, _ *http.Request) {
@@ -137,9 +140,9 @@ func (hh *hostHardware) writePayloadAsJSON(w http.ResponseWriter, _ *http.Reques
 }
 
 func (hh *hostHardware) getPayload() marshaler.JSONMarshaler {
-
-	hh.fillData()
-	if hh.data == nil {
+	// Try to collect hardware data
+	if err := hh.fillData(); err != nil {
+		hh.log.Debugf("Skipping hardware metadata payload due to collection failure: %v", err)
 		return nil
 	}
 

comp/metadata/hosthardware/impl/hosthardware_test.go

@@ -67,7 +67,6 @@ func TestNewHardwareHostProvider_FullMode(t *testing.T) {
 
 	// Should be disabled for full mode
 	assert.False(t, hh.InventoryPayload.Enabled, "Should be disabled in full mode")
-	assert.Nil(t, hh.MetadataProvider, "Provider should be nil when disabled")
 }
 
 func TestNewHardwareHostProvider_BasicMode(t *testing.T) {
@@ -109,17 +108,6 @@ func TestGetPayload(t *testing.T) {
 	assert.NotNil(t, p.Metadata, "Host hardware metadata should not be nil")
 }
 
-func TestGetPayload_NilData(t *testing.T) {
-	hh := getTestHostHardware(t, nil)
-
-	// Set data to nil
-	hh.data = nil
-
-	// Get payload should return nil when data is nil
-	payload := hh.getPayload()
-	assert.Nil(t, payload, "Payload should be nil when data is nil")
-}
-
 func TestPayloadMarshalJSON(t *testing.T) {
 	payload := &Payload{
 		Hostname:  "test-host",