[SNMP] Retrieve device profiles from remote config (#32543)

Author: dplepage-dd

cmd/agent/subcommands/run/command.go

@@ -589,7 +589,7 @@ func startAgent(
 	jmxfetch.RegisterWith(ac)
 
 	// Set up check collector
-	commonchecks.RegisterChecks(wmeta, tagger, cfg, telemetry)
+	commonchecks.RegisterChecks(wmeta, tagger, cfg, telemetry, rcclient)
 	ac.AddScheduler("check", pkgcollector.InitCheckScheduler(option.New(collector), demultiplexer, logReceiver, tagger), true)
 
 	demultiplexer.AddAgentStartupTelemetry(version.AgentVersion)

pkg/cli/subcommands/check/command.go

@@ -294,7 +294,10 @@ func run(
 	// TODO: (components) - Until the checks are components we set there context so they can depends on components.
 	check.InitializeInventoryChecksContext(invChecks)
 	pkgcollector.InitPython(common.GetPythonPaths()...)
-	commonchecks.RegisterChecks(wmeta, tagger, config, telemetry)
+	// TODO Ideally we would support RC in the check subcommand,
+	//  but at the moment this is not possible - only one process can access the RC database at a time,
+	//  so the subcommand can't read the RC database if the agent is also running.
+	commonchecks.RegisterChecks(wmeta, tagger, config, telemetry, nil)
 
 	common.LoadComponents(secretResolver, wmeta, ac, pkgconfigsetup.Datadog().GetString("confd_path"))
 	ac.LoadAndRun(context.Background())

pkg/collector/corechecks/snmp/internal/checkconfig/config.go

@@ -9,6 +9,7 @@ package checkconfig
 import (
 	"context"
 	"fmt"
+	"github.com/DataDog/datadog-agent/comp/remote-config/rcclient"
 	"hash/fnv"
 	"net"
 	"sort"
@@ -83,6 +84,7 @@ type DeviceDigest string
 // InitConfig is used to deserialize integration init config
 type InitConfig struct {
 	Profiles              profile.ProfileConfigMap          `yaml:"profiles"`
+	UseRCProfiles         bool                              `yaml:"use_remote_config_profiles"`
 	GlobalMetrics         []profiledefinition.MetricsConfig `yaml:"global_metrics"`
 	OidBatchSize          Number                            `yaml:"oid_batch_size"`
 	BulkMaxRepetitions    Number                            `yaml:"bulk_max_repetitions"`
@@ -266,7 +268,8 @@ func (c *CheckConfig) ToString() string {
 }
 
 // NewCheckConfig builds a new check config
-func NewCheckConfig(rawInstance integration.Data, rawInitConfig integration.Data) (*CheckConfig, error) {
+func NewCheckConfig(rawInstance integration.Data, rawInitConfig integration.Data, rcClient rcclient.Component) (*CheckConfig,
+	error) {
 	instance := InstanceConfig{}
 	initConfig := InitConfig{}
 
@@ -430,11 +433,25 @@ func NewCheckConfig(rawInstance integration.Data, rawInitConfig integration.Data
 		return nil, err
 	}
 
-	profiles, err := profile.GetProfileProvider(initConfig.Profiles)
+	if initConfig.UseRCProfiles {
+		if rcClient == nil {
+			return nil, fmt.Errorf("rc client not initialized, cannot use rc profiles")
+		}
+		if len(initConfig.Profiles) > 0 {
+			// We don't support merging inline profiles with profiles fetched via remote
+			// config - this would create too much potential for confusing scenarios where
+			// different agents with the same remote config setup disagree on what common
+			// profiles look like.
+			log.Warnf("SNMP init config contains %d inline profile(s); these will be "+
+				"ignored because use_remote_config_profiles is set", len(initConfig.Profiles))
+		}
+		c.ProfileProvider, err = profile.NewRCProvider(rcClient)
+	} else {
+		c.ProfileProvider, err = profile.GetProfileProvider(initConfig.Profiles)
+	}
 	if err != nil {
 		return nil, err
 	}
-	c.ProfileProvider = profiles
 
 	// profile configs
 	c.ProfileName = instance.Profile