Skip to content

Commit a5bab4d

Browse files
authored
Add health_check factories to host profiler standalone (#47718)
### What does this PR do? Add `health_check` factory to host profiler no agent. This is necessary in order to deploy standalone mode via upstream helm chart, as readiness and liveness probes are mandatory. See: - https://github.com/open-telemetry/opentelemetry-helm-charts/blob/opentelemetry-target-allocator-0.126.10/charts/opentelemetry-collector/values.yaml#L142-L145 - https://github.com/open-telemetry/opentelemetry-helm-charts/blob/opentelemetry-target-allocator-0.126.10/charts/opentelemetry-collector/templates/_pod.tpl#L80-L117 Related config: ``` extensions: health_check: endpoint: ${env:MY_POD_IP}:13133 ``` ### Motivation ### Describe how you validated your changes ### Additional Notes Co-authored-by: mackenzie.jomard <mackenzie.jomard@datadoghq.com>
1 parent 7ab624e commit a5bab4d

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

comp/host-profiler/collector/impl/otel_col_factories.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/processor/infraattributesprocessor"
2222
traceagent "github.com/DataDog/datadog-agent/comp/trace/agent/def"
2323
zapAgent "github.com/DataDog/datadog-agent/pkg/util/log/zap"
24+
healthcheckextension "github.com/open-telemetry/opentelemetry-collector-contrib/extension/healthcheckextension"
2425
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor"
2526
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor"
2627
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/k8sattributesprocessor"
@@ -158,7 +159,9 @@ func (e extraFactoriesWithoutAgentCore) GetAgentConfig() config.Component {
158159

159160
// GetExtensions returns the extensions for the collector.
160161
func (e extraFactoriesWithoutAgentCore) GetExtensions() []extension.Factory {
161-
return []extension.Factory{}
162+
return []extension.Factory{
163+
healthcheckextension.NewFactory(),
164+
}
162165
}
163166

164167
// GetProcessors returns the processors for the collector when the Agent Core is not available.

deps/go.MODULE.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ use_repo(
320320
"com_github_olekukonko_tablewriter",
321321
"com_github_oliveagle_jsonpath",
322322
"com_github_open_policy_agent_opa",
323+
"com_github_open_telemetry_opentelemetry_collector_contrib_extension_healthcheckextension",
323324
"com_github_open_telemetry_opentelemetry_collector_contrib_pkg_datadog",
324325
"com_github_open_telemetry_opentelemetry_collector_contrib_processor_attributesprocessor",
325326
"com_github_open_telemetry_opentelemetry_collector_contrib_processor_cumulativetodeltaprocessor",

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ require (
705705
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/loadbalancingexporter v0.147.0 // indirect
706706
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/sapmexporter v0.147.0 // indirect
707707
github.com/open-telemetry/opentelemetry-collector-contrib/extension/datadogextension v0.147.0 // indirect
708-
github.com/open-telemetry/opentelemetry-collector-contrib/extension/healthcheckextension v0.147.0 // indirect
708+
github.com/open-telemetry/opentelemetry-collector-contrib/extension/healthcheckextension v0.147.0
709709
github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer v0.147.0 // indirect
710710
github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/dockerobserver v0.147.0 // indirect
711711
github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/ecsobserver v0.147.0 // indirect

0 commit comments

Comments
 (0)