Skip to content

Commit a97d88c

Browse files
committed
dyninst: log more info about SymDB uploads
1 parent 78c87a7 commit a97d88c

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

pkg/dyninst/module/symdb.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -575,6 +575,7 @@ func (m *symdbManager) performUpload(
575575

576576
log.Infof("SymDB: uploading symbols for process %v (service: %s, version: %s, executable: %s)",
577577
procID.pid, procID.service, procID.version, executablePath)
578+
startTime := time.Now()
578579
it, err := symdb.PackagesIterator(
579580
executablePath,
580581
m.objectLoader,
@@ -591,7 +592,8 @@ func (m *symdbManager) performUpload(
591592
uploadBuffer := make([]uploader.Scope, 0, 100)
592593
bufferFuncs := 0
593594
uploadID := uuid.New()
594-
// Flush every so ofter in order to not store too many scopes in memory.
595+
var totalPackages, totalFuncs, numChunks int
596+
// Flush every so often in order to not store too many scopes in memory.
595597
maybeFlush := func(final bool) error {
596598
if ctx.Err() != nil {
597599
return context.Cause(ctx)
@@ -612,6 +614,7 @@ func (m *symdbManager) performUpload(
612614
if err != nil {
613615
return fmt.Errorf("upload failed: %w", err)
614616
}
617+
numChunks++
615618
uploadBuffer = uploadBuffer[:0]
616619
bufferFuncs = 0
617620
}
@@ -629,13 +632,18 @@ func (m *symdbManager) performUpload(
629632

630633
scope := uploader.ConvertPackageToScope(pkg.Package, version.AgentVersion)
631634
uploadBuffer = append(uploadBuffer, scope)
635+
totalPackages++
636+
totalFuncs += pkg.Stats().NumFunctions
632637
bufferFuncs += pkg.Stats().NumFunctions
633638
if err := maybeFlush(pkg.Final); err != nil {
634639
return err
635640
}
636641
}
637642

638-
log.Infof("SymDB: Successfully uploaded symbols for process %v (service: %s, version: %s, executable: %s)",
639-
procID.pid, procID.service, procID.version, executablePath)
643+
log.Infof("SymDB: Successfully uploaded symbols for process %v "+
644+
"(service: %s, version: %s, executable: %s):"+
645+
" %d packages, %d functions, %d chunks in %v",
646+
procID.pid, procID.service, procID.version, executablePath,
647+
totalPackages, totalFuncs, numChunks, time.Since(startTime))
640648
return nil
641649
}

0 commit comments

Comments
 (0)