Skip to content

Commit b4ae9ef

Browse files
committed
enable fips for windows
1 parent 0134072 commit b4ae9ef

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

.gitlab/deploy/container_build/docker_windows.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@
2323
# Omnibus uses a slightly different path than the actual install
2424
# TODO: This overwrites an extra agent.exe, we should also remove it from the zip
2525
- mv "Datadog Agent\bin\agent\agent.exe" "Datadog Agent\bin\agent.exe" -Force
26-
# TODO(AGENTCFG-XXX): SGC is not supported in FIPS mode
27-
- if (Test-Path "Datadog Agent\bin\agent\secret-generic-connector.exe") { mv "Datadog Agent\bin\agent\secret-generic-connector.exe" "Datadog Agent\bin\secret-generic-connector.exe" -Force }
26+
- mv "Datadog Agent\bin\agent\secret-generic-connector.exe" "Datadog Agent\bin\secret-generic-connector.exe" -Force
2827
- popd
2928

3029
- get-childitem ${BUILD_CONTEXT}

omnibus/config/projects/agent.rb

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -323,10 +323,7 @@
323323
"#{install_dir}\\datadog-installer.exe"
324324
]
325325

326-
if not fips_mode?
327-
# TODO(AGENTCFG-XXX): SGC is not supported in FIPS mode
328-
GO_BINARIES << "#{install_dir}\\bin\\agent\\secret-generic-connector.exe"
329-
end
326+
GO_BINARIES << "#{install_dir}\\bin\\agent\\secret-generic-connector.exe"
330327

331328
if not windows_arch_i386? and ENV['WINDOWS_DDPROCMON_DRIVER'] and not ENV['WINDOWS_DDPROCMON_DRIVER'].empty?
332329
GO_BINARIES << "#{install_dir}\\bin\\agent\\security-agent.exe"

tools/windows/DatadogAgentInstaller/WixSetup/Datadog Agent/AgentInstaller.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -645,10 +645,9 @@ private Dir CreateBinFolder()
645645
),
646646
scriptsBinDir
647647
);
648-
// TODO(AGENTCFG-XXX): SGC is not supported in FIPS mode
648+
targetBinFolder.AddFile(new WixSharp.File(_agentBinaries.SecretGenericConnector));
649649
if (_agentFlavor.FlavorName != Constants.FipsFlavor)
650650
{
651-
targetBinFolder.AddFile(new WixSharp.File(_agentBinaries.SecretGenericConnector));
652651
targetBinFolder.AddFile(new WixSharp.File(_agentBinaries.DdCompilePolicy));
653652
}
654653

0 commit comments

Comments
 (0)