Skip to content

Commit ebd4d55

Browse files
authored
remove flake marker from startstop tests (#47534)
### What does this PR do? remove flake.Mark from Windows service startstop tests ### Motivation we're not aware of any flaky behavior and CI history is clear Co-authored-by: branden.clark <branden.clark@datadoghq.com>
1 parent 1222bd2 commit ebd4d55

File tree

1 file changed

+0
-42
lines changed

1 file changed

+0
-42
lines changed

test/new-e2e/tests/windows/service-test/startstop_test.go

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -80,27 +80,18 @@ type onServiceStateMismatch func(host *components.RemoteHost, serviceName, actua
8080

8181
// TestServiceBehaviorAgentCommandNoFIM tests the service behavior when controlled by Agent commands
8282
func TestNoFIMServiceBehaviorAgentCommand(t *testing.T) {
83-
// TODO(windows-products): Fix flakiness and re-enable this test
84-
flake.Mark(t)
85-
8683
s := &agentServiceCommandSuite{}
8784
run(t, s, systemProbeNoFIMConfig, agentConfig, securityAgentConfig)
8885
}
8986

9087
// TestServiceBehaviorPowerShellNoFIM tests the service behavior when controlled by PowerShell commands
9188
func TestNoFIMServiceBehaviorPowerShell(t *testing.T) {
92-
// TODO(windows-products): Fix flakiness and re-enable this test
93-
flake.Mark(t)
94-
9589
s := &powerShellServiceCommandSuite{}
9690
run(t, s, systemProbeNoFIMConfig, agentConfig, securityAgentConfig)
9791
}
9892

9993
// TestServiceBehaviorAgentCommand tests the service behavior when controlled by Agent commands
10094
func TestServiceBehaviorAgentCommand(t *testing.T) {
101-
// TODO(windows-products): Fix flakiness and re-enable this test
102-
flake.Mark(t)
103-
10495
s := &agentServiceCommandSuite{}
10596
run(t, s, systemProbeConfig, agentConfig, securityAgentConfig)
10697
}
@@ -139,9 +130,6 @@ func (s *agentServiceCommandSuite) SetupSuite() {
139130

140131
// TestServiceBehaviorAgentCommand tests the service behavior when controlled by PowerShell commands
141132
func TestServiceBehaviorPowerShell(t *testing.T) {
142-
// TODO(windows-products): Fix flakiness and re-enable this test
143-
flake.Mark(t)
144-
145133
s := &powerShellServiceCommandSuite{}
146134
run(t, s, systemProbeConfig, agentConfig, securityAgentConfig)
147135
}
@@ -289,9 +277,6 @@ type agentServiceDisabledSuite struct {
289277

290278
// TestServiceBehaviorWhenDisabled tests the service behavior when disabled in the configuration
291279
func TestServiceBehaviorWhenDisabledSystemProbe(t *testing.T) {
292-
// TODO(windows-products): Fix flakiness and re-enable this test
293-
flake.Mark(t)
294-
295280
s := &agentServiceDisabledSystemProbeSuite{}
296281
s.disabledServices = []string{
297282
"datadog-security-agent",
@@ -308,9 +293,6 @@ type agentServiceDisabledSystemProbeSuite struct {
308293

309294
// TestServiceBehaviorWhenDisabledProcessAgent tests the service behavior when disabled in the configuration
310295
func TestServiceBehaviorWhenDisabledProcessAgent(t *testing.T) {
311-
// TODO(windows-products): Fix flakiness and re-enable this test
312-
flake.Mark(t)
313-
314296
s := &agentServiceDisabledProcessAgentSuite{}
315297
s.disabledServices = []string{
316298
"datadog-process-agent",
@@ -327,9 +309,6 @@ type agentServiceDisabledProcessAgentSuite struct {
327309
}
328310

329311
func TestServiceBehaviorWhenDisabledTraceAgent(t *testing.T) {
330-
// TODO(windows-products): Fix flakiness and re-enable this test
331-
flake.Mark(t)
332-
333312
s := &agentServiceDisabledTraceAgentSuite{}
334313
s.disabledServices = []string{
335314
"datadog-trace-agent",
@@ -342,9 +321,6 @@ type agentServiceDisabledTraceAgentSuite struct {
342321
}
343322

344323
func TestServiceBehaviorWhenDisabledInstaller(t *testing.T) {
345-
// TODO(windows-products): Fix flakiness and re-enable this test
346-
flake.Mark(t)
347-
348324
s := &agentServiceDisabledInstallerSuite{}
349325
s.disabledServices = []string{
350326
"Datadog Installer",
@@ -959,9 +935,6 @@ type dvAgentServiceDisabledInstallerSuite struct {
959935
// TestDriverVerifierOnServiceBehaviorAgentCommand tests the same as TestServiceBehaviorAgentCommand
960936
// with driver verifier enabled.
961937
func TestDriverVerifierOnServiceBehaviorAgentCommand(t *testing.T) {
962-
// TODO(windows-products): Fix flakiness and re-enable this test
963-
flake.Mark(t)
964-
965938
s := &dvAgentServiceCommandSuite{}
966939
s.enableDriverVerifier = true
967940
s.timeoutScale = driverVerifierTimeoutScale
@@ -971,9 +944,6 @@ func TestDriverVerifierOnServiceBehaviorAgentCommand(t *testing.T) {
971944
// TestDriverVerifierOnServiceBehaviorPowerShell tests the the same as TestServiceBehaviorPowerShell
972945
// with driver verifier enabled.
973946
func TestDriverVerifierOnServiceBehaviorPowerShell(t *testing.T) {
974-
// TODO(windows-products): Fix flakiness and re-enable this test
975-
flake.Mark(t)
976-
977947
s := &dvPowerShellServiceCommandSuite{}
978948
s.enableDriverVerifier = true
979949
s.timeoutScale = driverVerifierTimeoutScale
@@ -983,9 +953,6 @@ func TestDriverVerifierOnServiceBehaviorPowerShell(t *testing.T) {
983953
// TestDriverVerifierOnServiceBehaviorWhenDisabledSystemProbe tests the same as TestServiceBehaviorWhenDisabledSystemProbe
984954
// with driver verifier enabled.
985955
func TestDriverVerifierOnServiceBehaviorWhenDisabledSystemProbe(t *testing.T) {
986-
// TODO(windows-products): Fix flakiness and re-enable this test
987-
flake.Mark(t)
988-
989956
s := &dvAgentServiceDisabledSystemProbeSuite{}
990957
s.disabledServices = []string{
991958
"datadog-security-agent",
@@ -1001,9 +968,6 @@ func TestDriverVerifierOnServiceBehaviorWhenDisabledSystemProbe(t *testing.T) {
1001968
// TestDriverVerifierOnServiceBehaviorWhenDisabledProcessAgent tests the same as TestServiceBehaviorWhenDisabledProcessAgent
1002969
// with driver verifier enabled.
1003970
func TestDriverVerifierOnServiceBehaviorWhenDisabledProcessAgent(t *testing.T) {
1004-
// TODO(windows-products): Fix flakiness and re-enable this test
1005-
flake.Mark(t)
1006-
1007971
s := &dvAgentServiceDisabledProcessAgentSuite{}
1008972
s.disabledServices = []string{
1009973
"datadog-process-agent",
@@ -1020,9 +984,6 @@ func TestDriverVerifierOnServiceBehaviorWhenDisabledProcessAgent(t *testing.T) {
1020984
// TestDriverVerifierOnServiceBehaviorWhenDisabledTraceAgent tests the same as TestServiceBehaviorWhenDisabledTraceAgent
1021985
// with driver verifier enabled.
1022986
func TestDriverVerifierOnServiceBehaviorWhenDisabledTraceAgent(t *testing.T) {
1023-
// TODO(windows-products): Fix flakiness and re-enable this test
1024-
flake.Mark(t)
1025-
1026987
s := &dvAgentServiceDisabledTraceAgentSuite{}
1027988
s.disabledServices = []string{
1028989
"datadog-trace-agent",
@@ -1035,9 +996,6 @@ func TestDriverVerifierOnServiceBehaviorWhenDisabledTraceAgent(t *testing.T) {
1035996
// TestDriverVerifierOnServiceBehaviorWhenDisabledInstaller tests the same as TestServiceBehaviorWhenDisabledInstaller
1036997
// with driver verifier enabled.
1037998
func TestDriverVerifierOnServiceBehaviorWhenDisabledInstaller(t *testing.T) {
1038-
// TODO(windows-products): Fix flakiness and re-enable this test
1039-
flake.Mark(t)
1040-
1041999
s := &dvAgentServiceDisabledInstallerSuite{}
10421000
s.disabledServices = []string{
10431001
"Datadog Installer",

0 commit comments

Comments
 (0)