-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[USM] Enhance USM debugging: add netstat command #44610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 876e309 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.16 | [-1.84, +4.16] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.16 | [-1.84, +4.16] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.88 | [+0.66, +1.10] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.67 | [+0.51, +0.82] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.54 | [+0.50, +0.59] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.43 | [+0.37, +0.50] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.32 | [+0.10, +0.53] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.31 | [+0.26, +0.36] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.22 | [+0.15, +0.28] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.18 | [+0.14, +0.21] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.13 | [-0.10, +0.36] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.06 | [-0.34, +0.47] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.04 | [-0.12, +0.21] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.08, +0.07] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.13, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.01 | [-0.43, +0.42] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.02 | [-0.15, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.06 | [-0.11, -0.01] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.07 | [-0.44, +0.30] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.09 | [-0.16, -0.02] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.33 | [-0.38, -0.27] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.64 | [-0.73, -0.54] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.64 | [-0.84, -0.44] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -1.49 | [-2.95, -0.03] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
|
||
| cmd.Flags().BoolVarP(&showTCP, "tcp", "t", true, "Show TCP connections") | ||
| cmd.Flags().BoolVarP(&showUDP, "udp", "u", true, "Show UDP connections") | ||
| cmd.Flags().BoolVarP(&showListening, "listening", "l", false, "Show only listening sockets") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this option, and the additional code for it
running system-probe usm netstat | grep -i listening yields the same output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The --listening flag:
- Shows TCP connections in LISTEN state
- Shows ALL UDP sockets (UDP is connectionless, so there's no "listening" vs "established" concept)
- Filters at the data level before output
Using grep -i listening:
- Only shows output lines containing the text "LISTEN" or "listening"
- Would miss all UDP sockets (their state is "-", not "LISTEN")
- Filters at the text output level
Example difference:
With --listening flag
sudo system-probe usm netstat --listening
tcp | 0.0.0.0:22 | 0.0.0.0:0 | LISTEN | 1234/sshd
tcp | 0.0.0.0:80 | 0.0.0.0:0 | LISTEN | 5678/nginx
udp | 0.0.0.0:53 | 0.0.0.0:0 | - | 9012/dnsmasq # UDP included!
With grep
sudo system-probe usm netstat | grep -i listen
tcp | 0.0.0.0:22 | 0.0.0.0:0 | LISTEN | 1234/sshd
tcp | 0.0.0.0:80 | 0.0.0.0:0 | LISTEN | 5678/nginx
UDP socket is MISSING because it doesn't have "LISTEN" in the output!
The --listening flag follows standard netstat -l behavior and is useful for finding what services are accepting connections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since --listening is just doing a filtering, you can use grep for it
grep -i -e listening -e udp
The point is that you don't need to actually implement that filtering logic since you can use grep
But that's up to you
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
### What does this PR do? 1. Enhanced usm sysinfo command - Now displays detected service names alongside process information 2. New usm netstat command - Shows network connections similar to netstat -antpu with process information usm sysinfo Enhancements - Added "Service" column showing detected service names - Detects DD_SERVICE environment variable from Docker containers and Kubernetes pods - Falls back to generated service names using the same logic as process-agent - Added --max-service-length flag (default: 20) to control service name display width - Refactored to use service discovery infrastructure (envs.Variables, kernel.HostProc()) - Removed all magic numbers and strings, replaced with well-named constants New usm netstat Command - Displays active network connections (TCP/UDP, IPv4/IPv6) - Maps connections to processes showing PID and process name - Supports filtering: --tcp/-t, --udp/-u, --listening/-l flags - Shows connection state (ESTABLISHED, LISTEN, TIME_WAIT, etc.) - Optimized inode-to-PID mapping for performance - Uses kernel.HostProc() for proper container/namespace support ### Motivation When debugging USM issues, these commands provide essential diagnostic information: For usm sysinfo: - Verify service discovery is working correctly for target applications - Confirm expected services are running and properly identified - Validate service names match what's expected in USM monitoring - Debug DD_SERVICE environment variable propagation in containers For usm netstat: - Identify which processes own specific network connections - Debug USM connectivity issues - Verify which processes are listening on ports - Check established connections for monitored services - Troubleshoot port conflicts ### Describe how you validated your changes Manual Testing: - Verified DD_SERVICE detection from Docker containers (-e DD_SERVICE=mysrv) - Tested netstat with various flags (--tcp, --udp, --listening) - Confirmed TCP state display (TIME_WAIT, ESTABLISHED, etc.) - Validated process name and PID mapping for network connections Testing: - Added unit test for --max-service-length flag (default: 20) ### Additional Notes Co-authored-by: guyarb <[email protected]> Co-authored-by: guy.arbitman <[email protected]> 504b7f3
What does this PR do?
usm sysinfo Enhancements
New usm netstat Command
Motivation
When debugging USM issues, these commands provide essential diagnostic information:
For usm sysinfo:
For usm netstat:
Describe how you validated your changes
Manual Testing:
Testing:
Additional Notes