Fix Python type checking (#487)

* Enforce type checking

This was skipped for unknown reasons.

* Regenerate client from commit 7f25c3e of spec repo

Co-authored-by: Thomas Hervé <[email protected]>
Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com>
Co-authored-by: ci.datadog-api-spec <[email protected]>

Author: 3 people

.apigentools-info

@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.4.1.dev8",
-            "regenerated": "2021-06-17 12:46:48.192991",
-            "spec_repo_commit": "3efd10d"
+            "regenerated": "2021-06-17 15:07:58.879914",
+            "spec_repo_commit": "7f25c3e"
         },
         "v2": {
             "apigentools_version": "1.4.1.dev8",
-            "regenerated": "2021-06-17 12:47:17.170607",
-            "spec_repo_commit": "3efd10d"
+            "regenerated": "2021-06-17 15:08:28.826169",
+            "spec_repo_commit": "7f25c3e"
         }
     }
 }

.generator/templates/model_templates/method_set_attribute.mustache

@@ -31,7 +31,7 @@
                 key_type=True
             )
 
-        if self._check_type:
+        if self._check_type and value is not None:
             value = validate_and_convert_types(
                 value, required_types_mixed, path_to_item, self._spec_property_naming,
                 self._check_type, configuration=self._configuration)
@@ -48,4 +48,4 @@
                 value,
                 self._configuration
             )
-        self.__dict__['_data_store'][name] = value
+        self.__dict__['_data_store'][name] = value

.generator/templates/model_utils.mustache

@@ -1,6 +1,5 @@
 {{>partial_header}}
 
-import copy
 from datetime import date, datetime  # noqa: F401
 import inspect
 import io
@@ -1013,6 +1012,8 @@ def attempt_convert_item(input_value, valid_classes, path_to_item,
             # if we have conversion errors when must_convert == False
             # we ignore the exception and move on to the next class
             continue
+    if must_convert:
+        raise get_type_error(input_value, path_to_item, valid_classes, key_type=key_type)
     # we were unable to convert, must_convert == False
     return input_value
 
@@ -1368,10 +1369,6 @@ def get_oneof_instance(cls, model_kwargs, constant_kwargs, model_arg=None):
     if len(cls._composed_schemas['oneOf']) == 0:
         return None
 
-    # Buld a configuration that doesn't discard unknown keys for primitive types
-    discard_configuration = copy.deepcopy(constant_kwargs["_configuration"])
-    discard_configuration.discard_unknown_keys = False
-
     oneof_instances = []
     # Iterate over each oneOf schema and determine if the input data
     # matches the oneOf schemas.
@@ -1420,7 +1417,7 @@ def get_oneof_instance(cls, model_kwargs, constant_kwargs, model_arg=None):
                         constant_kwargs['_path_to_item'],
                         constant_kwargs['_spec_property_naming'],
                         constant_kwargs['_check_type'],
-                        configuration=discard_configuration
+                        configuration=constant_kwargs['_configuration']
                     )
             oneof_instances.append(oneof_instance)
         except Exception:

.openapi-generator/FILES

@@ -275,7 +275,6 @@ datadog_api_client/v2/model/security_filter_attributes.py
 datadog_api_client/v2/model/security_filter_create_attributes.py
 datadog_api_client/v2/model/security_filter_create_data.py
 datadog_api_client/v2/model/security_filter_create_request.py
-datadog_api_client/v2/model/security_filter_delete_response.py
 datadog_api_client/v2/model/security_filter_exclusion_filter.py
 datadog_api_client/v2/model/security_filter_exclusion_filter_response.py
 datadog_api_client/v2/model/security_filter_filtered_data_type.py
@@ -610,7 +609,6 @@ docs/SecurityFilterAttributes.md
 docs/SecurityFilterCreateAttributes.md
 docs/SecurityFilterCreateData.md
 docs/SecurityFilterCreateRequest.md
-docs/SecurityFilterDeleteResponse.md
 docs/SecurityFilterExclusionFilter.md
 docs/SecurityFilterExclusionFilterResponse.md
 docs/SecurityFilterFilteredDataType.md
@@ -944,7 +942,6 @@ test/test_security_filter_attributes.py
 test/test_security_filter_create_attributes.py
 test/test_security_filter_create_data.py
 test/test_security_filter_create_request.py
-test/test_security_filter_delete_response.py
 test/test_security_filter_exclusion_filter.py
 test/test_security_filter_exclusion_filter_response.py
 test/test_security_filter_filtered_data_type.py

docs/v2/README.md

@@ -441,7 +441,6 @@ Class | Method | HTTP request | Description
  - [SecurityFilterCreateAttributes](SecurityFilterCreateAttributes.md)
  - [SecurityFilterCreateData](SecurityFilterCreateData.md)
  - [SecurityFilterCreateRequest](SecurityFilterCreateRequest.md)
- - [SecurityFilterDeleteResponse](SecurityFilterDeleteResponse.md)
  - [SecurityFilterExclusionFilter](SecurityFilterExclusionFilter.md)
  - [SecurityFilterExclusionFilterResponse](SecurityFilterExclusionFilterResponse.md)
  - [SecurityFilterFilteredDataType](SecurityFilterFilteredDataType.md)

docs/v2/SecurityFilterDeleteResponse.md

@@ -219,7 +219,7 @@ Name | Type | Description  | Notes
 [[Back to top]](#) [[Back to API list]](README.md#documentation-for-api-endpoints) [[Back to Model list]](README.md#documentation-for-models) [[Back to README]](README.md)
 
 # **delete_security_filter**
-> SecurityFilterDeleteResponse delete_security_filter(security_filter_id)
+> delete_security_filter(security_filter_id)
 
 Delete a security filter
 
@@ -248,8 +248,7 @@ with ApiClient(configuration) as api_client:
     # example passing only required values which don't have defaults set
     try:
         # Delete a security filter
-        api_response = api_instance.delete_security_filter(security_filter_id)
-        pprint(api_response)
+        api_instance.delete_security_filter(security_filter_id)
     except ApiException as e:
         print("Exception when calling SecurityMonitoringApi->delete_security_filter: %s\n" % e)
 ```
@@ -263,7 +262,7 @@ Name | Type | Description  | Notes
 
 ### Return type
 
-[**SecurityFilterDeleteResponse**](SecurityFilterDeleteResponse.md)
+void (empty response body)
 
 ### Authorization
 
@@ -278,8 +277,7 @@ Name | Type | Description  | Notes
 ### HTTP response details
 | Status code | Description | Response headers |
 |-------------|-------------|------------------|
-**200** | OK |  -  |
-**204** | No Content |  -  |
+**204** | OK |  -  |
 **403** | Not Authorized |  -  |
 **404** | Not Found |  -  |
 **429** | Too many requests |  -  |

docs/v2/SecurityMonitoringApi.md

@@ -3,7 +3,6 @@
 # Copyright 2019-Present Datadog, Inc.
 
 
-import copy
 from datetime import date, datetime  # noqa: F401
 import inspect
 import io
@@ -116,7 +115,7 @@ def set_attribute(self, name, value):
             error_msg = type_error_message(var_name=name, var_value=name, valid_classes=(str,), key_type=True)
             raise ApiTypeError(error_msg, path_to_item=path_to_item, valid_classes=(str,), key_type=True)
 
-        if self._check_type:
+        if self._check_type and value is not None:
             value = validate_and_convert_types(
                 value,
                 required_types_mixed,
@@ -1207,6 +1206,8 @@ def attempt_convert_item(
             # if we have conversion errors when must_convert == False
             # we ignore the exception and move on to the next class
             continue
+    if must_convert:
+        raise get_type_error(input_value, path_to_item, valid_classes, key_type=key_type)
     # we were unable to convert, must_convert == False
     return input_value
 
@@ -1554,10 +1555,6 @@ def get_oneof_instance(cls, model_kwargs, constant_kwargs, model_arg=None):
     if len(cls._composed_schemas["oneOf"]) == 0:
         return None
 
-    # Buld a configuration that doesn't discard unknown keys for primitive types
-    discard_configuration = copy.deepcopy(constant_kwargs["_configuration"])
-    discard_configuration.discard_unknown_keys = False
-
     oneof_instances = []
     # Iterate over each oneOf schema and determine if the input data
     # matches the oneOf schemas.
@@ -1605,7 +1602,7 @@ def get_oneof_instance(cls, model_kwargs, constant_kwargs, model_arg=None):
                         constant_kwargs["_path_to_item"],
                         constant_kwargs["_spec_property_naming"],
                         constant_kwargs["_check_type"],
-                        configuration=discard_configuration,
+                        configuration=constant_kwargs["_configuration"],
                     )
             oneof_instances.append(oneof_instance)
         except Exception:

src/datadog_api_client/v1/model_utils.py

@@ -18,7 +18,6 @@
 )
 from datadog_api_client.v2.model.api_error_response import APIErrorResponse
 from datadog_api_client.v2.model.security_filter_create_request import SecurityFilterCreateRequest
-from datadog_api_client.v2.model.security_filter_delete_response import SecurityFilterDeleteResponse
 from datadog_api_client.v2.model.security_filter_response import SecurityFilterResponse
 from datadog_api_client.v2.model.security_filter_update_request import SecurityFilterUpdateRequest
 from datadog_api_client.v2.model.security_filters_response import SecurityFiltersResponse
@@ -117,7 +116,7 @@ def __init__(self, api_client=None):
 
         self._delete_security_filter_endpoint = _Endpoint(
             settings={
-                "response_type": (SecurityFilterDeleteResponse,),
+                "response_type": None,
                 "auth": ["apiKeyAuth", "appKeyAuth"],
                 "endpoint_path": "/api/v2/security_monitoring/configuration/security_filters/{security_filter_id}",
                 "operation_id": "delete_security_filter",
@@ -651,7 +650,7 @@ def delete_security_filter(self, security_filter_id, **kwargs):
             async_req (bool): execute request asynchronously
 
         Returns:
-            SecurityFilterDeleteResponse
+            None
                 If the method is called asynchronously, returns the request
                 thread.
         """