Do type conversion all the time in Python (#757)

* Do type conversion all the time

Don't conditionally do type conversion, which is useful to do basic
casting (like into to float).

* Add test

* Regenerate client from commit 63335df of spec repo

Co-authored-by: Thomas Hervé <[email protected]>
Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com>
Co-authored-by: ci.datadog-api-spec <[email protected]>

Author: 3 people

.apigentools-info

@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.5.1.dev2",
-            "regenerated": "2021-12-23 17:02:34.770350",
-            "spec_repo_commit": "7b8392b"
+            "regenerated": "2022-01-03 13:20:02.788921",
+            "spec_repo_commit": "63335df"
         },
         "v2": {
             "apigentools_version": "1.5.1.dev2",
-            "regenerated": "2021-12-23 17:02:35.234866",
-            "spec_repo_commit": "7b8392b"
+            "regenerated": "2022-01-03 13:20:03.271184",
+            "spec_repo_commit": "63335df"
         }
     }
 }

.generator/templates/model_utils.mustache

@@ -1408,9 +1408,6 @@ def validate_and_convert_types(input_value, required_types_mixed, path_to_item,
             will be attempted.
         configuration: (Configuration): the configuration class to use
             when converting file_type items.
-            If passed, conversion will be attempted when possible
-            If not passed, no conversions will be attempted and
-            exceptions will be raised
 
     Returns:
         the correctly typed value
@@ -1424,30 +1421,25 @@ def validate_and_convert_types(input_value, required_types_mixed, path_to_item,
     input_class_simple = get_simple_class(input_value)
     valid_type = is_valid_type(input_class_simple, valid_classes)
     if not valid_type:
-        if configuration:
-            # if input_value is not valid_type try to convert it
-            converted_instance = attempt_convert_item(
-                input_value,
-                valid_classes,
-                path_to_item,
-                configuration,
-                spec_property_naming,
-                key_type=False,
-                must_convert=True,
-                check_type=_check_type
-            )
-            return converted_instance
-        else:
-            raise get_type_error(input_value, path_to_item, valid_classes,
-                                 key_type=False)
+        # if input_value is not valid_type try to convert it
+        return attempt_convert_item(
+            input_value,
+            valid_classes,
+            path_to_item,
+            configuration,
+            spec_property_naming,
+            key_type=False,
+            must_convert=True,
+            check_type=_check_type
+        )
 
     # input_value's type is in valid_classes
     if len(valid_classes) > 1 and configuration:
         # there are valid classes which are not the current class
         valid_classes_coercible = remove_uncoercible(
             valid_classes, input_value, spec_property_naming, must_convert=False)
         if valid_classes_coercible:
-            converted_instance = attempt_convert_item(
+            return attempt_convert_item(
                 input_value,
                 valid_classes_coercible,
                 path_to_item,
@@ -1457,7 +1449,6 @@ def validate_and_convert_types(input_value, required_types_mixed, path_to_item,
                 must_convert=False,
                 check_type=_check_type
             )
-            return converted_instance
 
     if child_req_types_by_current_type == {}:
         # all types are of the required types and there are no more inner

src/datadog_api_client/v1/model_utils.py

@@ -0,0 +1,6 @@
+from datadog_api_client.v1.model.monitor_thresholds import MonitorThresholds
+
+
+def test_default_coerce():
+    thresholds = MonitorThresholds(critical=5)
+    assert thresholds["critical"] == 5.0