Skip to content

Fix and cleanup security scopes #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
api-clients-generation-pipeline wants to merge 1 commit into from
Closed

Fix and cleanup security scopes #2129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2024-12-03 10:17:28.049947",
"spec_repo_commit": "3f8bbb67"
"regenerated": "2024-12-03 15:07:05.922344",
"spec_repo_commit": "052a1901"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2024-12-03 10:17:28.068735",
"spec_repo_commit": "3f8bbb67"
"regenerated": "2024-12-03 15:07:05.941270",
"spec_repo_commit": "052a1901"
}
}
}
15 changes: 1 addition & 14 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27592,9 +27592,6 @@ components:
apm_service_catalog_read: View service catalog and service definitions.
apm_service_catalog_write: Add, modify, and delete service catalog definitions
when those definitions are maintained by Datadog.
appsec_vm_read: View infrastructure, application code and library vulnerabilities.
This does not restrict access to the vulnerability data source through
the API or inventory SQL.
cases_read: View Cases.
cases_write: Create and update cases.
ci_visibility_pipelines_write: Create CI Visibility pipeline spans using
Expand All @@ -27619,7 +27616,6 @@ components:
incident_notification_settings_write: Configure Incidents Notification
settings.
incident_read: View incidents in Datadog.
incident_settings_read: View Incident Settings.
incident_settings_write: Configure Incident Settings.
incident_write: Create, view, and manage incidents in Datadog.
metrics_read: View custom metrics.
Expand All @@ -27640,7 +27636,6 @@ components:
security_monitoring_rules_read: Read Detection Rules.
security_monitoring_rules_write: Create and edit Detection Rules.
security_monitoring_signals_read: View Security Signals.
security_monitoring_signals_write: Edit Security Signals.
security_monitoring_suppressions_read: Read Rule Suppressions.
security_monitoring_suppressions_write: Write Rule Suppressions.
security_pipelines_read: View Security Pipelines.
Expand All @@ -27665,6 +27660,7 @@ components:
Access Manage permission.
teams_read: Read Teams data. A User with this permission can view Team
names, metadata, and which Users are on each Team.
test_visibility_read: View Test Visibility.
timeseries_query: Query Timeseries data.
usage_read: View your organization's usage and usage attribution.
user_access_invite: Invite other users to your organization.
Expand Down Expand Up @@ -32043,15 +32039,13 @@ paths:
- apiKeyAuth: []
appKeyAuth: []
- AuthZ:
- incident_settings_read
- incident_read
summary: Get a list of incident types
tags:
- Incidents
x-permission:
operator: OR
permissions:
- incident_settings_read
- incident_read
x-unstable: '**Note**: This endpoint is in public beta.

Expand Down Expand Up @@ -32160,15 +32154,13 @@ paths:
- apiKeyAuth: []
appKeyAuth: []
- AuthZ:
- incident_settings_read
- incident_read
summary: Get incident type details
tags:
- Incidents
x-permission:
operator: OR
permissions:
- incident_settings_read
- incident_read
x-unstable: '**Note**: This endpoint is in public beta.

Expand Down Expand Up @@ -41537,11 +41529,6 @@ paths:
$ref: '#/components/responses/NotFoundResponse'
'429':
$ref: '#/components/responses/TooManyRequestsResponse'
security:
- apiKeyAuth: []
appKeyAuth: []
- AuthZ:
- security_monitoring_signals_write
summary: Convert a job result to a signal
tags:
- Security Monitoring
Expand Down
2 changes: 1 addition & 1 deletion lib/datadog_api_client/v2/api/security_monitoring_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def convert_job_result_to_signal_with_http_info(body, opts = {})
return_type = opts[:debug_return_type]

# auth_names
auth_names = opts[:debug_auth_names] || [:apiKeyAuth, :appKeyAuth, :AuthZ]
auth_names = opts[:debug_auth_names] || [:apiKeyAuth, :appKeyAuth]
Copy link

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 bot Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Code Quality Violation

Suggested change
auth_names = opts[:debug_auth_names] || [:apiKeyAuth, :appKeyAuth]
auth_names = opts[:debug_auth_names] || %i[apiKeyAuth appKeyAuth]
Consider using the %i syntax instead (...read more)

The rule "Prefer %i to the literal array syntax" is a guideline that encourages the use of the %i syntax for arrays of symbols. This is a part of the Ruby style guide that aims to promote conciseness and readability.

Symbols are immutable, reusable objects often used in Ruby instead of strings when the value does not need to be changed. When declaring an array of symbols, using the %i syntax can make your code cleaner and easier to read.

To adhere to this rule, instead of declaring an array of symbols using the literal array syntax like [:foo, :bar, :baz], use the %i syntax like %i[foo bar baz]. It's a good practice to consistently use %i for arrays of symbols as it enhances code readability and maintainability.

View in Datadog  Leave us feedback  Documentation


new_options = opts.merge(
:operation => :convert_job_result_to_signal,
Expand Down
Loading