fix the concurrency group of the integration workflow #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MintsInc
force-pushed
the
ulysse.mavrocordatos/fix-integration-concurrency-group
branch
from
1e0d262 to
41626ae
Compare
damfleu
approved these changes
Sep 25, 2025
The reusable workflows had duplicate conditions that don't work properly in workflow_call context since github.event.pull_request is not available. The main test.yml workflow already handles these conditions correctly.
MintsInc
force-pushed
the
ulysse.mavrocordatos/fix-integration-concurrency-group
branch
from
de9f349 to
b0202d3
Compare
MintsInc
deleted the
ulysse.mavrocordatos/fix-integration-concurrency-group
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2025
* fix the concurrency group of the integration workflow * fix: remove duplicate conditional logic from reusable workflows The reusable workflows had duplicate conditions that don't work properly in workflow_call context since github.event.pull_request is not available. The main test.yml workflow already handles these conditions correctly. a361f47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The concurrency group of the integration workflow is currently the same for all client CI when ran from a PR on the specification repo. This causes all integration test jobs but one to be cancelled.
To prevent this we change the concurrency group so it's dependent on the branch name and the targeted client.
There was also duplication of conditions to run the workflow which is unnecessary and might cause issues down the line.