More resilient date-time deserialization (#1009)

* more resilient date-time deserializing and fix error throwing

Author: skarimo

.generator/src/generator/templates/model/ObjectSerializer.j2

@@ -186,7 +186,11 @@ export class ObjectSerializer {
       }
       return transformedData;
     } else if (type === "Date") {
-      return dateFromRFC3339String(data)
+      try {
+        return dateFromRFC3339String(data)
+      } catch {
+        return new Date(data)
+      }
     } else {
       if (enumsMap[type]) {
         if (enumsMap[type].includes(data)) {

features/step_definitions/request_steps.ts

@@ -148,7 +148,7 @@ When("the request is sent", async function (this: World) {
     if (error instanceof datadogApiClient.client.ApiException) {
       this.response = error.body;
     } else {
-      this.response = error;
+      throw error;
     }
     logger.debug(error);
     if (this.requestContext === undefined) {
@@ -223,7 +223,7 @@ When("the request with pagination is sent", async function (this: World) {
     if (error instanceof datadogApiClient.client.ApiException) {
       this.response = error.body;
     } else {
-      this.response = error;
+      throw error;
     }
     logger.debug(error);
     if (this.requestContext === undefined) {

packages/datadog-api-client-v1/models/ObjectSerializer.ts

@@ -2280,7 +2280,11 @@ export class ObjectSerializer {
       }
       return transformedData;
     } else if (type === "Date") {
-      return dateFromRFC3339String(data);
+      try {
+        return dateFromRFC3339String(data);
+      } catch {
+        return new Date(data);
+      }
     } else {
       if (enumsMap[type]) {
         if (enumsMap[type].includes(data)) {

packages/datadog-api-client-v2/models/ObjectSerializer.ts

@@ -1957,7 +1957,11 @@ export class ObjectSerializer {
       }
       return transformedData;
     } else if (type === "Date") {
-      return dateFromRFC3339String(data);
+      try {
+        return dateFromRFC3339String(data);
+      } catch {
+        return new Date(data);
+      }
     } else {
       if (enumsMap[type]) {
         if (enumsMap[type].includes(data)) {

tests/api/date_time.test.ts

@@ -0,0 +1,45 @@
+import { MonthlyUsageAttributionResponse } from '../../packages/datadog-api-client-v1/models/MonthlyUsageAttributionResponse';
+import { ObjectSerializer as ObjectSerializerV1 } from '../../packages/datadog-api-client-v1/models/ObjectSerializer';
+
+test('TestDeserializationOfInvalidDates', () => {
+  const data = `
+  {
+    "usage":[
+       {
+          "org_name":"DD Integration Tests (321813)",
+          "public_id":"fasjyydbcgwwc2uc",
+          "tag_config_source":"DD Integration Tests (321813):::project",
+          "tags":null,
+          "updated_at":"2023-02-0",
+          "month":"2023-02-01T00:00:00+00:00",
+          "values":{
+             "infra_host_usage":44
+          }
+       }
+    ],
+    "metadata":{
+       "pagination":{
+          "next_record_id":null
+       },
+       "aggregates":[
+          {
+             "field":"infra_host_usage",
+             "value":45.0,
+             "agg_type":"sum"
+          }
+       ]
+    }
+  }
+  `;
+
+
+  const result = ObjectSerializerV1.deserialize(
+    ObjectSerializerV1.parse(data, "application/json"),
+    "MonthlyUsageAttributionResponse",
+    "");
+
+    // Invalid dates should be deserialized into an Invalid Date instance
+    expect(result).toBeInstanceOf(MonthlyUsageAttributionResponse)
+    expect(result.usage[0].updatedAt).toBeInstanceOf(Date);
+  }
+);