Exit early when generation fails (#831)

* introduce pre-commit wrapper

* remove echo

* Regenerate client from commit 33b7a42c of spec repo

Co-authored-by: Sherzod Karimov <[email protected]>
Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com>
Co-authored-by: ci.datadog-api-spec <[email protected]>

Author: 3 people

.apigentools-info

@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.6.4",
-            "regenerated": "2022-09-06 20:46:59.630821",
-            "spec_repo_commit": "36a61042"
+            "regenerated": "2022-09-07 19:30:40.870279",
+            "spec_repo_commit": "33b7a42c"
         },
         "v2": {
             "apigentools_version": "1.6.4",
-            "regenerated": "2022-09-06 20:46:59.643602",
-            "spec_repo_commit": "36a61042"
+            "regenerated": "2022-09-07 19:30:40.887104",
+            "spec_repo_commit": "33b7a42c"
         }
     }
 }

.pre-commit-config.yaml

@@ -4,7 +4,7 @@ repos:
       - id: generate
         name: Generate
         language: node
-        entry: make
+        entry: bash -c "./generate.sh"
         files: '^(\.generator/.*|\.pre-commit-config\.yaml|package\.json|yarn\.lock|\.eslintrc\.js|Makefile|\features/.*)'
         pass_filenames: false
       - id: lint

Makefile

@@ -0,0 +1,31 @@
+#!/bin/bash
+
+DEFAULT_ERROR_CODES="0"
+
+# First arg is the command
+# Second arg is the string of acceptable error codes seperated by space. E.g. "0 1"
+pre_commit_wrapper () {
+  echo "running pre-commit run --all-files --hook-stage=manual ${1}"
+
+  exec 5>&1
+  acceptable_errors=${2:-$DEFAULT_ERROR_CODES}
+  out=$(pre-commit run --all-files --hook-stage=manual "${1}" | tee >(cat - >&5))
+  exit_code=$( echo "$out" | grep -- "- exit code:"  | cut -d":" -f2 | sed 's/[^0-9]*//g' )
+
+  if [[ -n $exit_code ]]; then
+    re="([^0-9]|^)$exit_code([^0-9]|$)"
+    if ! grep -qE "$re" <<< "$acceptable_errors" ; then
+      echo "pre-commit subcommand failed with error_code: $exit_code. See output above"
+      exit "$exit_code";
+    fi
+  fi
+
+  echo "command 'pre-commit run --all-files --hook-stage=manual ${1}' success"
+}
+
+rm -rf packages/datadog-api-client-v*/ examples/v*
+rm -rf packages/datadog-api-client-*/
+pre_commit_wrapper generator
+pre_commit_wrapper lint
+pre_commit_wrapper examples
+pre_commit_wrapper lint-examples