Fix maxSignalDuration third party (#1796)

api-clients-generation-pipeline[bot] · ci.datadog-api-spec · web-flow · commit 712367e7142d · 2024-09-04T16:45:54.000Z
Co-authored-by: ci.datadog-api-spec &lt;packages@datadoghq.com&gt;
Co-authored-by: api-clients-generation-pipeline[bot] &lt;54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com&gt;
diff --git a/.apigentools-info b/.apigentools-info
@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.6.6",
-            "regenerated": "2024-09-04 14:47:44.917250",
-            "spec_repo_commit": "b31c228b"
+            "regenerated": "2024-09-04 15:23:39.357235",
+            "spec_repo_commit": "fe4f848e"
         },
         "v2": {
             "apigentools_version": "1.6.6",
-            "regenerated": "2024-09-04 14:47:44.935027",
-            "spec_repo_commit": "b31c228b"
+            "regenerated": "2024-09-04 15:23:39.375387",
+            "spec_repo_commit": "fe4f848e"
         }
     }
 }
diff --git a/cassettes/v2/Security-Monitoring_1187227211/Create-a-detection-rule-with-detection-method-third_party-returns-OK-response_1476655317/frozen.json b/cassettes/v2/Security-Monitoring_1187227211/Create-a-detection-rule-with-detection-method-third_party-returns-OK-response_1476655317/frozen.json
@@ -1 +1 @@
-"2024-05-10T16:34:29.476Z"
+"2024-09-04T13:32:10.858Z"
diff --git a/cassettes/v2/Security-Monitoring_1187227211/Create-a-detection-rule-with-detection-method-third_party-returns-OK-response_1476655317/recording.har b/cassettes/v2/Security-Monitoring_1187227211/Create-a-detection-rule-with-detection-method-third_party-returns-OK-response_1476655317/recording.har
@@ -8,11 +8,11 @@
     },
     "entries": [
       {
-        "_id": "e0cae6c45bce9e2ec7e3c0612ff52dde",
+        "_id": "57ee410b8aa681f4f5378b874f1d8305",
         "_order": 0,
         "cache": {},
         "request": {
-          "bodySize": 613,
+          "bodySize": 615,
           "cookies": [],
           "headers": [
             {
@@ -26,23 +26,23 @@
               "value": "application/json"
             }
           ],
-          "headersSize": 588,
+          "headersSize": 586,
           "httpVersion": "HTTP/1.1",
           "method": "POST",
           "postData": {
             "mimeType": "application/json",
             "params": [],
-            "text": "{\"cases\":[],\"isEnabled\":true,\"message\":\"This is a third party rule\",\"name\":\"Test-Create_a_detection_rule_with_detection_method_third_party_returns_OK_response-1715358869\",\"options\":{\"detectionMethod\":\"third_party\",\"keepAlive\":0,\"maxSignalDuration\":0,\"thirdPartyRuleOptions\":{\"defaultStatus\":\"info\",\"rootQueries\":[{\"groupByFields\":[\"instance-id\"],\"query\":\"source:guardduty @details.alertType:*EC2*\"},{\"groupByFields\":[],\"query\":\"source:guardduty\"}]}},\"queries\":[],\"thirdPartyCases\":[{\"name\":\"high\",\"query\":\"status:error\",\"status\":\"high\"},{\"name\":\"low\",\"query\":\"status:info\",\"status\":\"low\"}],\"type\":\"log_detection\"}"
+            "text": "{\"cases\":[],\"isEnabled\":true,\"message\":\"This is a third party rule\",\"name\":\"Test-Create_a_detection_rule_with_detection_method_third_party_returns_OK_response-1725456730\",\"options\":{\"detectionMethod\":\"third_party\",\"keepAlive\":0,\"maxSignalDuration\":600,\"thirdPartyRuleOptions\":{\"defaultStatus\":\"info\",\"rootQueries\":[{\"groupByFields\":[\"instance-id\"],\"query\":\"source:guardduty @details.alertType:*EC2*\"},{\"groupByFields\":[],\"query\":\"source:guardduty\"}]}},\"queries\":[],\"thirdPartyCases\":[{\"name\":\"high\",\"query\":\"status:error\",\"status\":\"high\"},{\"name\":\"low\",\"query\":\"status:info\",\"status\":\"low\"}],\"type\":\"log_detection\"}"
           },
           "queryString": [],
           "url": "https://api.datadoghq.com/api/v2/security_monitoring/rules"
         },
         "response": {
-          "bodySize": 1259,
+          "bodySize": 1276,
           "content": {
             "mimeType": "application/json",
-            "size": 1259,
-            "text": "{\"id\":\"uys-ie9-xgd\",\"version\":1,\"name\":\"Test-Create_a_detection_rule_with_detection_method_third_party_returns_OK_response-1715358869\",\"createdAt\":1715358869757,\"creationAuthorId\":1445416,\"isDefault\":false,\"isPartner\":false,\"isEnabled\":true,\"isDeleted\":false,\"isDeprecated\":false,\"queries\":[{\"query\":\"status:error\",\"groupByFields\":[],\"hasOptionalGroupByFields\":false,\"distinctFields\":[],\"aggregation\":\"none\",\"name\":\"\"},{\"query\":\"status:info\",\"groupByFields\":[],\"hasOptionalGroupByFields\":false,\"distinctFields\":[],\"aggregation\":\"none\",\"name\":\"\"}],\"options\":{\"keepAlive\":0,\"maxSignalDuration\":0,\"detectionMethod\":\"third_party\",\"evaluationWindow\":0,\"thirdPartyRuleOptions\":{\"defaultStatus\":\"info\",\"defaultNotifications\":[],\"rootQueries\":[{\"query\":\"source:guardduty @details.alertType:*EC2*\",\"groupByFields\":[\"instance-id\"]},{\"query\":\"source:guardduty\",\"groupByFields\":[]}]}},\"cases\":[{\"name\":\"high\",\"status\":\"high\",\"notifications\":[]},{\"name\":\"low\",\"status\":\"low\",\"notifications\":[]}],\"message\":\"This is a third party rule\",\"tags\":[],\"hasExtendedTitle\":false,\"type\":\"log_detection\",\"filters\":[],\"thirdPartyCases\":[{\"name\":\"high\",\"status\":\"high\",\"notifications\":[],\"query\":\"status:error\"},{\"name\":\"low\",\"status\":\"low\",\"notifications\":[],\"query\":\"status:info\"}]}\n"
+            "size": 1276,
+            "text": "{\"id\":\"rvf-kfc-pxh\",\"version\":1,\"name\":\"Test-Create_a_detection_rule_with_detection_method_third_party_returns_OK_response-1725456730\",\"createdAt\":1725456731210,\"creationAuthorId\":1445416,\"isDefault\":false,\"isPartner\":false,\"isEnabled\":true,\"isBeta\":false,\"isDeleted\":false,\"isDeprecated\":false,\"queries\":[{\"query\":\"status:error\",\"groupByFields\":[],\"hasOptionalGroupByFields\":false,\"distinctFields\":[],\"aggregation\":\"none\",\"name\":\"\"},{\"query\":\"status:info\",\"groupByFields\":[],\"hasOptionalGroupByFields\":false,\"distinctFields\":[],\"aggregation\":\"none\",\"name\":\"\"}],\"options\":{\"keepAlive\":0,\"maxSignalDuration\":600,\"detectionMethod\":\"third_party\",\"evaluationWindow\":0,\"thirdPartyRuleOptions\":{\"defaultStatus\":\"info\",\"defaultNotifications\":[],\"rootQueries\":[{\"query\":\"source:guardduty @details.alertType:*EC2*\",\"groupByFields\":[\"instance-id\"]},{\"query\":\"source:guardduty\",\"groupByFields\":[]}]}},\"cases\":[{\"name\":\"high\",\"status\":\"high\",\"notifications\":[]},{\"name\":\"low\",\"status\":\"low\",\"notifications\":[]}],\"message\":\"This is a third party rule\",\"tags\":[],\"hasExtendedTitle\":false,\"type\":\"log_detection\",\"filters\":[],\"thirdPartyCases\":[{\"name\":\"high\",\"status\":\"high\",\"notifications\":[],\"query\":\"status:error\"},{\"name\":\"low\",\"status\":\"low\",\"notifications\":[],\"query\":\"status:info\"}]}\n"
           },
           "cookies": [],
           "headers": [
@@ -57,11 +57,11 @@
           "status": 200,
           "statusText": "OK"
         },
-        "startedDateTime": "2024-05-10T16:34:29.478Z",
-        "time": 336
+        "startedDateTime": "2024-09-04T13:32:10.861Z",
+        "time": 432
       },
       {
-        "_id": "83482911a098ad48c5192c9d73c7f829",
+        "_id": "418be8cd9b52a555a25abcee39ab414e",
         "_order": 0,
         "cache": {},
         "request": {
@@ -74,11 +74,11 @@
               "value": "*/*"
             }
           ],
-          "headersSize": 536,
+          "headersSize": 534,
           "httpVersion": "HTTP/1.1",
           "method": "DELETE",
           "queryString": [],
-          "url": "https://api.datadoghq.com/api/v2/security_monitoring/rules/uys-ie9-xgd"
+          "url": "https://api.datadoghq.com/api/v2/security_monitoring/rules/rvf-kfc-pxh"
         },
         "response": {
           "bodySize": 0,
@@ -88,14 +88,14 @@
           },
           "cookies": [],
           "headers": [],
-          "headersSize": 602,
+          "headersSize": 601,
           "httpVersion": "HTTP/1.1",
           "redirectURL": "",
           "status": 204,
           "statusText": "No Content"
         },
-        "startedDateTime": "2024-05-10T16:34:29.819Z",
-        "time": 461
+        "startedDateTime": "2024-09-04T13:32:11.299Z",
+        "time": 370
       }
     ],
     "pages": [],
diff --git a/examples/v2/security-monitoring/CreateSecurityMonitoringRule_3367706049.ts b/examples/v2/security-monitoring/CreateSecurityMonitoringRule_3367706049.ts
@@ -30,7 +30,7 @@ const params: v2.SecurityMonitoringApiCreateSecurityMonitoringRuleRequest = {
     options: {
       detectionMethod: "third_party",
       keepAlive: 0,
-      maxSignalDuration: 0,
+      maxSignalDuration: 600,
       thirdPartyRuleOptions: {
         defaultStatus: "info",
         rootQueries: [
diff --git a/features/v2/security_monitoring.feature b/features/v2/security_monitoring.feature
@@ -133,7 +133,7 @@ Feature: Security Monitoring
   @team:DataDog/k9-cloud-security-platform
   Scenario: Create a detection rule with detection method 'third_party' returns "OK" response
     Given new "CreateSecurityMonitoringRule" request
-    And body with value {"name":"{{ unique }}","type":"log_detection","isEnabled":true,"thirdPartyCases":[{"query":"status:error","name":"high","status":"high"},{"query":"status:info","name":"low","status":"low"}],"queries":[],"cases":[],"message":"This is a third party rule","options":{"detectionMethod":"third_party","keepAlive":0,"maxSignalDuration":0,"thirdPartyRuleOptions":{"defaultStatus":"info","rootQueries":[{"query":"source:guardduty @details.alertType:*EC2*", "groupByFields":["instance-id"]},{"query":"source:guardduty", "groupByFields":[]}]}}}
+    And body with value {"name":"{{ unique }}","type":"log_detection","isEnabled":true,"thirdPartyCases":[{"query":"status:error","name":"high","status":"high"},{"query":"status:info","name":"low","status":"low"}],"queries":[],"cases":[],"message":"This is a third party rule","options":{"detectionMethod":"third_party","keepAlive":0,"maxSignalDuration":600,"thirdPartyRuleOptions":{"defaultStatus":"info","rootQueries":[{"query":"source:guardduty @details.alertType:*EC2*", "groupByFields":["instance-id"]},{"query":"source:guardduty", "groupByFields":[]}]}}}
     When the request is sent
     Then the response status is 200 OK
     And the response "name" is equal to "{{ unique }}"

Original file line number	Diff line number	Diff line change
`@@ -4,13 +4,13 @@`
`4`	`4`	`"spec_versions": {`
`5`	`5`	`"v1": {`
`6`	`6`	`"apigentools_version": "1.6.6",`
`7`		`- "regenerated": "2024-09-04 14:47:44.917250",`
`8`		`- "spec_repo_commit": "b31c228b"`
	`7`	`+ "regenerated": "2024-09-04 15:23:39.357235",`
	`8`	`+ "spec_repo_commit": "fe4f848e"`
`9`	`9`	`},`
`10`	`10`	`"v2": {`
`11`	`11`	`"apigentools_version": "1.6.6",`
`12`		`- "regenerated": "2024-09-04 14:47:44.935027",`
`13`		`- "spec_repo_commit": "b31c228b"`
	`12`	`+ "regenerated": "2024-09-04 15:23:39.375387",`
	`13`	`+ "spec_repo_commit": "fe4f848e"`
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-"2024-05-10T16:34:29.476Z"`
	`1`	`+"2024-09-04T13:32:10.858Z"`