Remove on_missing_data from custom schedule monitor test (#1409)

api-clients-generation-pipeline[bot] · ci.datadog-api-spec · web-flow · commit b41b1f16509a · 2023-11-10T07:47:40.000Z
Co-authored-by: ci.datadog-api-spec &lt;packages@datadoghq.com&gt;
Co-authored-by: api-clients-generation-pipeline[bot] &lt;54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com&gt;
diff --git a/.apigentools-info b/.apigentools-info
@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.6.6",
-            "regenerated": "2023-11-09 22:07:37.183507",
-            "spec_repo_commit": "893a406f"
+            "regenerated": "2023-11-10 07:21:07.103956",
+            "spec_repo_commit": "5d9edae7"
         },
         "v2": {
             "apigentools_version": "1.6.6",
-            "regenerated": "2023-11-09 22:07:37.197393",
-            "spec_repo_commit": "893a406f"
+            "regenerated": "2023-11-10 07:21:07.119789",
+            "spec_repo_commit": "5d9edae7"
         }
     }
 }
diff --git a/cassettes/v1/Monitors_4022238206/Create-a-metric-monitor-with-a-custom-schedule-returns-OK-response_3044937189/frozen.json b/cassettes/v1/Monitors_4022238206/Create-a-metric-monitor-with-a-custom-schedule-returns-OK-response_3044937189/frozen.json
@@ -1 +1 @@
-"2023-10-04T18:33:20.272Z"
+"2023-11-09T17:58:50.774Z"
diff --git a/cassettes/v1/Monitors_4022238206/Create-a-metric-monitor-with-a-custom-schedule-returns-OK-response_3044937189/recording.har b/cassettes/v1/Monitors_4022238206/Create-a-metric-monitor-with-a-custom-schedule-returns-OK-response_3044937189/recording.har
@@ -8,11 +8,11 @@
     },
     "entries": [
       {
-        "_id": "deccb00240d66320ccd75e55e2dcaa0e",
+        "_id": "7861bfa9b0524b7c54fe1fb8ade7bec7",
         "_order": 0,
         "cache": {},
         "request": {
-          "bodySize": 556,
+          "bodySize": 528,
           "cookies": [],
           "headers": [
             {
@@ -26,23 +26,23 @@
               "value": "application/json"
             }
           ],
-          "headersSize": 554,
+          "headersSize": 555,
           "httpVersion": "HTTP/1.1",
           "method": "POST",
           "postData": {
             "mimeType": "application/json",
             "params": [],
-            "text": "{\"message\":\"some message Notify: @hipchat-channel\",\"name\":\"Test-Create_a_metric_monitor_with_a_custom_schedule_returns_OK_response-1696444400\",\"options\":{\"include_tags\":false,\"notify_audit\":false,\"on_missing_data\":\"default\",\"scheduling_options\":{\"custom_schedule\":{\"recurrences\":[{\"rrule\":\"FREQ=DAILY;INTERVAL=1\",\"start\":\"2024-10-26T09:13:00\",\"timezone\":\"America/Los_Angeles\"}]},\"evaluation_window\":{\"day_starts\":\"04:00\",\"month_starts\":1}},\"thresholds\":{\"critical\":0.5}},\"query\":\"avg(current_1mo):avg:system.load.5{*} > 0.5\",\"tags\":[],\"type\":\"query alert\"}"
+            "text": "{\"message\":\"some message Notify: @hipchat-channel\",\"name\":\"Test-Create_a_metric_monitor_with_a_custom_schedule_returns_OK_response-1699552730\",\"options\":{\"include_tags\":false,\"notify_audit\":false,\"scheduling_options\":{\"custom_schedule\":{\"recurrences\":[{\"rrule\":\"FREQ=DAILY;INTERVAL=1\",\"start\":\"2024-10-26T09:13:00\",\"timezone\":\"America/Los_Angeles\"}]},\"evaluation_window\":{\"day_starts\":\"04:00\",\"month_starts\":1}},\"thresholds\":{\"critical\":0.5}},\"query\":\"avg(current_1mo):avg:system.load.5{*} > 0.5\",\"tags\":[],\"type\":\"query alert\"}"
           },
           "queryString": [],
           "url": "https://api.datadoghq.com/api/v1/monitor"
         },
         "response": {
-          "bodySize": 1009,
+          "bodySize": 981,
           "content": {
             "mimeType": "application/json",
-            "size": 1009,
-            "text": "{\"id\":132537965,\"org_id\":321813,\"type\":\"query alert\",\"name\":\"Test-Create_a_metric_monitor_with_a_custom_schedule_returns_OK_response-1696444400\",\"message\":\"some message Notify: @hipchat-channel\",\"tags\":[],\"query\":\"avg(current_1mo):avg:system.load.5{*} > 0.5\",\"options\":{\"include_tags\":false,\"notify_audit\":false,\"on_missing_data\":\"default\",\"scheduling_options\":{\"custom_schedule\":{\"recurrences\":[{\"rrule\":\"FREQ=DAILY;INTERVAL=1\",\"start\":\"2024-10-26T09:13:00\",\"timezone\":\"America/Los_Angeles\"}]},\"evaluation_window\":{\"day_starts\":\"04:00\",\"month_starts\":1}},\"thresholds\":{\"critical\":0.5},\"new_host_delay\":300,\"silenced\":{}},\"multi\":false,\"created_at\":1696444400000,\"created\":\"2023-10-04T18:33:20.388003+00:00\",\"modified\":\"2023-10-04T18:33:20.388003+00:00\",\"deleted\":null,\"restricted_roles\":null,\"priority\":null,\"overall_state_modified\":null,\"overall_state\":\"No Data\",\"creator\":{\"name\":\"CI Account\",\"handle\":\"9919ec9b-ebc7-49ee-8dc8-03626e717cca\",\"email\":\"team-intg-tools-libs-spam@datadoghq.com\",\"id\":2320499}}\n"
+            "size": 981,
+            "text": "{\"id\":134549556,\"org_id\":321813,\"type\":\"query alert\",\"name\":\"Test-Create_a_metric_monitor_with_a_custom_schedule_returns_OK_response-1699552730\",\"message\":\"some message Notify: @hipchat-channel\",\"tags\":[],\"query\":\"avg(current_1mo):avg:system.load.5{*} > 0.5\",\"options\":{\"include_tags\":false,\"notify_audit\":false,\"scheduling_options\":{\"custom_schedule\":{\"recurrences\":[{\"rrule\":\"FREQ=DAILY;INTERVAL=1\",\"start\":\"2024-10-26T09:13:00\",\"timezone\":\"America/Los_Angeles\"}]},\"evaluation_window\":{\"day_starts\":\"04:00\",\"month_starts\":1}},\"thresholds\":{\"critical\":0.5},\"new_host_delay\":300,\"silenced\":{}},\"multi\":false,\"created_at\":1699552731000,\"created\":\"2023-11-09T17:58:51.118858+00:00\",\"modified\":\"2023-11-09T17:58:51.118858+00:00\",\"deleted\":null,\"restricted_roles\":null,\"priority\":null,\"overall_state_modified\":null,\"overall_state\":\"No Data\",\"creator\":{\"name\":\"CI Account\",\"handle\":\"9919ec9b-ebc7-49ee-8dc8-03626e717cca\",\"email\":\"team-intg-tools-libs-spam@datadoghq.com\",\"id\":2320499}}\n"
           },
           "cookies": [],
           "headers": [
@@ -51,17 +51,17 @@
               "value": "application/json"
             }
           ],
-          "headersSize": 650,
+          "headersSize": 648,
           "httpVersion": "HTTP/1.1",
           "redirectURL": "",
           "status": 200,
           "statusText": "OK"
         },
-        "startedDateTime": "2023-10-04T18:33:20.283Z",
-        "time": 162
+        "startedDateTime": "2023-11-09T17:58:50.785Z",
+        "time": 414
       },
       {
-        "_id": "c27d7286a947939b7929a8fea2792902",
+        "_id": "6866c0f8f9db33100e7017cd83eedcf3",
         "_order": 0,
         "cache": {},
         "request": {
@@ -74,18 +74,18 @@
               "value": "application/json"
             }
           ],
-          "headersSize": 513,
+          "headersSize": 514,
           "httpVersion": "HTTP/1.1",
           "method": "DELETE",
           "queryString": [],
-          "url": "https://api.datadoghq.com/api/v1/monitor/132537965"
+          "url": "https://api.datadoghq.com/api/v1/monitor/134549556"
         },
         "response": {
           "bodySize": 33,
           "content": {
             "mimeType": "application/json",
             "size": 33,
-            "text": "{\"deleted_monitor_id\":132537965}\n"
+            "text": "{\"deleted_monitor_id\":134549556}\n"
           },
           "cookies": [],
           "headers": [
@@ -100,8 +100,8 @@
           "status": 200,
           "statusText": "OK"
         },
-        "startedDateTime": "2023-10-04T18:33:20.458Z",
-        "time": 342
+        "startedDateTime": "2023-11-09T17:58:51.211Z",
+        "time": 505
       }
     ],
     "pages": [],
diff --git a/examples/v1/monitors/CreateMonitor_1539578087.ts b/examples/v1/monitors/CreateMonitor_1539578087.ts
@@ -18,7 +18,6 @@ const params: v1.MonitorsApiCreateMonitorRequest = {
         critical: 0.5,
       },
       notifyAudit: false,
-      onMissingData: "default",
       includeTags: false,
       schedulingOptions: {
         evaluationWindow: {
diff --git a/features/v1/monitors.feature b/features/v1/monitors.feature
@@ -94,7 +94,7 @@ Feature: Monitors
   @team:DataDog/monitor-app
   Scenario: Create a metric monitor with a custom schedule returns "OK" response
     Given new "CreateMonitor" request
-    And body with value {"message":"some message Notify: @hipchat-channel","name":"{{ unique }}","query":"avg(current_1mo):avg:system.load.5{*} > 0.5","tags":[],"options":{"thresholds":{"critical":0.5},"notify_audit":false,"on_missing_data":"default","include_tags":false,"scheduling_options":{"evaluation_window":{"day_starts":"04:00", "month_starts":1},"custom_schedule":{"recurrences":[{"rrule":"FREQ=DAILY;INTERVAL=1","timezone":"America/Los_Angeles","start":"2024-10-26T09:13:00"}]}}},"type":"query alert"}
+    And body with value {"message":"some message Notify: @hipchat-channel","name":"{{ unique }}","query":"avg(current_1mo):avg:system.load.5{*} > 0.5","tags":[],"options":{"thresholds":{"critical":0.5},"notify_audit":false,"include_tags":false,"scheduling_options":{"evaluation_window":{"day_starts":"04:00", "month_starts":1},"custom_schedule":{"recurrences":[{"rrule":"FREQ=DAILY;INTERVAL=1","timezone":"America/Los_Angeles","start":"2024-10-26T09:13:00"}]}}},"type":"query alert"}
     When the request is sent
     Then the response status is 200 OK
     And the response "name" is equal to "{{ unique }}"

Original file line number	Diff line number	Diff line change
`@@ -4,13 +4,13 @@`
`4`	`4`	`"spec_versions": {`
`5`	`5`	`"v1": {`
`6`	`6`	`"apigentools_version": "1.6.6",`
`7`		`- "regenerated": "2023-11-09 22:07:37.183507",`
`8`		`- "spec_repo_commit": "893a406f"`
	`7`	`+ "regenerated": "2023-11-10 07:21:07.103956",`
	`8`	`+ "spec_repo_commit": "5d9edae7"`
`9`	`9`	`},`
`10`	`10`	`"v2": {`
`11`	`11`	`"apigentools_version": "1.6.6",`
`12`		`- "regenerated": "2023-11-09 22:07:37.197393",`
`13`		`- "spec_repo_commit": "893a406f"`
	`12`	`+ "regenerated": "2023-11-10 07:21:07.119789",`
	`13`	`+ "spec_repo_commit": "5d9edae7"`
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-"2023-10-04T18:33:20.272Z"`
	`1`	`+"2023-11-09T17:58:50.774Z"`