Fix spans/logs custom metrics delete operation responses (#1103)

api-clients-generation-pipeline[bot] · ci.datadog-api-spec · web-flow · commit c3c70ec095dc · 2023-04-18T17:43:37.000Z
Co-authored-by: ci.datadog-api-spec &lt;packages@datadoghq.com&gt;
diff --git a/.apigentools-info b/.apigentools-info
@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.6.4",
-            "regenerated": "2023-04-17 18:07:39.064189",
-            "spec_repo_commit": "25a92e6d"
+            "regenerated": "2023-04-18 17:35:12.113188",
+            "spec_repo_commit": "0c4beb36"
         },
         "v2": {
             "apigentools_version": "1.6.4",
-            "regenerated": "2023-04-17 18:07:39.076923",
-            "spec_repo_commit": "25a92e6d"
+            "regenerated": "2023-04-18 17:35:12.127152",
+            "spec_repo_commit": "0c4beb36"
         }
     }
 }
diff --git a/.generator/schemas/v2/openapi.yaml b/.generator/schemas/v2/openapi.yaml
@@ -14564,7 +14564,7 @@ paths:
       parameters:
       - $ref: '#/components/parameters/SpansMetricIDParameter'
       responses:
-        '200':
+        '204':
           description: OK
         '403':
           $ref: '#/components/responses/NotAuthorizedResponse'
@@ -18090,7 +18090,7 @@ paths:
       parameters:
       - $ref: '#/components/parameters/MetricID'
       responses:
-        '200':
+        '204':
           description: OK
         '403':
           $ref: '#/components/responses/NotAuthorizedResponse'
diff --git a/cassettes/v2/Logs-Metrics_3185148095/Delete-a-log-based-metric-returns-OK-response_1536464549/frozen.json b/cassettes/v2/Logs-Metrics_3185148095/Delete-a-log-based-metric-returns-OK-response_1536464549/frozen.json
@@ -1 +1 @@
-"2022-05-12T09:52:23.762Z"
+"2023-04-18T17:27:11.097Z"
diff --git a/cassettes/v2/Logs-Metrics_3185148095/Delete-a-log-based-metric-returns-OK-response_1536464549/recording.har b/cassettes/v2/Logs-Metrics_3185148095/Delete-a-log-based-metric-returns-OK-response_1536464549/recording.har
@@ -8,7 +8,7 @@
     },
     "entries": [
       {
-        "_id": "b9e060180894969b2f3cd8898f7bf343",
+        "_id": "756a0b409fbb03651b2aa8966134a09f",
         "_order": 0,
         "cache": {},
         "request": {
@@ -32,17 +32,17 @@
           "postData": {
             "mimeType": "application/json",
             "params": [],
-            "text": "{\"data\":{\"attributes\":{\"compute\":{\"aggregation_type\":\"count\"},\"filter\":{\"query\":\"source:Test-Delete_a_log_based_metric_returns_OK_response-1652349143\"}},\"id\":\"Test-Delete_a_log_based_metric_returns_OK_response-1652349143\",\"type\":\"logs_metrics\"}}"
+            "text": "{\"data\":{\"attributes\":{\"compute\":{\"aggregation_type\":\"count\"},\"filter\":{\"query\":\"source:Test-Delete_a_log_based_metric_returns_OK_response-1681838831\"}},\"id\":\"Test-Delete_a_log_based_metric_returns_OK_response-1681838831\",\"type\":\"logs_metrics\"}}"
           },
           "queryString": [],
           "url": "https://api.datadoghq.com/api/v2/logs/config/metrics"
         },
         "response": {
-          "bodySize": 259,
+          "bodySize": 260,
           "content": {
             "mimeType": "application/json",
-            "size": 259,
-            "text": "{\"data\":{\"attributes\":{\"filter\":{\"query\":\"source:Test-Delete_a_log_based_metric_returns_OK_response-1652349143\"},\"group_by\":[],\"compute\":{\"aggregation_type\":\"count\"}},\"type\":\"logs_metrics\",\"id\":\"Test_Delete_a_log_based_metric_returns_OK_response_1652349143\"}}"
+            "size": 260,
+            "text": "{\"data\":{\"id\":\"Test_Delete_a_log_based_metric_returns_OK_response_1681838831\",\"attributes\":{\"filter\":{\"query\":\"source:Test-Delete_a_log_based_metric_returns_OK_response-1681838831\"},\"group_by\":[],\"compute\":{\"aggregation_type\":\"count\"}},\"type\":\"logs_metrics\"}}\n"
           },
           "cookies": [],
           "headers": [
@@ -51,17 +51,17 @@
               "value": "application/json"
             }
           ],
-          "headersSize": 692,
+          "headersSize": 676,
           "httpVersion": "HTTP/1.1",
           "redirectURL": "",
           "status": 200,
           "statusText": "OK"
         },
-        "startedDateTime": "2022-05-12T09:52:23.764Z",
-        "time": 555
+        "startedDateTime": "2023-04-18T17:27:11.104Z",
+        "time": 447
       },
       {
-        "_id": "64a7bae11f24ed7ca9008e4705725a6b",
+        "_id": "a668a5d7ac44f86e13101356ffc7ba38",
         "_order": 0,
         "cache": {},
         "request": {
@@ -78,33 +78,32 @@
           "httpVersion": "HTTP/1.1",
           "method": "DELETE",
           "queryString": [],
-          "url": "https://api.datadoghq.com/api/v2/logs/config/metrics/Test_Delete_a_log_based_metric_returns_OK_response_1652349143"
+          "url": "https://api.datadoghq.com/api/v2/logs/config/metrics/Test_Delete_a_log_based_metric_returns_OK_response_1681838831"
         },
         "response": {
-          "bodySize": 2,
+          "bodySize": 0,
           "content": {
-            "mimeType": "application/json",
-            "size": 2,
-            "text": "{}"
+            "mimeType": "text/html; charset=utf-8",
+            "size": 0
           },
           "cookies": [],
           "headers": [
             {
               "name": "content-type",
-              "value": "application/json"
+              "value": "text/html; charset=utf-8"
             }
           ],
-          "headersSize": 667,
+          "headersSize": 663,
           "httpVersion": "HTTP/1.1",
           "redirectURL": "",
-          "status": 200,
-          "statusText": "OK"
+          "status": 204,
+          "statusText": "No Content"
         },
-        "startedDateTime": "2022-05-12T09:52:24.324Z",
-        "time": 423
+        "startedDateTime": "2023-04-18T17:27:11.575Z",
+        "time": 290
       },
       {
-        "_id": "64a7bae11f24ed7ca9008e4705725a6b",
+        "_id": "a668a5d7ac44f86e13101356ffc7ba38",
         "_order": 1,
         "cache": {},
         "request": {
@@ -121,14 +120,14 @@
           "httpVersion": "HTTP/1.1",
           "method": "DELETE",
           "queryString": [],
-          "url": "https://api.datadoghq.com/api/v2/logs/config/metrics/Test_Delete_a_log_based_metric_returns_OK_response_1652349143"
+          "url": "https://api.datadoghq.com/api/v2/logs/config/metrics/Test_Delete_a_log_based_metric_returns_OK_response_1681838831"
         },
         "response": {
-          "bodySize": 116,
+          "bodySize": 117,
           "content": {
             "mimeType": "application/json",
-            "size": 116,
-            "text": "{\"errors\":[\"not_found(Metric with name 'Test_Delete_a_log_based_metric_returns_OK_response_1652349143' not found)\"]}"
+            "size": 117,
+            "text": "{\"errors\":[\"not_found(Metric with name 'Test_Delete_a_log_based_metric_returns_OK_response_1681838831' not found)\"]}\n"
           },
           "cookies": [],
           "headers": [
@@ -137,14 +136,14 @@
               "value": "application/json"
             }
           ],
-          "headersSize": 692,
+          "headersSize": 676,
           "httpVersion": "HTTP/1.1",
           "redirectURL": "",
           "status": 404,
           "statusText": "Not Found"
         },
-        "startedDateTime": "2022-05-12T09:52:24.753Z",
-        "time": 502
+        "startedDateTime": "2023-04-18T17:27:11.878Z",
+        "time": 291
       }
     ],
     "pages": [],
diff --git a/cassettes/v2/Spans-Metrics_2509732495/Delete-a-span-based-metric-returns-OK-response_1713567809/frozen.json b/cassettes/v2/Spans-Metrics_2509732495/Delete-a-span-based-metric-returns-OK-response_1713567809/frozen.json
@@ -1 +1 @@
-"2023-03-28T14:55:25.279Z"
+"2023-04-18T17:28:08.946Z"
diff --git a/cassettes/v2/Spans-Metrics_2509732495/Delete-a-span-based-metric-returns-OK-response_1713567809/recording.har b/cassettes/v2/Spans-Metrics_2509732495/Delete-a-span-based-metric-returns-OK-response_1713567809/recording.har
@@ -8,7 +8,7 @@
     },
     "entries": [
       {
-        "_id": "3cbb3815f6e07de4b0ae7bfa2b3acbbe",
+        "_id": "a0db5bd16c235f55945b7e2ecec0ec45",
         "_order": 0,
         "cache": {},
         "request": {
@@ -32,7 +32,7 @@
           "postData": {
             "mimeType": "application/json",
             "params": [],
-            "text": "{\"data\":{\"attributes\":{\"compute\":{\"aggregation_type\":\"distribution\",\"include_percentiles\":false,\"path\":\"@duration\"},\"filter\":{\"query\":\"source:Test-Delete_a_span_based_metric_returns_OK_response-1680015325\"},\"group_by\":[{\"path\":\"resource_name\",\"tag_name\":\"resource_name\"}]},\"id\":\"Test-Delete_a_span_based_metric_returns_OK_response-1680015325\",\"type\":\"spans_metrics\"}}"
+            "text": "{\"data\":{\"attributes\":{\"compute\":{\"aggregation_type\":\"distribution\",\"include_percentiles\":false,\"path\":\"@duration\"},\"filter\":{\"query\":\"source:Test-Delete_a_span_based_metric_returns_OK_response-1681838888\"},\"group_by\":[{\"path\":\"resource_name\",\"tag_name\":\"resource_name\"}]},\"id\":\"Test-Delete_a_span_based_metric_returns_OK_response-1681838888\",\"type\":\"spans_metrics\"}}"
           },
           "queryString": [],
           "url": "https://api.datadoghq.com/api/v2/apm/config/metrics"
@@ -42,7 +42,7 @@
           "content": {
             "mimeType": "application/json",
             "size": 368,
-            "text": "{\"data\":{\"id\":\"Test_Delete_a_span_based_metric_returns_OK_response_1680015325\",\"attributes\":{\"filter\":{\"query\":\"source:Test-Delete_a_span_based_metric_returns_OK_response-1680015325\"},\"group_by\":[{\"path\":\"resource_name\",\"tag_name\":\"resource_name\"}],\"compute\":{\"aggregation_type\":\"distribution\",\"path\":\"@duration\",\"include_percentiles\":false}},\"type\":\"spans_metrics\"}}\n"
+            "text": "{\"data\":{\"id\":\"Test_Delete_a_span_based_metric_returns_OK_response_1681838888\",\"attributes\":{\"filter\":{\"query\":\"source:Test-Delete_a_span_based_metric_returns_OK_response-1681838888\"},\"group_by\":[{\"path\":\"resource_name\",\"tag_name\":\"resource_name\"}],\"compute\":{\"aggregation_type\":\"distribution\",\"path\":\"@duration\",\"include_percentiles\":false}},\"type\":\"spans_metrics\"}}\n"
           },
           "cookies": [],
           "headers": [
@@ -51,17 +51,17 @@
               "value": "application/json"
             }
           ],
-          "headersSize": 490,
+          "headersSize": 517,
           "httpVersion": "HTTP/1.1",
           "redirectURL": "",
           "status": 200,
           "statusText": "OK"
         },
-        "startedDateTime": "2023-03-28T14:55:25.285Z",
-        "time": 700
+        "startedDateTime": "2023-04-18T17:28:08.954Z",
+        "time": 532
       },
       {
-        "_id": "42dcd81b586890915d89cbab9977880d",
+        "_id": "688ed938a13004c69b174871ce9ddaa8",
         "_order": 0,
         "cache": {},
         "request": {
@@ -78,33 +78,32 @@
           "httpVersion": "HTTP/1.1",
           "method": "DELETE",
           "queryString": [],
-          "url": "https://api.datadoghq.com/api/v2/apm/config/metrics/Test_Delete_a_span_based_metric_returns_OK_response_1680015325"
+          "url": "https://api.datadoghq.com/api/v2/apm/config/metrics/Test_Delete_a_span_based_metric_returns_OK_response_1681838888"
         },
         "response": {
-          "bodySize": 3,
+          "bodySize": 0,
           "content": {
-            "mimeType": "application/json",
-            "size": 3,
-            "text": "{}\n"
+            "mimeType": "text/html; charset=utf-8",
+            "size": 0
           },
           "cookies": [],
           "headers": [
             {
               "name": "content-type",
-              "value": "application/json"
+              "value": "text/html; charset=utf-8"
             }
           ],
-          "headersSize": 465,
+          "headersSize": 504,
           "httpVersion": "HTTP/1.1",
           "redirectURL": "",
-          "status": 200,
-          "statusText": "OK"
+          "status": 204,
+          "statusText": "No Content"
         },
-        "startedDateTime": "2023-03-28T14:55:25.996Z",
-        "time": 410
+        "startedDateTime": "2023-04-18T17:28:09.499Z",
+        "time": 232
       },
       {
-        "_id": "42dcd81b586890915d89cbab9977880d",
+        "_id": "688ed938a13004c69b174871ce9ddaa8",
         "_order": 1,
         "cache": {},
         "request": {
@@ -121,14 +120,14 @@
           "httpVersion": "HTTP/1.1",
           "method": "DELETE",
           "queryString": [],
-          "url": "https://api.datadoghq.com/api/v2/apm/config/metrics/Test_Delete_a_span_based_metric_returns_OK_response_1680015325"
+          "url": "https://api.datadoghq.com/api/v2/apm/config/metrics/Test_Delete_a_span_based_metric_returns_OK_response_1681838888"
         },
         "response": {
           "bodySize": 118,
           "content": {
             "mimeType": "application/json",
             "size": 118,
-            "text": "{\"errors\":[\"not_found(Metric with name 'Test_Delete_a_span_based_metric_returns_OK_response_1680015325' not found)\"]}\n"
+            "text": "{\"errors\":[\"not_found(Metric with name 'Test_Delete_a_span_based_metric_returns_OK_response_1681838888' not found)\"]}\n"
           },
           "cookies": [],
           "headers": [
@@ -137,14 +136,14 @@
               "value": "application/json"
             }
           ],
-          "headersSize": 490,
+          "headersSize": 517,
           "httpVersion": "HTTP/1.1",
           "redirectURL": "",
           "status": 404,
           "statusText": "Not Found"
         },
-        "startedDateTime": "2023-03-28T14:55:26.416Z",
-        "time": 426
+        "startedDateTime": "2023-04-18T17:28:09.741Z",
+        "time": 195
       }
     ],
     "pages": [],
diff --git a/features/v2/logs_metrics.feature b/features/v2/logs_metrics.feature
@@ -47,7 +47,7 @@ Feature: Logs Metrics
     And new "DeleteLogsMetric" request
     And request contains "metric_id" parameter from "logs_metric.data.id"
     When the request is sent
-    Then the response status is 200 OK
+    Then the response status is 204 OK
 
   @generated @skip @team:DataDog/logs-backend
   Scenario: Get a log-based metric returns "Not Found" response
diff --git a/features/v2/spans_metrics.feature b/features/v2/spans_metrics.feature
@@ -46,7 +46,7 @@ Feature: Spans Metrics
     And new "DeleteSpansMetric" request
     And request contains "metric_id" parameter from "spans_metric.data.id"
     When the request is sent
-    Then the response status is 200 OK
+    Then the response status is 204 OK
 
   @generated @skip @team:DataDog/apm
   Scenario: Get a span-based metric returns "Not Found" response
diff --git a/packages/datadog-api-client-v2/apis/LogsMetricsApi.ts b/packages/datadog-api-client-v2/apis/LogsMetricsApi.ts
@@ -288,7 +288,7 @@ export class LogsMetricsApiResponseProcessor {
     const contentType = ObjectSerializer.normalizeMediaType(
       response.headers["content-type"]
     );
-    if (response.httpStatusCode == 200) {
+    if (response.httpStatusCode == 204) {
       return;
     }
     if (
diff --git a/packages/datadog-api-client-v2/apis/SpansMetricsApi.ts b/packages/datadog-api-client-v2/apis/SpansMetricsApi.ts
@@ -288,7 +288,7 @@ export class SpansMetricsApiResponseProcessor {
     const contentType = ObjectSerializer.normalizeMediaType(
       response.headers["content-type"]
     );
-    if (response.httpStatusCode == 200) {
+    if (response.httpStatusCode == 204) {
       return;
     }
     if (

Original file line number	Diff line number	Diff line change
`@@ -4,13 +4,13 @@`
`4`	`4`	`"spec_versions": {`
`5`	`5`	`"v1": {`
`6`	`6`	`"apigentools_version": "1.6.4",`
`7`		`- "regenerated": "2023-04-17 18:07:39.064189",`
`8`		`- "spec_repo_commit": "25a92e6d"`
	`7`	`+ "regenerated": "2023-04-18 17:35:12.113188",`
	`8`	`+ "spec_repo_commit": "0c4beb36"`
`9`	`9`	`},`
`10`	`10`	`"v2": {`
`11`	`11`	`"apigentools_version": "1.6.4",`
`12`		`- "regenerated": "2023-04-17 18:07:39.076923",`
`13`		`- "spec_repo_commit": "25a92e6d"`
	`12`	`+ "regenerated": "2023-04-18 17:35:12.127152",`
	`13`	`+ "spec_repo_commit": "0c4beb36"`
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-"2022-05-12T09:52:23.762Z"`
	`1`	`+"2023-04-18T17:27:11.097Z"`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-"2023-03-28T14:55:25.279Z"`
	`1`	`+"2023-04-18T17:28:08.946Z"`
Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ export class LogsMetricsApiResponseProcessor {`
`288`	`288`	`const contentType = ObjectSerializer.normalizeMediaType(`
`289`	`289`	`response.headers["content-type"]`
`290`	`290`	`);`
`291`		`- if (response.httpStatusCode == 200) {`
	`291`	`+ if (response.httpStatusCode == 204) {`
`292`	`292`	`return;`
`293`	`293`	`}`
`294`	`294`	`if (`
Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ export class SpansMetricsApiResponseProcessor {`
`288`	`288`	`const contentType = ObjectSerializer.normalizeMediaType(`
`289`	`289`	`response.headers["content-type"]`
`290`	`290`	`);`
`291`		`- if (response.httpStatusCode == 200) {`
	`291`	`+ if (response.httpStatusCode == 204) {`
`292`	`292`	`return;`
`293`	`293`	`}`
`294`	`294`	`if (`