Apply static analysis changes (#1488)

* apply rules

* generate

* pre-commit fixes

---------

Co-authored-by: ci.datadog-api-spec <[email protected]>

Author: skarimo

.generator/src/generator/templates/api/api.j2

@@ -166,7 +166,7 @@ export class {{ className }}ResponseProcessor {
     {%- set responseSchema = response|parameter_schema %}
     if (
       {%- for responseCode in responseCodes -%}
-      {%- if not loop.first -%} || {%- endif -%} response.httpStatusCode == {{ responseCode }}
+      {%- if not loop.first -%} || {%- endif -%} response.httpStatusCode === {{ responseCode }}
       {%- endfor -%}
       ) {
       {%- if responseType %}

.generator/src/generator/templates/http/isomorphic-fetch.j2

@@ -3,6 +3,7 @@ import { fetch as crossFetch } from "cross-fetch";
 import pako from "pako";
 import bufferFrom from "buffer-from";
 import { isBrowser, isNode } from "../util";
+import { logger } from "../../../logger";
 
 export class IsomorphicFetchHttpLibrary implements HttpLibrary {
   public debug = false;
@@ -27,11 +28,11 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary {
     const headers = request.getHeaders();
 
     if (typeof body === "string") {
-      if (headers["Content-Encoding"] == "gzip") {
+      if (headers["Content-Encoding"] === "gzip") {
         body = bufferFrom(pako.gzip(body).buffer);
-      } else if (headers["Content-Encoding"] == "deflate") {
+      } else if (headers["Content-Encoding"] === "deflate") {
         body = bufferFrom(pako.deflate(body).buffer);
-      } else if (headers["Content-Encoding"] == "zstd1") {
+      } else if (headers["Content-Encoding"] === "zstd1") {
         if (this.zstdCompressorCallback) {
           body = this.zstdCompressorCallback(body);
         } else {
@@ -116,7 +117,7 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary {
       }
       return response;
     } catch (error) {
-      console.error("An error occurred during the HTTP request:", error);
+      logger.error("An error occurred during the HTTP request:", error);
       throw error;
     }
   }
@@ -128,7 +129,7 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary {
   }
 
   private shouldRetry(enableRetry:boolean, currentAttempt:number, maxRetries:number, responseCode:number):boolean{
-    return (responseCode == 429 || responseCode >=500 ) && maxRetries>currentAttempt && enableRetry
+    return (responseCode === 429 || responseCode >= 500 ) && maxRetries > currentAttempt && enableRetry
   }
 
   private calculateRetryInterval(currentAttempt:number, backoffBase:number, backoffMultiplier:number, headers: {[name: string]: string}) : number{
@@ -165,7 +166,7 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary {
       : "";
     const compress = request.getHttpConfig().compress ?? true;
 
-    console.debug(
+    logger.debug(
       "\nrequest: {\n",
       `\turl: ${url}\n`,
       `\tmethod: ${method}\n`,
@@ -181,7 +182,7 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary {
       /\n/g,
       "\n\t"
     );
-    console.debug(
+    logger.debug(
       "response: {\n",
       `\tstatus: ${httpStatusCode}\n`,
       `\theaders: ${headers}\n`

README.md

@@ -254,9 +254,9 @@ class HttpLibraryWithProxy implements client.HttpLibrary {
 
         const headers = request.getHeaders();
         if (typeof body === "string") {
-            if (headers["Content-Encoding"] == "gzip") {
+            if (headers["Content-Encoding"] === "gzip") {
                 body = bufferFrom(pako.gzip(body).buffer);
-            } else if (headers["Content-Encoding"] == "deflate") {
+            } else if (headers["Content-Encoding"] === "deflate") {
                 body = bufferFrom(pako.deflate(body).buffer);
             }
         }

features/support/undo.ts

@@ -47,7 +47,7 @@ function buildUndoFor(
   request: any
 ): { (): void } {
   return async function () {
-    var apiName = operationUndo.tag.replace(/\s/g, "");
+    let apiName = operationUndo.tag.replace(/\s/g, "");
     if (operationUndo.undo.tag != null) {
       apiName = operationUndo.undo.tag.replace(/\s/g, "");
     }
@@ -87,7 +87,7 @@ function buildUndoFor(
     // perform operation
     const opts: { [key: string]: any } = {};
     for (const p of operationUndo.undo.parameters) {
-      var dataSource: { [key: string]: any; };
+      let dataSource: { [key: string]: any; };
       if (p.origin === undefined) {
          dataSource = response;
       } else if (p.origin === "request") {

packages/datadog-api-client-common/http/isomorphic-fetch.ts

@@ -8,6 +8,7 @@ import { fetch as crossFetch } from "cross-fetch";
 import pako from "pako";
 import bufferFrom from "buffer-from";
 import { isBrowser, isNode } from "../util";
+import { logger } from "../../../logger";
 
 export class IsomorphicFetchHttpLibrary implements HttpLibrary {
   public debug = false;
@@ -32,11 +33,11 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary {
     const headers = request.getHeaders();
 
     if (typeof body === "string") {
-      if (headers["Content-Encoding"] == "gzip") {
+      if (headers["Content-Encoding"] === "gzip") {
         body = bufferFrom(pako.gzip(body).buffer);
-      } else if (headers["Content-Encoding"] == "deflate") {
+      } else if (headers["Content-Encoding"] === "deflate") {
         body = bufferFrom(pako.deflate(body).buffer);
-      } else if (headers["Content-Encoding"] == "zstd1") {
+      } else if (headers["Content-Encoding"] === "zstd1") {
         if (this.zstdCompressorCallback) {
           body = this.zstdCompressorCallback(body);
         } else {
@@ -122,7 +123,7 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary {
       }
       return response;
     } catch (error) {
-      console.error("An error occurred during the HTTP request:", error);
+      logger.error("An error occurred during the HTTP request:", error);
       throw error;
     }
   }
@@ -140,7 +141,7 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary {
     responseCode: number
   ): boolean {
     return (
-      (responseCode == 429 || responseCode >= 500) &&
+      (responseCode === 429 || responseCode >= 500) &&
       maxRetries > currentAttempt &&
       enableRetry
     );
@@ -185,7 +186,7 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary {
       : "";
     const compress = request.getHttpConfig().compress ?? true;
 
-    console.debug(
+    logger.debug(
       "\nrequest: {\n",
       `\turl: ${url}\n`,
       `\tmethod: ${method}\n`,
@@ -201,7 +202,7 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary {
       /\n/g,
       "\n\t"
     );
-    console.debug(
+    logger.debug(
       "response: {\n",
       `\tstatus: ${httpStatusCode}\n`,
       `\theaders: ${headers}\n`